From 3b30d0ff8898df8e40f1a7ff347bf0f9f9287eee Mon Sep 17 00:00:00 2001
From: Hans Johnson <hans-johnson@uiowa.edu>
Date: Mon, 24 Feb 2020 14:04:58 -0600
Subject: [PATCH] STYLE: Make prototype match definition names

Enforce consistency in large projects, where it often happens that a definition
of function is refactored, changing the parameter names, but its declaration in
header file is not updated. With this check, we can easily find and correct
such inconsistencies, keeping declaration and definition always in sync.

Unnamed parameters are allowed and are not taken into account when comparing
function declarations
---
 SystemTools.cxx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SystemTools.cxx b/SystemTools.cxx
index ec03518..b3e20c7 100644
--- a/SystemTools.cxx
+++ b/SystemTools.cxx
@@ -488,7 +488,7 @@ public:
    */
   static std::string FindName(
     const std::string& name,
-    const std::vector<std::string>& path = std::vector<std::string>(),
+    const std::vector<std::string>& userPaths = std::vector<std::string>(),
     bool no_system_path = false);
 };
 
-- 
GitLab