1. 31 Jul, 2018 7 commits
  2. 30 Jul, 2018 2 commits
  3. 28 Jul, 2018 5 commits
  4. 27 Jul, 2018 5 commits
  5. 26 Jul, 2018 17 commits
    • David Gobbi's avatar
      Merge topic 'wrap-const-char' · d6fcd519
      David Gobbi authored
      8837686f Safe wrapping of non-const char pointer arguments
      22d2c59f Fix char pointer constness for wrapper built-in methods
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: David E. DeMarle's avatarDavid E. DeMarle <dave.demarle@kitware.com>
      Acked-by: Jean-Christophe Fillion-Robin's avatarJean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
      Merge-request: !4489
      d6fcd519
    • Ken Martin's avatar
      Merge topic 'fix_dynamic_analysis_issues' · 5cc9ff6d
      Ken Martin authored
      3154b525 fix some dynamic analysis issues
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Merge-request: !4535
      5cc9ff6d
    • Berk Geveci's avatar
      Merge topic 'include_string_in_vtkmProbe' · 39f1798c
      Berk Geveci authored
      1bb7565c vtkmProbe includes the required std headers it needs
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: Berk Geveci's avatarBerk Geveci <berk.geveci@kitware.com>
      Merge-request: !4536
      39f1798c
    • Robert Maynard's avatar
      vtkmProbe includes the required std headers it needs · 1bb7565c
      Robert Maynard authored
      vtkmProbe uses std::string and should make sure it includes that
      header
      1bb7565c
    • Sean McBride's avatar
      Merge topic 'cppcheck1.84' · b58a17f0
      Sean McBride authored
      c0d6d943 Added missing overrides found by cppcheck 1.84
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: Ken Martin's avatarKen Martin <ken.martin@kitware.com>
      Merge-request: !4459
      b58a17f0
    • Ken Martin's avatar
      fix some dynamic analysis issues · 3154b525
      Ken Martin authored
      When landmark transform is degenerate avoid
      divide by zero.
      
      Fix a few memcpy of nullptr.
      3154b525
    • David Gobbi's avatar
      Safe wrapping of non-const char pointer arguments · 8837686f
      David Gobbi authored
      Previously, the contents of a Python 'str' would be passed
      directly to C++ methods that took non-const 'char *' arguments.
      This was bad, since 'str' is immutable but there was no guarantee
      that the C++ method wouldn't try to modify the string.  Now the
      C++ method receives a copy of the Python string for 'char *' args
      and only directly receives the contents for 'const char *' args.
      If a bytearray or other mutable sequence is passed as 'char *',
      then the wrappers will write any modifications back to Python.
      
      In Python 3.7 the PyUnicode_AsUTF8() method was changed so that
      it returns "const char *" instead of returning "char *", so this
      commit is needed in order to compile VTK with Python 3.7.
      8837686f
    • David Gobbi's avatar
      22d2c59f
    • Sebastien Jourdain's avatar
      Merge topic 'fix-vera-out-reader-memory-leak' · fb7a8ffd
      Sebastien Jourdain authored
      24e2bea2 fix(vtkVeraOutReader): Memory leak
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Merge-request: !4534
      fb7a8ffd
    • Andrew Bauer's avatar
      Merge topic 'ghost_cell_generator_bug_fix' · 5de51292
      Andrew Bauer authored
      771fc75d Fix issue with single cell for ghost cells generator.
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: David E. DeMarle's avatarDavid E. DeMarle <dave.demarle@kitware.com>
      Merge-request: !4528
      5de51292
    • Sebastien Jourdain's avatar
      fix(vtkVeraOutReader): Memory leak · 24e2bea2
      Sebastien Jourdain authored
      24e2bea2
    • Sean McBride's avatar
      Added missing overrides found by cppcheck 1.84 · c0d6d943
      Sean McBride authored
      missingOverride,Examples/GUI/Win32/SampleMFC/SampleDoc.h:47
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:49
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:50
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:52
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:54
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:61
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:62
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:69
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:70
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:60
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:61
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:62
      missingOverride,IO/ADIOS/FunctionPointers.h:114
      missingOverride,IO/Video/vtkMILVideoSource.h:104
      missingOverride,IO/Video/vtkMILVideoSource.h:243
      missingOverride,IO/Video/vtkMILVideoSource.h:249
      missingOverride,IO/Video/vtkMILVideoSource.h:259
      missingOverride,IO/Video/vtkMILVideoSource.h:79
      missingOverride,IO/Video/vtkMILVideoSource.h:84
      missingOverride,IO/Video/vtkMILVideoSource.h:89
      missingOverride,IO/Video/vtkMILVideoSource.h:94
      missingOverride,IO/Video/vtkMILVideoSource.h:99
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:206
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:219
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:220
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:68
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:238
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:239
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:66
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:37
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:43
      missingOverride,Rendering/OptiX/vtkOptiXCompositePolyDataMapper2Node.h:45,style,The function 'Render' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,Utilities/Benchmarks/GLBenchmarking.cxx:74
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:162
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:164
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:166
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:270
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:273
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:276
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:409
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:414
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:419
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:532
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:534
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:536
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:58
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:60
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:62
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:658
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:660
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:662
      missingOverride,IO/ADIOS/ADIOSWriter.cxx:159,style,The function 'GetInt' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:31,style,The function 'ExecVoid' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:50,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:69,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:90,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      c0d6d943
    • Sean McBride's avatar
      Merge topic 'vtkMathReview' · a01fc64a
      Sean McBride authored
      b889b631 Introduce VTK's first use of C++11's std::lround() (in a test)
      27579ded Deprecated non-thread-safe colour conversion functions
      f98c02bb Code review of vtkMath clamping
      b4f84fe1 Added const to various vtkMath API
      a7ceef61 Replace some int with vtkTypeBool (if public) or bool (if private)
      a440133b General code review of vtkMath: trivial & conservative
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: David Gobbi's avatarDavid Gobbi <david.gobbi@gmail.com>
      Merge-request: !3299
      a01fc64a
    • T.J. Corona's avatar
      Merge topic 'fix-CoplanarTriangleIntersection' · 6144e9eb
      T.J. Corona authored
      b13f713e Add tests for triangle intersection fixes.
      caa51b1a Fix for CoplanarTrianglesIntersect
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Reviewed-by: T.J. Corona's avatarT.J. Corona <tj.corona@kitware.com>
      Merge-request: !4532
      6144e9eb
    • T.J. Corona's avatar
      Add tests for triangle intersection fixes. · b13f713e
      T.J. Corona authored
      b13f713e
    • Maik Froechtenicht's avatar
      Fix for CoplanarTrianglesIntersect · caa51b1a
      Maik Froechtenicht authored
      The case "p1 belongs to region R2 OR the boundary of R2" was missing.
      Algorithm would fail if three points lie on the same line.
      caa51b1a
    • Mathieu Westphal's avatar
  6. 25 Jul, 2018 4 commits