1. 04 Aug, 2018 1 commit
    • Sean McBride's avatar
      Fixed more cppcheck 1.84 warnings · c868a18d
      Sean McBride authored
      This fixed issues were:
      
      clarifyCondition,Common/Core/vtkLargeInteger.cxx:355
      identicalInnerCondition,Filters/Texture/vtkTextureMapToPlane.cxx:103,warning,Identical inner 'if' condition is always true.
      nullPointerArithmeticRedundantCheck,Rendering/GL2PSOpenGL2/vtkOpenGLGL2PSHelperImpl.cxx:173,warning,Either the condition '!data' is redundant or there is pointer arithmetic with NULL pointer.
      identicalInnerCondition,Filters/FlowPaths/vtkModifiedBSPTree.cxx:1069,warning,Identical inner 'if' condition is always true.
      identicalInnerCondition,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.cxx:199,warning,Identical inner 'if' condition is always true.
      nullPointerArithmeticRedundantCheck,Infovis/BoostGraphAlgorithms/vtkBoostGraphAdapter.h:222,warning,Either the condition 'iter!=0' is redundant or there is pointer arithmetic with NULL pointer.
      
      The vtkTestingRenderingDriver.cmake changed cause many many warnings in files generated from it.
      c868a18d
  2. 10 Jul, 2018 1 commit
  3. 18 May, 2018 1 commit
    • Kitware Robot's avatar
      ExternalData: Convert content links from MD5 to SHA512 · d6d05b2a
      Kitware Robot authored
      Populate a script with `map_<md5>=<sha512>` variable settings and
      then run the following to convert the content link files:
      
          git ls-files -- '*.md5' | while read f; do
            md5="$(cat "$f")"
            sha512="$(eval echo \${map_$md5})"
            rm "$f"
            echo $sha512 > ${f%.md5}.sha512
          done
      d6d05b2a
  4. 12 Apr, 2018 1 commit
  5. 20 Mar, 2018 1 commit
  6. 03 Jan, 2018 1 commit
  7. 19 Dec, 2017 1 commit
  8. 05 Dec, 2017 2 commits
  9. 01 Dec, 2017 1 commit
  10. 04 Oct, 2017 1 commit
  11. 02 Oct, 2017 1 commit
  12. 26 Jul, 2017 1 commit
    • Kitware Robot's avatar
      Replace many NULL and 0 occurances with nullptr · a855cab0
      Kitware Robot authored
      This topic is the result of running clang-tidy to
      modernize our usage of NULL and 0 to nullptr. It also
      includes some manual and semi manual changes where
      clang-tidy would not be expected to work (such as in
      comments, or classes not compiled on this build)
      
      There are definitely many comments and occurances that
      this topic misses that we will need to fix over time.
      a855cab0
  13. 30 May, 2017 1 commit
  14. 27 Apr, 2017 1 commit
  15. 17 Apr, 2017 1 commit
  16. 22 Jan, 2017 1 commit
    • Sean McBride's avatar
      const improvements to APIs and internal usage · 8b32854b
      Sean McBride authored
      - Made a few APIs' params const
      - Changed many usages of the evil GetBounds() to expect a const
        return value, even though it does not (yet?) return const
      - Slightly changed return values of vtkTextActor3D::GetBounds()
        to return its own ivar instead of its ImageActor's
      8b32854b
  17. 16 Jan, 2017 1 commit
  18. 23 Sep, 2016 2 commits
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      Utilities/Maintenance/vtk-reindent-code.py
      
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      
      The bash command line used was the following:
      
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
        done
      done
      f830ff47
    • David E. DeMarle's avatar
      replace VTK's nonstandard Doxygen with standard markup · 6a7e5148
      David E. DeMarle authored
      generated via:
      cd $VTKSRC
      perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
      cp -r ~/tmp/vtkheaders/* .
      6a7e5148
  19. 12 Sep, 2016 1 commit
    • Haocheng LIU's avatar
      Rewrite all public&private dependency in module.cmake file · 6e113ad4
      Haocheng LIU authored
      The current dependency relationship in vtk is unclear and misleading.
      This MR tries to rewrite them based on header files inclusion of headers
      and source files in each module. Corner cases are considered and
      modules are sorted in alphabetical order to facilitate future reference.
      See details in my gitlab python based script project. In future we can continue
      using this script to clean the VTK Dependency easily from
      time to time.
      6e113ad4
  20. 07 Jul, 2016 2 commits
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION to many constructors · 1853e030
      Sean McBride authored
      vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;
      
      vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;
      1853e030
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION for operator= · 2d0e11ef
      Sean McBride authored
      (operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
      to
      \1 VTK_DELETE_FUNCTION;
      
      After that, this finds basically nothing:
      
      operator.*implemented
      
      then manually reverted changed files in VPIC and KWSys folders.
      2d0e11ef
  21. 25 May, 2016 1 commit
    • Kitware Robot's avatar
      Remove all BTX and ETX markers from VTK headers · 4d127b1d
      Kitware Robot authored
      Perl was used to remove all the BTX and ETX markers from the code.
      The specific command that was run on all "vtk*.h" files was this:
          perl -0777 -i -pe 's/(\n* *\/\/ *[BE]TX *\n+)+/\n\n/g'
      
      This regex replaces each BTX/ETX line, plus any leading or trailing
      blank lines, with a single blank line.
      4d127b1d
  22. 08 Mar, 2016 1 commit
  23. 28 Jan, 2016 1 commit
  24. 27 Oct, 2015 1 commit
  25. 05 Mar, 2015 1 commit
    • Ken Martin's avatar
      A number of transparency related issues fixed · 944ee020
      Ken Martin authored
      A few good fixes in here that are all related. The biggest is a
      fix to OpenGLActor to use the more comprehensive GetIsOpaque
      method in determining if an actor is opaque. The old code only
      looked at the property's opacity. This is why you would see folks
      setting somethings opacity to 0.99 to get it treated as translucent
      because the actor code wasn't handling it correctly. This change
      resulted in 3 new valid images for tests that were rendering
      translucent items as if they were opaque. I removed these tests
      from the old backend as I did not want to change the behavior
      for that backend.
      
      Next up is depth peeling. OpenGL2 depth peeling would render
      a number of peels up to the limit and then just stop. Any geometry
      left between the opaque layer and the last translucent layer was
      just thrown out.  This created very noticable artifacts and was bad.
      This change makes it so that when it gets to the last pass, it will
      render all remaining geometry using alpha blending. This is much
      better. Fix example if you get the limit to 20 layers and 20 was
      not enough to render all the geometry, this change renders 19
      layers using depth peeling, then in the 20th render it would add
      in all the remaining geometry as last layer. That last layer may
      have overlapping geometry which is rendered using alpha blending.
      
      Finally some changes to the PointGaussianMapper. It turns out that
      the point gaussian mapper is an translucent mapper which means it
      needs the first change, and it is a very tough case for depth peeling
      resulting in the second change. While at it I modified this mapper
      to render far fewer fragments, resulting is far fewer overlapping
      layers and fewer artifacts. Really when using PointGaussian you
      should turn off depthpeeling as it is not needed and actually makes
      it worse, but these changes will make it better if you happen to have
      it on.  Also cleaned up the mapper so that the radius is equal to
      the standard devisation of the gaussian, previously it was four
      standard deviations.
      
      Change-Id: I62d90b6e424ac0e939033387ed10ba8caac66095
      944ee020
  26. 18 Dec, 2014 1 commit
  27. 10 Sep, 2014 1 commit
  28. 03 Jul, 2014 1 commit
    • Ben Boeckel's avatar
      modules: add modules to "kits" · e5203447
      Ben Boeckel authored
      The main kits are:
      
          vtkCommon
          vtkFilters
          vtkIO
          vtkImaging
          vtkInteraction
          vtkOpenGL (required due to a dependency cycle from
                     vtkRenderingOpenGL on vtkImagingHybrid)
          vtkParallel
          vtkRendering
          vtkViews
          vtkWrapping
      
      Modules which deal with a specialization of another module belong to the
      kit related to the specialization (i.e., FiltersParallel and
      IOParallelXML both belong to the vtkParallel kit) to avoid circular
      dependencies that arise when put into the same kit as the "lesser"
      module.
      
      Change-Id: Icae0baa78d62cc0dcce84546541df600d4f311dd
      e5203447
  29. 16 Apr, 2014 2 commits
  30. 12 Nov, 2013 1 commit
  31. 04 Jun, 2013 1 commit
    • Brad King's avatar
      Convert VTKData test inputs to ExternalData content links · 3797f83d
      Brad King authored
      Add to the Testing/Data directory ExternalData content links mirroring
      the content and layout we use from the VTKData/Data directory.
      
      Add a CMake/vtkLegacyData.cmake module, included from CMakeLists.txt and
      Testing/External/CMakeLists.txt, to call ExternalData_Expand_Arguments
      for all data directories added from VTKData/Data.  This will bulk-fetch
      all test input data currently used by tests of any module, enabled or
      not.  We can make the DATA{} references more granular later.
      
      Add a VTK_TEST_DATA_DIR variable to refer to the directory we tell the
      ExternalData module to populate the real data files.  Replace references
      to VTK_DATA_ROOT in test command lines (after -D) with references to
      VTK_TEST_DATA_DIR.  Drop the VTK_DATA_ROOT CMake option and stop using
      the VTKData repository.
      
      Remove the TESTING_DATA option from the vtk_add_test_cxx API and remove
      the VTK_DATA_ROOT option from the vtk_add_test_mpi API since all test
      input data are now handled through ExternalData and Testing/Data content
      links.
      
      Change-Id: Id02490b76ea2e161b9038188264a4830485039d8
      3797f83d
  32. 31 May, 2013 1 commit
  33. 17 May, 2013 2 commits
  34. 14 May, 2013 1 commit
  35. 28 Apr, 2013 1 commit
    • Andrew Maclean's avatar
      These Python tests have been refactored. · 3810c5a6
      Andrew Maclean authored
      This has been done by removing the "tcl-isms" and making
       the code more readable. In some cases redundant code
       has been removed (often a result of copy/paste operations).
       The code has also been checked to ensure each line is 80
       characters or less.
      
      The code can now be run using vtkpython or by using the
       appropriate Python environment.
      
      Originally these were TCL scripts that were converted using
        vtkTclTestToPy.py and they they needed to be run through the
        rtImageTest.py driver which defines a few needed
        functions/variables for their operation. To this end
        backdrop.py has been added where it is needed.
      
      Change-Id: I50d6505628c140ea4551f74f7f3e85df907567e1
      Signed-off-by: Andrew Maclean's avatarAndrew Maclean <andrew.amaclean@gmail.com>
      3810c5a6