1. 06 Oct, 2018 1 commit
  2. 04 Oct, 2018 2 commits
  3. 03 Oct, 2018 2 commits
  4. 28 Sep, 2018 1 commit
  5. 24 Sep, 2018 1 commit
  6. 19 Sep, 2018 1 commit
  7. 18 Sep, 2018 1 commit
  8. 17 Sep, 2018 1 commit
  9. 14 Sep, 2018 2 commits
    • Sean McBride's avatar
      Manually reviewed use of 'static int' occurrences · e7d7f32c
      Sean McBride authored
      - Changed some to be const also.
      - Replaced others with call to ClampValue method.
      - Changed some from int to bool.
      - In a couple of cases the variable was unused, removed it.
      e7d7f32c
    • Sean McBride's avatar
      Replaced some uses of vtkMath::Round with STL rounding · 56bf715c
      Sean McBride authored
      vtkMath::Round converts double to int, as opposed to long.  Both can be lossy, but the former much more so.
      
      Replaced some uses with std::round(), some with std::lround().
      
      Eliminated the long->int truncation as much as possible, but kept it in many instances.
      56bf715c
  10. 11 Sep, 2018 2 commits
  11. 10 Sep, 2018 1 commit
  12. 07 Sep, 2018 1 commit
  13. 05 Sep, 2018 1 commit
    • Ken Martin's avatar
      fix issue with input data changing · afe0f461
      Ken Martin authored
      if the input data changes to an input data
      with a lower mtime the VBO/IBO was not rebuilding.
      So we switch to useing a state object to keep track
      of mtime value and rebuild if the values change regardless
      or higher or lower.
      
      In debug builds store what was different when
      a difference is detected.
      afe0f461
  14. 04 Sep, 2018 1 commit
    • Ken Martin's avatar
      fix issue with multiple contexts · 15c9ca85
      Ken Martin authored
      With multiple contexts it is possible for release
      graphics resources to be called when another context is
      current. This topic fixes this issue.
      15c9ca85
  15. 31 Aug, 2018 1 commit
    • Ken Martin's avatar
      Add order independent translucent pass · b36e2563
      Ken Martin authored
      Same speed but much better end result than the old
      transparency code.
      
      Also fix a few classes that were not passing properties
      to their sub props.
      
      Fix medical example to make opaque objects opaque.
      b36e2563
  16. 24 Aug, 2018 1 commit
  17. 10 Aug, 2018 1 commit
    • Ken Martin's avatar
      Fix a reported crash in SupportsOpenGL · 39e50b10
      Ken Martin authored
      SupportsOpenGL should never crash but a user provided
      a stack trace showing it crash because it was not
      checking that OpenGL initialized properly before
      making opengl calls in one path. This hopefulyl fixes
      that.
      39e50b10
  18. 09 Aug, 2018 1 commit
  19. 08 Aug, 2018 1 commit
  20. 07 Aug, 2018 2 commits
  21. 04 Aug, 2018 1 commit
    • Sean McBride's avatar
      Fixed more cppcheck 1.84 warnings · c868a18d
      Sean McBride authored
      This fixed issues were:
      
      clarifyCondition,Common/Core/vtkLargeInteger.cxx:355
      identicalInnerCondition,Filters/Texture/vtkTextureMapToPlane.cxx:103,warning,Identical inner 'if' condition is always true.
      nullPointerArithmeticRedundantCheck,Rendering/GL2PSOpenGL2/vtkOpenGLGL2PSHelperImpl.cxx:173,warning,Either the condition '!data' is redundant or there is pointer arithmetic with NULL pointer.
      identicalInnerCondition,Filters/FlowPaths/vtkModifiedBSPTree.cxx:1069,warning,Identical inner 'if' condition is always true.
      identicalInnerCondition,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.cxx:199,warning,Identical inner 'if' condition is always true.
      nullPointerArithmeticRedundantCheck,Infovis/BoostGraphAlgorithms/vtkBoostGraphAdapter.h:222,warning,Either the condition 'iter!=0' is redundant or there is pointer arithmetic with NULL pointer.
      
      The vtkTestingRenderingDriver.cmake changed cause many many warnings in files generated from it.
      c868a18d
  22. 01 Aug, 2018 1 commit
    • luz.paz's avatar
      Misc. typos · 0c5f8b4b
      luz.paz authored
      Found via `codespell -q 3 -I ../vtk-whitelist-words.txt --skip="./ThirdParty,./Utilities"`
      0c5f8b4b
  23. 30 Jul, 2018 1 commit
  24. 26 Jul, 2018 1 commit
    • Sean McBride's avatar
      Added missing overrides found by cppcheck 1.84 · c0d6d943
      Sean McBride authored
      missingOverride,Examples/GUI/Win32/SampleMFC/SampleDoc.h:47
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:49
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:50
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:52
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:54
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:61
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:62
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:69
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:70
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:60
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:61
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:62
      missingOverride,IO/ADIOS/FunctionPointers.h:114
      missingOverride,IO/Video/vtkMILVideoSource.h:104
      missingOverride,IO/Video/vtkMILVideoSource.h:243
      missingOverride,IO/Video/vtkMILVideoSource.h:249
      missingOverride,IO/Video/vtkMILVideoSource.h:259
      missingOverride,IO/Video/vtkMILVideoSource.h:79
      missingOverride,IO/Video/vtkMILVideoSource.h:84
      missingOverride,IO/Video/vtkMILVideoSource.h:89
      missingOverride,IO/Video/vtkMILVideoSource.h:94
      missingOverride,IO/Video/vtkMILVideoSource.h:99
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:206
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:219
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:220
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:68
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:238
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:239
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:66
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:37
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:43
      missingOverride,Rendering/OptiX/vtkOptiXCompositePolyDataMapper2Node.h:45,style,The function 'Render' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,Utilities/Benchmarks/GLBenchmarking.cxx:74
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:162
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:164
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:166
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:270
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:273
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:276
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:409
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:414
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:419
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:532
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:534
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:536
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:58
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:60
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:62
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:658
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:660
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:662
      missingOverride,IO/ADIOS/ADIOSWriter.cxx:159,style,The function 'GetInt' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:31,style,The function 'ExecVoid' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:50,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:69,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:90,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      c0d6d943
  25. 23 Jul, 2018 1 commit
  26. 18 Jul, 2018 1 commit
  27. 17 Jul, 2018 1 commit
  28. 16 Jul, 2018 1 commit
  29. 14 Jul, 2018 1 commit
    • Ken Martin's avatar
      use hardwareselector to perform picking · 1eb083a8
      Ken Martin authored
      We used to have two implementations for picking. The
      hardware selector and the PickProp code. This topic implements
      PickProp by using the selector. That way we have fewer paths
      of code to maintain.
      1eb083a8
  30. 12 Jul, 2018 2 commits
  31. 11 Jul, 2018 1 commit
  32. 10 Jul, 2018 3 commits
    • Michael Migliore's avatar
      Fix Glyph3D Mapper LOD culling · 5edfe69f
      Michael Migliore authored
      5edfe69f
    • Ken Martin's avatar
      fix a bug in polydatamapper2D when scalarvisibility changes · 1c88d84d
      Ken Martin authored
      Once on, turning off did not work as the Colors array
      was never cleared.
      1c88d84d
    • Ken Martin's avatar
      improve picking performance and memory footprint · 82fffd9c
      Ken Martin authored
      Significant rework of the hardware picking code.
      
      Previously each mapper had to make sure that the rendered
      colors were correct for point/cell etc ID during hardware picking
      and this required large datastructures and texture uploads
      to the GPU on each pick.
      
      Now it collects the color buffers and gives the mappers a chance to
      update them. This allows us to use gl_VertexId and gl_PrimitiveId
      directly in the shader and then if picked, allow the mapper to
      adjust the color buffer as needed. This allows us to avoid
      rebuilding the VBO and textures each time and avoids the memory
      footprint related to that.
      82fffd9c