1. 20 Mar, 2018 1 commit
    • Sean McBride's avatar
      Applied clang-tidy modernize-use-equals-default fixes · 84ec1d57
      Sean McBride authored
      This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.
      
      There are now some duplicate semis because it did changes like:
      
        ~AMRIndexIterator() override{};
      to
        ~AMRIndexIterator() override= default;;
      
      Note there was a pointless semi before, which clang-tidy didn’t expect / account for.
      
      My next commit will remove them.
      84ec1d57
  2. 26 Jul, 2017 1 commit
    • Kitware Robot's avatar
      Replace many NULL and 0 occurances with nullptr · a855cab0
      Kitware Robot authored
      This topic is the result of running clang-tidy to
      modernize our usage of NULL and 0 to nullptr. It also
      includes some manual and semi manual changes where
      clang-tidy would not be expected to work (such as in
      comments, or classes not compiled on this build)
      
      There are definitely many comments and occurances that
      this topic misses that we will need to fix over time.
      a855cab0
  3. 14 Dec, 2016 1 commit
  4. 23 Sep, 2016 1 commit
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      Utilities/Maintenance/vtk-reindent-code.py
      
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      
      The bash command line used was the following:
      
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
        done
      done
      f830ff47
  5. 06 May, 2016 1 commit
    • David C. Lonie's avatar
      Replace SafeDownCast calls on arrays with vtkArrayDownCast. · 0d71a308
      David C. Lonie authored
      SafeDownCast performs a series of virtual calls and string comparisons,
      which is quite slow, especially when used in worker functions.
      
      vtkArrayDownCast will switch between SafeDownCast and the more
      efficient FastDownCast (only available for common vtkAbstractArray
      subclasses) depending on whether or not FastDownCast is defined for
      the specific array type.
      0d71a308
  6. 08 Mar, 2016 1 commit
  7. 29 Jan, 2016 1 commit
    • Berk Geveci's avatar
      Refactored and update the way algorithms are updated. · f020ebb6
      Berk Geveci authored
      The way algorithms were updated (made to execute) with
      request meta-data (such as update extent) was very error
      prone and counter-intuitive. Added new methods to make
      updating with meta-data easier. I also deprecated a number
      of methods to set request meta-data. This will encourage
      developers to migrate to the new API which is less error-
      prone.
      f020ebb6
  8. 29 Aug, 2014 1 commit
  9. 21 May, 2014 4 commits
    • Berk Geveci's avatar
      Moved key. · ac6f1854
      Berk Geveci authored
      It made more sense to have both CAN_PRODUCE_SUB_EXTENT and
      CAN_HANDLE_PIECE_REQUEST in vtkAlgorithm.
      
      Change-Id: Ie64bb3e7c8417113bfb7f677c10d8feb5fdddc39
      ac6f1854
    • Berk Geveci's avatar
      Updated filters and sources to work with new pipeline logic. · 747b780a
      Berk Geveci authored
      Change-Id: Id76d3bc545a64675a0820cb1d9b45c61a51efc6a
      747b780a
    • Berk Geveci's avatar
      Update the XML readers and writers to work with pipeline changes. · 32cf800f
      Berk Geveci authored
      The XML readers and writers, both parallel and serial, now work
      with the pipeline changes. Now, all writers work with pieces
      even though the structured ones can handle asking for a sub-
      extent.
      
      Change-Id: I9f757ba12a3b9fb84e141506dacadad608eb8b99
      32cf800f
    • Berk Geveci's avatar
      Refactored how pieces and extents are handled. · 1a0b4e9d
      Berk Geveci authored
      Refactoring the way VTK goes between piece and structured
      extents. Before, extent translators were used when the pipeline
      moved from structured to unstructured data converting piece
      request to extent request. This caused many problems with filters
      that altered extents, mainly a lot of redundant IO due to
      repartitioning of different extents. This became extremely
      cumbersome to manage when running distributed. The new behavior
      pushes the extent translation all to way to the readers and
      only when readers are able to read a subset. This works much
      better. The only downside is that filters need to be able to
      handle data extents different than update extents. Most filters
      can do this but many imaging filters cannot. Those that are
      needed in parallel will have to be updated.
      
      As part of this work, I also removed MAXIMUM_NUMBER_OF_PIECES
      and added CAN_HANDLE_PIECE_REQUEST. MAXIMUM_NUMBER_OF_PIECES had
      reduced to being a boolean. 1 for serial sources, -1 for parallel
      sources. I removed it and added a CAN_HANDLE_PIECE_REQUEST instead.
      This key, produced by a source, tells the executive that a source is
      able to handle piece request. It is a source only key produced in
      RequestInformation and is not propagated downstream. If this key is
      not present, the executive will only execute the source for piece 0
      to produce the entire data. It is then up to the user to add a filter
      that splits the data for other piece requests. The only exception to
      this is when CAN_PRODUCE_SUB_EXTENT is present, in which case the
      executive will split using an extent translator AT THE source - not
      downstream.
      
      Conflicts:
      	Filters/FlowPaths/vtkParticleTracerBase.cxx
      
      Change-Id: I8db4040289ff87331adeecded4a738313d9b52df
      1a0b4e9d
  10. 09 Apr, 2012 2 commits
    • VTK Developers's avatar
      Remove trailing whitespace from all source files · 2d323fc4
      VTK Developers authored
      Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
      are maintained outside VTK.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      2d323fc4
    • VTK Developers's avatar
      Modularize VTK tree layout · cdd4d6fd
      VTK Developers authored
      Move source files from their former monolithic VTK location to their new
      location in modular VTK without modification.  This preserves enough
      information for "git blame -M" and "git log --follow" to connect
      modularized VTK files to their original location and history.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
      cdd4d6fd
  11. 19 Sep, 2011 1 commit
  12. 20 May, 2010 1 commit
    • Mark Olesen's avatar
      Remove vtk(Cxx|Type)RevisionMacro · ecbbf7f7
      Mark Olesen authored
      The CVS $Revision$ keyword replacement will no longer maintain these
      macros automatically.  They were used only to implement CollectRevisions
      and vtkObjectBase::PrintRevisions, an API that was never used.
      
      Automated as follows:
      
        pass 0:
        catch templates
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'
      
        pass 1:
        main changes
        ---------------
        $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
          echo "$file" 1>&2
          perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
        done
        $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
          echo "$file" 1>&2
          perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
        done
      
        pass 2:
        verify
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'
      
      Fixed multi-line vtkCxxRevisionMacro and templates by hand.
      ecbbf7f7
  13. 23 Apr, 2010 1 commit
    • Mark Olesen's avatar
      Remove vtk(Cxx|Type)RevisionMacro · 19c55e0e
      Mark Olesen authored
      The CVS $Revision$ keyword replacement will no longer maintain these
      macros automatically.  They were used only to implement CollectRevisions
      and vtkObjectBase::PrintRevisions, an API that was never used.
      
      Automated as follows:
      
        pass 0:
        catch templates
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'
      
        pass 1:
        main changes
        ---------------
        $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
          echo "$file" 1>&2
          perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
        done
        $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
          echo "$file" 1>&2
          perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
        done
      
        pass 2:
        verify
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'
      
      Fixed multi-line vtkCxxRevisionMacro and templates by hand.
      19c55e0e
  14. 20 Jun, 2008 2 commits
  15. 10 Jun, 2008 1 commit
  16. 05 Jan, 2006 1 commit
    • Utkarsh Ayachit's avatar
      ENH: · fad86463
      Utkarsh Ayachit authored
      * vtkDataArray now has a new superclass-vtkAbstractArray.vtkAbstractArray
      provides type-agnostic API to access array elements. vtkDataArray provides
      a double API to access values -- such an API is deliberately missing from
      vtkAbstractArray, since arrays like string arrays are not castable to doubles.
      
      * vtkAbstractArray has the notion of components/tuples, but does not make
      any assumptions about the arragment of these. It's up to the concrete
      subclasses how the data is represented in memory.
      
      * vtkFieldData used to provide tuple API to get/set values from data arrays
      contained in it. However, now that FieldData can have arrays that are not
      vtkDataArrays, this API is not longer valid.
      The following are the methods that are no longer available:
      double* GetTuple(const vtkIdType);
      void SetTuple(const vtkIdType i, const double* tuple);
      void GetTuple(const vtkIdType i, double* tuple);
      void InsertTuple(const vtkIdType i, const double* tuple);
      void InsertNextTuple(cons double*);
      double GetComponent(const vtkIdType i, const int j);
      void SetComponent(const vtkIdType i, const int j, const double c);
      void InsertComponent(const vtkIdType i, const int j, const double c);
      However, new API is provided to copy tuples arround from one field data to
      another using:
      void SetTuple(const vtkIdType i, const vtkIdType j, vtkFieldData* source);
      void InsertTuple(const vtkIdType i, const vtkIdType j, vtkFieldData* source);
      vtkIdType InsertNextTuple(const vtkIdType j, vtkFieldData* source);
      
      * vtkFieldData provide a vtkDataArray* GetArray(int index) to retrieve arrays
      in the field data. This function can will now return a NULL if the array
      at the given index is not a data array. It provides
      vtkAbstractArray* GetAbstractArray(int index);
      to retrieve an array even if it isn't a vtkDataArray.
      
      * Since vtkFieldData can contain arrays that aren't subclasses of
      vtkDataArray, so can vtkDataSetAttributes. However, an attribute can only be
      a vtkDataArray subclass i.e. one cannot set a vtkStringArray as the SCALARS
      array for a Point Data, for example.
      
      * String Array IO is only supported in XML file formats. If deemed important,
      support may be added for lecacy file formats.
      
      *** Array Iterators ***
      Another addition to the VTK Arrays, is the notion of Array Iterator. A
      vtkArrayIterator subclass is be provided for every vtkAbstractArray
      subclass. The iterator is a random access iterator. The iterators are not
      available in any of the wrapped languages, however, in C++ they can be used to
      write templatized code to processes the array values without any implicit type
      conversion and consequent loss of precision. vtkArrayIteratorTemplateMacro is
      provided to simply switching between different types of the arrays. Examples of
      use of this macro and the iterators can be found in
      vtkXMLWriter.cxx / vtkXMLDataReader.cxx / vtkXMLStructuredDataReader.cxx.
      fad86463
  17. 28 Jul, 2005 1 commit
  18. 01 Jul, 2005 1 commit
  19. 26 May, 2005 1 commit
  20. 29 Mar, 2005 1 commit
  21. 24 Mar, 2005 1 commit
  22. 17 Feb, 2005 1 commit
  23. 11 Feb, 2005 1 commit
  24. 14 Nov, 2003 1 commit
  25. 23 May, 2003 1 commit
  26. 21 May, 2003 1 commit
  27. 12 May, 2003 1 commit
  28. 08 May, 2003 1 commit
  29. 05 May, 2003 2 commits
  30. 31 Dec, 2002 1 commit
  31. 26 Nov, 2002 1 commit
  32. 22 Nov, 2002 1 commit
  33. 23 Oct, 2002 1 commit
  34. 16 Oct, 2002 1 commit