1. 10 Nov, 2016 1 commit
    • Ken Martin's avatar
      Remove the old FBO compatability Code · 57bd525c
      Ken Martin authored
      The prior commit contains the merging of the FBO and
      FBO2 functionality. This commit removes a fair amount of
      the old FBO functionality to keep the API clean and encourage
      people to use FOs in a consistent manner.
      57bd525c
  2. 09 Nov, 2016 1 commit
    • Ken Martin's avatar
      combine fbo and fbo2 into one class and clean it up · 39010fa7
      Ken Martin authored
      having two VBO classes was confusing. This topic
      moves the functionality of FBO2 into FBO while
      keeping some of the original FBO functionality and
      cleaning it up a bit.
      
      All OpenGL2 code in VTK using FBOs is updated in
      this topic to use the merged FBO class. Mainly this
      impacts classes that were using the FBO class.
      
      The old FBO methods and code are converted but
      commented out in this commit.
      39010fa7
  3. 07 Nov, 2016 1 commit
  4. 04 Nov, 2016 1 commit
    • Ken Martin's avatar
      add opengl resource management to polydatamapper2d · a9fa6d3b
      Ken Martin authored
      In some cases it could attempt to free opengl resources
      when it was not the current context or after the context
      was destroyed. Add the new resource management logic
      via vtkOpenGLResourceFreeCallback the class to prevent
      this.
      a9fa6d3b
  5. 03 Nov, 2016 3 commits
    • Ken Martin's avatar
      fix a compiler error on es3 · 08c27636
      Ken Martin authored
      GL_MULTISAMPLE is not defined for ES3
      08c27636
    • Eloi Gaudry's avatar
      missing check · 46187e3c
      Eloi Gaudry authored
      46187e3c
    • Eloi Gaudry's avatar
      Segfault in create awindow · 90f09635
      Eloi Gaudry authored
      there are some paths in the vtkXOpenGLRenderWindow (CreateAWindow for instance) that would need better NULL pointer check to avoid SEGFAULT and allow a clean abort.
      this fix should also be merged to the release branch
      90f09635
  6. 02 Nov, 2016 1 commit
  7. 01 Nov, 2016 1 commit
    • Ken Martin's avatar
      Remove ES2 support for VTK 8.0 · 0f750114
      Ken Martin authored
      ES2 is causing headaches and code mess and is
      getting old. Remove for 8.0 so we can focus on
      more modern APIs. Most Apple and Adroid devices
      from the past 4 years support ES3.
      0f750114
  8. 31 Oct, 2016 1 commit
  9. 29 Oct, 2016 2 commits
    • Ken Martin's avatar
      try fix for offscreen rendering on Windows · 275da290
      Ken Martin authored
      The context was getting cleaned too often maybe.
      This fix reverts one line from commit
      https://gitlab.kitware.com/vtk/vtk/commit/
      3a8e4497
      
      This commit fixes issue
      
      vtk/vtk#16876
      
      and adds a test for that condition as well as
      a few other cases that should work but could
      cause problems.
      
      This change could introduce other issues limited
      to windows as the code is fairly complex and
      the use cases vary widely. At some point the whole
      process of creating windows and handling offscreen
      drawing needs to be reworked. It is a mishmash of 20
      years of code and overdue for a real workover for all
      platforms. But this topic is intended to fix this one
      case until we have time to really look at it and rework
      it.
      
      Currently the new test is only active for OpenGL2 and
      Windows. OpenGL1 and other platforms has issues with
      it that need to be fixed in the future. But for now this
      change fixes the reported Windows issues and adds a
      test to maintain that fix.
      275da290
    • Ken Martin's avatar
      better handling of how to get an OpenGL context win32 · c3e87b66
      Ken Martin authored
      Fix some long standing issues with multisamples
      and stereo capable window requests on Win32.
      c3e87b66
  10. 28 Oct, 2016 1 commit
  11. 25 Oct, 2016 2 commits
  12. 24 Oct, 2016 1 commit
    • Ken Martin's avatar
      try fix for offscreen rendering on Windows · 52d32544
      Ken Martin authored
      The context was getting cleaned too often maybe.
      This fix reverts one line from commit
      https://gitlab.kitware.com/vtk/vtk/commit/
      3a8e4497
      
      This commit fixes issue
      
      vtk/vtk#16876
      
      and adds a test for that condition as well as
      a few other cases that should work but could
      cause problems.
      
      This change could introduce other issues limited
      to windows as the code is fairly complex and
      the use cases vary widely. At some point the whole
      process of creating windows and handling offscreen
      drawing needs to be reworked. It is a mishmash of 20
      years of code and overdue for a real workover for all
      platforms. But this topic is intended to fix this one
      case until we have time to really look at it and rework
      it.
      
      Currently the new test is only active for OpenGL2 and
      Windows. OpenGL1 and other platforms has issues with
      it that need to be fixed in the future. But for now this
      change fixes the reported Windows issues and adds a
      test to maintain that fix.
      52d32544
  13. 22 Oct, 2016 2 commits
  14. 21 Oct, 2016 1 commit
  15. 20 Oct, 2016 1 commit
  16. 17 Oct, 2016 3 commits
    • David C. Lonie's avatar
      Prevent crash in HiddenLineRemovalPass. · 21e91b6c
      David C. Lonie authored
      Fix a bug where a NULL pointer may be dereferenced.
      21e91b6c
    • Ken Martin's avatar
      fix ios getpixeldata calls · cb60ff5e
      Ken Martin authored
      ios has issues with GL_RGB and GL_BACK_LEFT
      cb60ff5e
    • David C. Lonie's avatar
      Call glFlush() after initializing a new context. · 07c2a9bf
      David C. Lonie authored
      There were some odd behaviors on ParaView when using pvserver with
      --use-offscreen-rendering (see #16943). The initial render on a new
      context would result in an empty scene. This behavior started when
      calls to glFlush() in vtkRenderWindow::Frame() were removed for
      performance reasons.
      
      This patch fixes the rendering issue, and since it only happens
      for new contexts, won't hurt performance.
      07c2a9bf
  17. 11 Oct, 2016 5 commits
    • David C. Lonie's avatar
      Prevent crash in HiddenLineRemovalPass. · 511c6a44
      David C. Lonie authored
      Fix a bug where a NULL pointer may be dereferenced.
      511c6a44
    • Ken Martin's avatar
      fix ios getpixeldata calls · 4cf18951
      Ken Martin authored
      ios has issues with GL_RGB and GL_BACK_LEFT
      4cf18951
    • David C. Lonie's avatar
      Call glFlush() after initializing a new context. · 7c9ac01f
      David C. Lonie authored
      There were some odd behaviors on ParaView when using pvserver with
      --use-offscreen-rendering (see #16943). The initial render on a new
      context would result in an empty scene. This behavior started when
      calls to glFlush() in vtkRenderWindow::Frame() were removed for
      performance reasons.
      
      This patch fixes the rendering issue, and since it only happens
      for new contexts, won't hurt performance.
      7c9ac01f
    • Brad King's avatar
      Android: Port build system to CMake 3.7 capabilities · 9c744b13
      Brad King authored
      CMake 3.7 adds support for cross-compiling to Android without a complex
      toolchain file.  Port our main CMake build system to work without the
      `android.toolchain.cmake` file:
      
      ```
      $ cmake ../VTK \
          -DCMAKE_SYSTEM_NAME=Android \
          -DCMAKE_ANDROID_NDK=/path/to/ndk \
          -DVTKCompileTools_DIR=/path/to/vtk-compile-tools \
          -DOPENGL_ES_VERSION=3.0 \
          -DVTK_Group_StandAlone=OFF
      ```
      9c744b13
    • Ken Martin's avatar
      if msaa cannot find a working context disable it win32 · 99607039
      Ken Martin authored
      The old code would reduce the number of samples
      requested but never disable it. This topic makes it
      so that after reducing the number, if will if needed
      try disabling MSAA altogether.
      99607039
  18. 10 Oct, 2016 1 commit
    • Ken Martin's avatar
      ifdef out valuepass code on ES2 · 048f89ab
      Ken Martin authored
      ValuePass was having issues with OpenGL ES2 so
      this topic ifdefs the code on that platform.  The result
      is fairly messy so it really needs another pass at
      some point to do it right. This is a quick fix as
      we are heading to a release.
      048f89ab
  19. 07 Oct, 2016 2 commits
  20. 06 Oct, 2016 2 commits
  21. 05 Oct, 2016 2 commits
  22. 04 Oct, 2016 2 commits
  23. 03 Oct, 2016 1 commit
  24. 29 Sep, 2016 1 commit
  25. 28 Sep, 2016 1 commit