1. 26 Jul, 2018 1 commit
    • Sean McBride's avatar
      Added missing overrides found by cppcheck 1.84 · c0d6d943
      Sean McBride authored
      missingOverride,Examples/GUI/Win32/SampleMFC/SampleDoc.h:47
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:49
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:50
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:52
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:54
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:61
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:62
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:69
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:70
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:60
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:61
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:62
      missingOverride,IO/ADIOS/FunctionPointers.h:114
      missingOverride,IO/Video/vtkMILVideoSource.h:104
      missingOverride,IO/Video/vtkMILVideoSource.h:243
      missingOverride,IO/Video/vtkMILVideoSource.h:249
      missingOverride,IO/Video/vtkMILVideoSource.h:259
      missingOverride,IO/Video/vtkMILVideoSource.h:79
      missingOverride,IO/Video/vtkMILVideoSource.h:84
      missingOverride,IO/Video/vtkMILVideoSource.h:89
      missingOverride,IO/Video/vtkMILVideoSource.h:94
      missingOverride,IO/Video/vtkMILVideoSource.h:99
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:206
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:219
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:220
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:68
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:238
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:239
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:66
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:37
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:43
      missingOverride,Rendering/OptiX/vtkOptiXCompositePolyDataMapper2Node.h:45,style,The function 'Render' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,Utilities/Benchmarks/GLBenchmarking.cxx:74
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:162
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:164
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:166
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:270
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:273
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:276
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:409
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:414
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:419
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:532
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:534
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:536
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:58
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:60
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:62
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:658
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:660
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:662
      missingOverride,IO/ADIOS/ADIOSWriter.cxx:159,style,The function 'GetInt' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:31,style,The function 'ExecVoid' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:50,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:69,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:90,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      c0d6d943
  2. 19 Jun, 2018 1 commit
    • Brad King's avatar
      cmake: declare support for CMake versions through 3.12 · c36289f1
      Brad King authored
      CMake 3.12 introduces a `...<max>` syntax in the version given to
      `cmake_minimum_required` to automatically set policies to NEW up
      to that version.  Use it to avoid listing policies explicitly.
      
      The syntax is compatible with older versions of CMake such that they use
      the extended version string for the `CMAKE_MINIMUM_REQUIRED_VERSION`
      variable (which we don't use) but otherwise ignore it.
      c36289f1
  3. 24 May, 2018 1 commit
    • Lucas Gandel's avatar
      Improve QVTKOpenGLWidget and add QVTKOpenGLWindow class based on QOpenGLWindow · 45704131
      Lucas Gandel authored
      Fixing stereo support with Qt5.
      Commit 139f787a was introducing QVTKOpenGLWidget to couple a vtkRenderWindow with a QOpenGLWidget.
      However, both QVTKOpenGLWidget and its superclass QOpenGLWidget manage a single frame buffer.
      
      QVTKOpenGLWindow derives the QOpenGLWindow class to benefit from an OpenGL context managing multiple frame buffers.
      It can be used as a QWidget by calling QWidget::createWindowContainer() on your QVTKOpenGLWindow instance.
      QVTKOpenGLWidget has been reimplemented to use thes QVTKOpenGLWindow directly has a widget.
      It is recommended to do so.
      
      The old QVTKOpenGLWidget is been moved into QVTKOpenGLSimpleWidget and should not be removed as it support being a native widget,
      wich the new implementation does not.
      
      There is a new QVTKOpenGLWidget::isValid() method to check that the widget is ready to render.
      
      It is to be noted that there is a specific implementation of
      event handling in order to work around QTBUG-61836.
      The Qt::WindowTransparentForInputFlag has no effect on Mac. Thus events
      are not being passed to the widget. We let the window grabbing all events
      and then forward them to the widget.
      We also take care for providing a method to forward back events to the
      window if events were explicitely triggered on the widget instance. This
      is the case for some paraview testing logic that should now use the provided
      testingEvent() method instead of notifying the widget with events.
      
      It is to be noted that, on OSX, the widget is always resized to its internal vtkRenderWindow
      size to ensure that the viewport is correct.
      This is necessary only on MacOS when HiDPI is supported. Enabling HiDPI
      has the side effect that Cocoa will start overriding any glViewport calls
      in application code. For reference, see QCocoaWindow::initialize().
      
      This also improve tests and examples using the QVTKOpenGLWidget
      45704131
  4. 12 Feb, 2018 1 commit
    • luz.paz's avatar
      Misc. typos · 14b1d157
      luz.paz authored
      Found via `codespell` and regex
      14b1d157
  5. 25 Jan, 2018 1 commit
  6. 03 Jan, 2018 1 commit
  7. 31 Dec, 2017 1 commit
    • Hans Johnson's avatar
      COMP: Add more C++11 override instrumentation · bcf798e7
      Hans Johnson authored
      Providing override key work allows for extra checking
      that the function signatures are correct.
      
      https://stackoverflow.com/questions/39932391/virtual-override-or-both-c?answertab=active#tab-top
      
      In the derived class the function is virtual by way of having the ¹same
      type as the base class function.
      
      However, an override can help avoid bugs by producing a compilation
      error when the intended override isn't technically an override. E.g.
      that the function type isn't exactly like the base class function. Or
      that a maintenance of the base class changes that function's type, e.g.
      adding a defaulted argument.
      
      In the same way, a virtual keyword in the derived class can make such a
      bug more subtle, by ensuring that the function is still virtual in
      further derived classes.
      
      The general advice is,
           -Use virtual for the base class function declaration.
            This is technically necessary.
      
           -Use override (only) for a derived class' override.
            This helps maintenance.
      bcf798e7
  8. 06 Dec, 2017 1 commit
  9. 05 Dec, 2017 3 commits
  10. 04 Dec, 2017 1 commit
  11. 15 Nov, 2017 1 commit
  12. 06 Nov, 2017 1 commit
  13. 17 Oct, 2017 1 commit
  14. 12 Oct, 2017 2 commits
  15. 04 Oct, 2017 6 commits
  16. 02 Oct, 2017 1 commit
  17. 26 Sep, 2017 1 commit
  18. 07 Sep, 2017 1 commit
  19. 02 Aug, 2017 1 commit
  20. 03 Jun, 2017 1 commit
  21. 17 Mar, 2017 1 commit
    • Sean McBride's avatar
      Various updates/modernizations/improvements to SimpleCocoaVTK example · 5be7b81b
      Sean McBride authored
      - Now require newer Xcode and more modern Objective-C dialect.
      - Now require building VTK with VTK_CUSTOM_LIBRARY_SUFFIX="",
        which is best practice anyway if using Xcode, so that the CMake-built
        VTK libraries don't constantly change filenames (by having the version number embedded).
      - Adjusted Xcode project paths to remove version from filename.
      - Added a window controller class, which is more idiomatic.
      - The example now uses ARC (automatic reference counting) memory management by default.
      - renamed ivars to start with underscore, per Cocoa convention
      - added project.xcworkspace to .gitignore
      - added usual VTK divider line comments
      5be7b81b
  22. 14 Mar, 2017 2 commits
  23. 05 Jan, 2017 1 commit
  24. 16 Nov, 2016 1 commit
    • Sean McBride's avatar
      Various updates/modernizations/improvements to SimpleCocoaVTK example · f6d0deff
      Sean McBride authored
      - Now require newer Xcode and more modern Objective-C dialect.
      - Now require building VTK with VTK_CUSTOM_LIBRARY_SUFFIX="",
        which is best practice anyway if using Xcode, so that the CMake-built
        VTK libraries don't constantly change filenames (by having the version number embedded).
      - Adjusted Xcode project paths to remove version from filename.
      - Added a window controller class, which is more idiomatic.
      - The example now uses ARC (automatic reference counting) memory management by default.
      - renamed ivars to start with underscore, per Cocoa convention
      - added project.xcworkspace to .gitignore
      - added usual VTK divider line comments
      f6d0deff
  25. 26 Sep, 2016 1 commit
  26. 23 Sep, 2016 1 commit
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      Utilities/Maintenance/vtk-reindent-code.py
      
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      
      The bash command line used was the following:
      
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
        done
      done
      f830ff47
  27. 09 Aug, 2016 1 commit
    • Dženan Zukić's avatar
      Form labels are no longer clipped · 90dd47a5
      Dženan Zukić authored
      The text on some labels on the right side of the form are clipped
      because the labels themselves were not wide enough.
      This commit makes them wide enough to fit the text without clipping.
      90dd47a5
  28. 30 Jun, 2016 1 commit
  29. 27 Jun, 2016 1 commit
    • Haocheng LIU's avatar
      Fix bugs&typo in VTK Example folder · 039f7961
      Haocheng LIU authored
      With VTK new version, find_package cannot find VTK_RENDERING_BACKEND
      properly. The solution is to call find_package(VTK REQUIRED) first, then
      use vtk_module_config to load the needed modules. Some typos are also fixed.
      For Statistics example, the SetInput function is replaced by SetInputDta
      function(See vtkTableAlgorithm class).
      039f7961
  30. 08 Jun, 2016 1 commit
    • Joachim Pouderoux's avatar
      Fix an infinite loop that was introduced in Win32SampleMFC · ee46f867
      Joachim Pouderoux authored
      Recent change (MR #838) introduced an issue with MFC applications.
      This change make vtkHandleMessage2 transfer unprocessed messages to
      the OldProc handler. However in MFC, the window is created by MFC and
      MFC installs its event handler first. When we connect the render window
      interactor, this one does not setup its handler on it (even if OldProc
      points on the MFC handler). So the MFC handler catches the messages
      first and transfers them to the interactor through vtkHandleMessage2...
      and this one can now transfers them to the OldProc handler, which is
      the MFC one, so it loops.
      To fix we use the already existing feature of vtkHandleMessage2 function
      to change interactor's OldProc through a user defined message.
      We call this function when initializing the interactor providing the
      MFC superclass event handler.
      ee46f867
  31. 08 Mar, 2016 1 commit