1. 02 Aug, 2018 1 commit
    • Peter Franz's avatar
      Customize vtkAxis · c1b404a8
      Peter Franz authored
      Make the following methods in vtkAxis virtual so users can customize vtkAxis:
      GenerateSimpleLabel(), GenerateSprintfLabel(), GenerateLabelFormat(), GenerateLogSpacedLinearTicks()
      This was originally proposed by a post on
      with the purpose of allowing the user to use customized axis labels, e.g. for displaying dates or times.
      Apart from making the above methods virtual it is also required that the user can set the customized axis in a chart.
      Hence further modifications were necessary in vtkChart, vtkChartXY and vtkChartXYZ to replace the axis created in the chart
      by the customized axis.
      Further a change was made to vtkAxis to allow the axis title to be switched off.
  2. 20 Mar, 2018 1 commit
    • Sean McBride's avatar
      Applied clang-tidy modernize-use-equals-default fixes · 84ec1d57
      Sean McBride authored
      This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.
      There are now some duplicate semis because it did changes like:
        ~AMRIndexIterator() override{};
        ~AMRIndexIterator() override= default;;
      Note there was a pointless semi before, which clang-tidy didn’t expect / account for.
      My next commit will remove them.
  3. 29 Sep, 2017 1 commit
    • Andrew Bauer's avatar
      Improvements for vtkNew for stl containers and comparison operations · fd04b442
      Andrew Bauer authored
      Adding in functionality to allow inserting vtkNew objects into
      stl containers of vtkSmartPointer objects as well as comparisons
      between vtkNew objects and raw pointers. Also removing Get() and
      GetPointer() calls from vtkNew objects since in most instances we
      can just pass in the vtkNew<> object instead of having to use the
      Get() or GetPointer() methods to get the raw pointer.
  4. 26 Jul, 2017 1 commit
    • Kitware Robot's avatar
      Replace many NULL and 0 occurances with nullptr · a855cab0
      Kitware Robot authored
      This topic is the result of running clang-tidy to
      modernize our usage of NULL and 0 to nullptr. It also
      includes some manual and semi manual changes where
      clang-tidy would not be expected to work (such as in
      comments, or classes not compiled on this build)
      There are definitely many comments and occurances that
      this topic misses that we will need to fix over time.
  5. 30 May, 2017 1 commit
  6. 19 Jan, 2017 1 commit
  7. 23 Sep, 2016 1 commit
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      The bash command line used was the following:
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
  8. 06 May, 2016 1 commit
    • David C. Lonie's avatar
      Replace SafeDownCast calls on arrays with vtkArrayDownCast. · 0d71a308
      David C. Lonie authored
      SafeDownCast performs a series of virtual calls and string comparisons,
      which is quite slow, especially when used in worker functions.
      vtkArrayDownCast will switch between SafeDownCast and the more
      efficient FastDownCast (only available for common vtkAbstractArray
      subclasses) depending on whether or not FastDownCast is defined for
      the specific array type.
  9. 08 Mar, 2016 1 commit
  10. 02 Apr, 2015 1 commit
    • Sean McBride's avatar
      Fix -Wimplicit-fallthrough warnings; introduce VTK_FALLTHROUGH · 3cc4d9fc
      Sean McBride authored
      Fixed all clang -Wimplicit-fallthrough warnings:
      - Some fixed by adding missing breaks
      - Other fixed by adding VTK_FALLTHROUGH statement
      Under (modern) clang with C++11:
       #define VTK_FALLTHROUGH [[clang::fallthrough]]
       #define VTK_FALLTHROUGH ((void)0)
      VTK_FALLTHROUGH serves two purposes:
       - under clang, suppresses -Wimplicit-fallthrough warnings
       - makes code more self-documenting
  11. 03 Oct, 2014 2 commits
  12. 06 Aug, 2014 1 commit
  13. 07 Mar, 2014 1 commit
  14. 30 Apr, 2013 1 commit
    • Marcus D. Hanwell's avatar
      Added back in rendering of selected points · da0126c0
      Marcus D. Hanwell authored
      This was lost when the point plotting was moved to a dedicated class out
      of the vtkChartXYZ class. Restore this behavior, which is used in the
      scatter plot matrix animations for example.
      Change-Id: I1f69b4d45aef25566f8e8cd644f72245506b975e
  15. 21 Mar, 2013 1 commit
    • David Thompson's avatar
      Fix LogScale mode of vtkAxis. · 1412cda2
      David Thompson authored
      This change is to address ParaView bugs 13876, 13877, and 13899.
      It removes LogScaleReasonable and the associated logic which was
      contributing to nonsensical ranges for logarithmic axes.
      This patch also adds methods {Get,Set}Unscaled{Minimum,Maximum,Range}()
      so that fixed ranges may be specified in the same coordinate
      system as the source data. The versions of these methods without
      "Unscaled" in their names expect log-values to be passed or
      returned when LogScale is true, which is difficult for user-interface
      code to track.
      Additional changes are required to address the test case of
      ParaView bug 13899. With these changes, the minimum and maximum
      limit values are properly transformed when switching to and from
      log-scaled axes.
      Plots that rely on axes to determine scaling are fixed
      to refer to the active scaling (GetLogScaleActive) instead of
      the desired scaling (GetLogScale)..
      Change-Id: I1a4a3882bbeab2484145f4a75a6430cf6a0cea42
  16. 15 Nov, 2012 1 commit
  17. 07 Nov, 2012 1 commit
  18. 05 Nov, 2012 1 commit
  19. 29 Oct, 2012 1 commit
  20. 23 Oct, 2012 1 commit
    • Zack Galbreath's avatar
      fix errors, warnings, and test failures · 6a8338a1
      Zack Galbreath authored
      Fix segmentation fault encountered on some systems during
      Fix "invalid read" errors within vtkChartXYZ (reported by valgrind)
      Fix "variable shadowing" warning within RecalculateBounds()
      Make it so we recalculate which points are clipped when we zoom
      in or out using the mouse wheel.
      Change-Id: Iaa3246bfec900e33e02122a5f1045e0ba7de8942
  21. 19 Oct, 2012 1 commit
  22. 08 Oct, 2012 1 commit
    • Zack Galbreath's avatar
      refactor vtkChartXYZ · 7ef9d7a4
      Zack Galbreath authored
      It now follows the API of the 2D charts more closely.  vtkChartXYZ is
      responsible for the axes, while the subclasses of vtkPlot3D handle
      displaying the actual data.  As part of this effort, I've included
      optional interactivity into vtkChartXYZ.  This eliminates the need for a
      separate vtkInteractiveChartXYZ class.
      This change also introduces new functionality.  vtkPlotSurface allows us
      to visualize a table as a 3D surface plot.
      I've updated vtkScatterPlotMatrix so that it correctly uses the new API
      of vtkChartXYZ for animation.
      All affected tests were updated as well.
      Change-Id: Ic8406c99758a98851949c6153129f7704784e31a
  23. 29 Sep, 2012 1 commit
  24. 28 Sep, 2012 1 commit
  25. 20 Sep, 2012 1 commit
    • Kyle Lutz's avatar
      Fix warning in vtkChartXYZ · d3d0a596
      Kyle Lutz authored
      This fixes a shadowed variable warning in vtkChartXYZ.
      Change-Id: Ia9d0aec4f64760cef13d54e534ff7b11d015051a
  26. 18 Sep, 2012 7 commits
    • Zack Galbreath's avatar
      tweaks to clean up vtkInteractiveChartXYZ · 37b4ce7e
      Zack Galbreath authored
      use test driver & factory for interactive test mode
      (prior change to test was unnecessary)
      In InteractiveChartXYZ, initialize SceneWidth & SceneHeight
      to 0 in constructor.  This eliminates the need for an overloaded
      SetScene function.
      use static cast instead of C style cast in vtkChartXYZ.
      make vtkAxis::NiceNumber a static function to reduce code duplication.
      Change-Id: Ifa8674baed7c7a0ea4d94caa2570c25366f1b657
    • Zack Galbreath's avatar
      clean up windows build of InteractiveChartXYZ · 3a4edffd
      Zack Galbreath authored
      fix one linker error in the test, and a handful of warnings.
      Change-Id: I72a0adbc3ae7627d386f7c1305f68f75d77ace11
    • Zack Galbreath's avatar
      style fixes for XYZ charts · 72a86659
      Zack Galbreath authored
      capitalize all ivars and make sure they're spelled correctly
      make sure no lines exceed 80 characters
      remove some unused ivars from vtkChartXYZ
      Change-Id: Ibd7abda65b48015e2ff202cf651e6a790a9842ff
    • Zack Galbreath's avatar
      allow TestInteractiveChartXYZ to be run in interactive mode. · acb68438
      Zack Galbreath authored
      This involved fixing a bug where the vtkContextScene's Geometry
      could end up set to (0,0) despite the fact that the ContextItem
      already had a properly set Geometry.
      This commit also removes a debugging executable from the Testing
      CMakeLists.txt file, and removes some debugging print statements
      from the test.
      Change-Id: I866b00c24d3df144fa0303de54b4a0d66989bb82
    • Zack Galbreath's avatar
      Fix compile error due to missing header file · 097bfa0c
      Zack Galbreath authored
      We shouldn't try to include vtkChartXYZPrivate.h, since this file doesn't
      exist anymore.
      Change-Id: Ifaaa22ec7058fc687fbd61fda3d9697cd3530943
    • Zack Galbreath's avatar
      remove vtkChartXYZPrivate · 67e60842
      Zack Galbreath authored
      Move the contents of this private class into vtkChartXYZ and
      vtkInteractiveChartXYZ as ivars & methods.
      Change-Id: I3973bdc1b2859429a03ea81594309a5ef843edd5
    • Zack Galbreath's avatar
      New class: vtkInteractiveChartXYZ · 3e59b820
      Zack Galbreath authored
      This is a 3D chart that the user can interact with.
      Currently only rotation is supported.
      Change-Id: Id7ff5edec98372a679a613ddc523f10b956c792e
  27. 05 Sep, 2012 1 commit
  28. 25 Jun, 2012 1 commit
  29. 09 Apr, 2012 1 commit
    • VTK Developers's avatar
      Modularize VTK tree layout · cdd4d6fd
      VTK Developers authored
      Move source files from their former monolithic VTK location to their new
      location in modular VTK without modification.  This preserves enough
      information for "git blame -M" and "git log --follow" to connect
      modularized VTK files to their original location and history.
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
  30. 13 Mar, 2012 1 commit
  31. 11 Mar, 2012 1 commit
  32. 04 Mar, 2012 1 commit
    • Marcus D. Hanwell's avatar
      ENH: Improved axis rotation in vtkChartXYZ. · 8b7dd309
      Marcus D. Hanwell authored
      Once you realize that vtkTransform defaults to premultiply things get a
      lot simpler. This test shows the plots, and their final alignment too.
      Change-Id: I237a8e736cb5109e453b2ed5a4be1bf0c4bd2e98
  33. 03 Mar, 2012 1 commit
    • Marcus D. Hanwell's avatar
      ENH: Improvements to the scatter plot matrix. · 3cc028f9
      Marcus D. Hanwell authored
      Animations have been vastly improved, this has been achieved by storing
      a map of column names with axis ranges. The same axis range is set on
      all of the scatter plots (small, main and xyz) so that it is easier to
      map between them. The animations now end up in the exact same
      orientation and the 3D effect seems to be much more effective when
      animating. For now turning off the axis rendering in 3D, I will revisit
      that along with some of the rendering code.
      Change-Id: I467a4e712ee8a35c1ff2824afaece8f2177fcfa1