1. 31 Aug, 2018 1 commit
  2. 09 Jul, 2018 1 commit
    • luz.paz's avatar
      Misc. typos · 0d5f3207
      luz.paz authored
      Found via `codespell -q 3 -I ../vtk-whitelist-words.txt --skip="./ThirdParty,./Utilities,./Infovis"`
      0d5f3207
  3. 19 Jun, 2018 1 commit
    • Brad King's avatar
      cmake: declare support for CMake versions through 3.12 · c36289f1
      Brad King authored
      CMake 3.12 introduces a `...<max>` syntax in the version given to
      `cmake_minimum_required` to automatically set policies to NEW up
      to that version.  Use it to avoid listing policies explicitly.
      
      The syntax is compatible with older versions of CMake such that they use
      the extended version string for the `CMAKE_MINIMUM_REQUIRED_VERSION`
      variable (which we don't use) but otherwise ignore it.
      c36289f1
  4. 24 May, 2018 1 commit
    • Lucas Gandel's avatar
      Improve QVTKOpenGLWidget and add QVTKOpenGLWindow class based on QOpenGLWindow · 45704131
      Lucas Gandel authored
      Fixing stereo support with Qt5.
      Commit 139f787a was introducing QVTKOpenGLWidget to couple a vtkRenderWindow with a QOpenGLWidget.
      However, both QVTKOpenGLWidget and its superclass QOpenGLWidget manage a single frame buffer.
      
      QVTKOpenGLWindow derives the QOpenGLWindow class to benefit from an OpenGL context managing multiple frame buffers.
      It can be used as a QWidget by calling QWidget::createWindowContainer() on your QVTKOpenGLWindow instance.
      QVTKOpenGLWidget has been reimplemented to use thes QVTKOpenGLWindow directly has a widget.
      It is recommended to do so.
      
      The old QVTKOpenGLWidget is been moved into QVTKOpenGLSimpleWidget and should not be removed as it support being a native widget,
      wich the new implementation does not.
      
      There is a new QVTKOpenGLWidget::isValid() method to check that the widget is ready to render.
      
      It is to be noted that there is a specific implementation of
      event handling in order to work around QTBUG-61836.
      The Qt::WindowTransparentForInputFlag has no effect on Mac. Thus events
      are not being passed to the widget. We let the window grabbing all events
      and then forward them to the widget.
      We also take care for providing a method to forward back events to the
      window if events were explicitely triggered on the widget instance. This
      is the case for some paraview testing logic that should now use the provided
      testingEvent() method instead of notifying the widget with events.
      
      It is to be noted that, on OSX, the widget is always resized to its internal vtkRenderWindow
      size to ensure that the viewport is correct.
      This is necessary only on MacOS when HiDPI is supported. Enabling HiDPI
      has the side effect that Cocoa will start overriding any glViewport calls
      in application code. For reference, see QCocoaWindow::initialize().
      
      This also improve tests and examples using the QVTKOpenGLWidget
      45704131
  5. 20 Mar, 2018 2 commits
    • Sean McBride's avatar
      Removed a bunch of double semicolons at the end of lines · 2d148a8f
      Sean McBride authored
      154 occurances of ;;\n
      2d148a8f
    • Sean McBride's avatar
      Applied clang-tidy modernize-use-equals-default fixes · 84ec1d57
      Sean McBride authored
      This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.
      
      There are now some duplicate semis because it did changes like:
      
        ~AMRIndexIterator() override{};
      to
        ~AMRIndexIterator() override= default;;
      
      Note there was a pointless semi before, which clang-tidy didn’t expect / account for.
      
      My next commit will remove them.
      84ec1d57
  6. 11 Mar, 2018 1 commit
  7. 29 Jan, 2018 1 commit
  8. 25 Jan, 2018 1 commit
  9. 03 Jan, 2018 1 commit
  10. 31 Dec, 2017 1 commit
    • Hans Johnson's avatar
      COMP: Add more C++11 override instrumentation · bcf798e7
      Hans Johnson authored
      Providing override key work allows for extra checking
      that the function signatures are correct.
      
      https://stackoverflow.com/questions/39932391/virtual-override-or-both-c?answertab=active#tab-top
      
      In the derived class the function is virtual by way of having the ¹same
      type as the base class function.
      
      However, an override can help avoid bugs by producing a compilation
      error when the intended override isn't technically an override. E.g.
      that the function type isn't exactly like the base class function. Or
      that a maintenance of the base class changes that function's type, e.g.
      adding a defaulted argument.
      
      In the same way, a virtual keyword in the derived class can make such a
      bug more subtle, by ensuring that the function is still virtual in
      further derived classes.
      
      The general advice is,
           -Use virtual for the base class function declaration.
            This is technically necessary.
      
           -Use override (only) for a derived class' override.
            This helps maintenance.
      bcf798e7
  11. 15 Dec, 2017 1 commit
    • luz.paz's avatar
      Uniformity and several typo fixes · 17a8bc23
      luz.paz authored
      Mostly removing superflous double whitespace on both user-facing and non-user-facing strings. Some misc. typo fixes sprinkled in as well.
      17a8bc23
  12. 06 Dec, 2017 1 commit
  13. 05 Dec, 2017 3 commits
  14. 04 Dec, 2017 1 commit
  15. 15 Nov, 2017 1 commit
  16. 19 Oct, 2017 1 commit
  17. 12 Oct, 2017 1 commit
  18. 04 Oct, 2017 2 commits
  19. 02 Oct, 2017 1 commit
  20. 25 Sep, 2017 1 commit
  21. 02 Aug, 2017 1 commit
  22. 05 Jul, 2017 1 commit
  23. 05 Jan, 2017 1 commit
  24. 23 Sep, 2016 1 commit
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      Utilities/Maintenance/vtk-reindent-code.py
      
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      
      The bash command line used was the following:
      
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
        done
      done
      f830ff47
  25. 13 Jul, 2016 1 commit
    • Sean McBride's avatar
      Used clang-tidy's "modernize-use-override" to add some C++11 overrides · 753dcec5
      Sean McBride authored
      It doesn't seem to have got everything, but it's a start.
      
      Some resulting whitespace is suboptimal, but one day
      we can fix that with clang-format. :)
      
      Just ran this command:
      run-clang-tidy.py -checks=-*,modernize-use-override -fix
      
      (I actually had to build my own clang to make clang-tidy
      output "VTK_OVERRIDE" instead of "override".)
      753dcec5
  26. 30 Jun, 2016 2 commits
  27. 27 Jun, 2016 1 commit
    • Haocheng LIU's avatar
      Fix bugs&typo in VTK Example folder · 039f7961
      Haocheng LIU authored
      With VTK new version, find_package cannot find VTK_RENDERING_BACKEND
      properly. The solution is to call find_package(VTK REQUIRED) first, then
      use vtk_module_config to load the needed modules. Some typos are also fixed.
      For Statistics example, the SetInput function is replaced by SetInputDta
      function(See vtkTableAlgorithm class).
      039f7961
  28. 06 May, 2016 1 commit
    • David C. Lonie's avatar
      Replace SafeDownCast calls on arrays with vtkArrayDownCast. · 0d71a308
      David C. Lonie authored
      SafeDownCast performs a series of virtual calls and string comparisons,
      which is quite slow, especially when used in worker functions.
      
      vtkArrayDownCast will switch between SafeDownCast and the more
      efficient FastDownCast (only available for common vtkAbstractArray
      subclasses) depending on whether or not FastDownCast is defined for
      the specific array type.
      0d71a308
  29. 08 Mar, 2016 1 commit
  30. 29 Jan, 2016 1 commit
    • Berk Geveci's avatar
      Refactored and update the way algorithms are updated. · f020ebb6
      Berk Geveci authored
      The way algorithms were updated (made to execute) with
      request meta-data (such as update extent) was very error
      prone and counter-intuitive. Added new methods to make
      updating with meta-data easier. I also deprecated a number
      of methods to set request meta-data. This will encourage
      developers to migrate to the new API which is less error-
      prone.
      f020ebb6
  31. 26 Jan, 2016 1 commit
  32. 03 Dec, 2015 1 commit
  33. 07 Oct, 2015 1 commit
  34. 21 Aug, 2015 1 commit
  35. 22 Jul, 2015 1 commit
    • Bill Lorensen's avatar
      STYLE: Replace vtksys_stl and vtksys_ios:: with std:: · 924248d9
      Bill Lorensen authored
      In the early days of VTK, support for stl was not portable. vtksys_stl
      and vtksys_ios provided a portable implementation of the stl. Now, all
      of the VTK supported compilers have portable stl implementations.
      
      This patch:
        1) Replaces the vtksys_ios:: with std::.
        2) Replaces the vtksys_stl:: with std::.
        3) Removes "using" statements for stl
      924248d9