1. 03 Jun, 2018 1 commit
    • Utkarsh Ayachit's avatar
      vtkPythonAlgorithm: cleanup exception reporting code. · 4b477bb5
      Utkarsh Ayachit authored
      vtkPythonAlgorithm's exception reporting code has issues with Python 3
      where it could segfault. Cleaning it up to simply use `PyErr_Print`.
      We typically already capture stdout/stderr to pipe to VTK's error
      reporting mechanism hence nothing special needs to be done.
      4b477bb5
  2. 31 May, 2018 1 commit
  3. 13 May, 2018 1 commit
  4. 02 May, 2018 1 commit
    • Utkarsh Ayachit's avatar
      avoid segfault during app exit. · 101da2ed
      Utkarsh Ayachit authored
      Since in applications using Python, Python may get finalized before all
      VTK objects are released, we may encounter segfaults during exit. This
      fixes that issue by ensuring that Python interpreter is initialized
      before calling `Py_XDECREF`.
      101da2ed
  5. 13 Mar, 2018 1 commit
  6. 19 Jan, 2018 1 commit
  7. 05 Dec, 2017 1 commit
  8. 04 Oct, 2017 1 commit
  9. 02 Oct, 2017 1 commit
  10. 26 Jul, 2017 1 commit
    • Kitware Robot's avatar
      Replace many NULL and 0 occurances with nullptr · a855cab0
      Kitware Robot authored
      This topic is the result of running clang-tidy to
      modernize our usage of NULL and 0 to nullptr. It also
      includes some manual and semi manual changes where
      clang-tidy would not be expected to work (such as in
      comments, or classes not compiled on this build)
      
      There are definitely many comments and occurances that
      this topic misses that we will need to fix over time.
      a855cab0
  11. 01 Jun, 2017 1 commit
  12. 16 Jan, 2017 2 commits
    • Robert Maynard's avatar
      Convert vtk over to using VTK_OVERRIDE · 3f7a2769
      Robert Maynard authored
      3f7a2769
    • Michka Popoff's avatar
      ENH: Do not link against libpython when possible · 5668595e
      Michka Popoff authored
      This is similar to what is already done in ITK and SimpleITK.
      
      The new vtkTargetLinkLibrariesWithDynamicLookup.cmake file is slightly modified copy from
      ITK/CMake/itkTargetLinkLibrariesWithDynamicLookup.cmake
      The explanation of what this patch tries to achieve is documented in this file.
      
      A new argument is introduced, called OPTIONAL_PYTHON_LINK.
      When used, the module will be optionally be linked against libpython.
      In the module.cmake files, most vtkPython dependencies were moved to COMPILE_DEPENDS, so that libpython is not added to the target_link_libraries() call.
      
      The vtkPython is explicitely linked against the python libraries, as this is a python executable.
      
      Also, the find_package calls for the PythonLibs were made optional when possible.
      
      The XDMF3 project was not updated, this will need to be done separately if weak linking is wished for that project.
      
      Fixes: #16068
      5668595e
  13. 23 Sep, 2016 2 commits
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      Utilities/Maintenance/vtk-reindent-code.py
      
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      
      The bash command line used was the following:
      
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
        done
      done
      f830ff47
    • David E. DeMarle's avatar
      replace VTK's nonstandard Doxygen with standard markup · 6a7e5148
      David E. DeMarle authored
      generated via:
      cd $VTKSRC
      perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
      cp -r ~/tmp/vtkheaders/* .
      6a7e5148
  14. 12 Sep, 2016 1 commit
    • Haocheng LIU's avatar
      Rewrite all public&private dependency in module.cmake file · 6e113ad4
      Haocheng LIU authored
      The current dependency relationship in vtk is unclear and misleading.
      This MR tries to rewrite them based on header files inclusion of headers
      and source files in each module. Corner cases are considered and
      modules are sorted in alphabetical order to facilitate future reference.
      See details in my gitlab python based script project. In future we can continue
      using this script to clean the VTK Dependency easily from
      time to time.
      6e113ad4
  15. 08 Jul, 2016 1 commit
  16. 07 Jul, 2016 2 commits
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION to many constructors · 1853e030
      Sean McBride authored
      vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;
      
      vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;
      1853e030
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION for operator= · 2d0e11ef
      Sean McBride authored
      (operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
      to
      \1 VTK_DELETE_FUNCTION;
      
      After that, this finds basically nothing:
      
      operator.*implemented
      
      then manually reverted changed files in VPIC and KWSys folders.
      2d0e11ef
  17. 26 Jun, 2016 1 commit
    • Michka Popoff's avatar
      ENH: Do not link against libpython when possible · 772cc086
      Michka Popoff authored
      This is similar to what is already done in ITK and SimpleITK.
      
      The new vtkTargetLinkLibrariesWithDynamicLookup.cmake file is slightly modified copy from ITK (things have been renamed from ITK to VTK). The explanation of what this patch tries to achieve is documented in this file.
      
      A new argument is introduced, called OPTIONAL_PYTHON_LINK. When used, the module will be optionally be linked against libpython. In the module.cmake files, most vtkPython dependencies were moved to COMPILE_DEPENDS, so that libpython is not added to the target_link_libraries() call.
      
      The vtkPython is explicitely linked against the python libraries, as this is a python executable.
      
      Also, the find_package calls for the PythonLibs were made optional when possible.
      
      This fixes the following bug: http://www.vtk.org/Bug/view.php?id=16068
      772cc086
  18. 08 Mar, 2016 1 commit
  19. 06 Aug, 2015 1 commit
    • David Gobbi's avatar
      Python API compatibility for py3k. · d3eb4043
      David Gobbi authored
      This is a large change that adds conditional compilation to support
      both python 2 and python 3.  The header vtkPythonCompatibility.h
      does a lot of the necessary work:
      1) PyInt is redefined to PyLong for py3k
      2) PyString is redefied to PyUnicode for py3k
      3) PyBytes is redefined to PyString for python 2
      d3eb4043
  20. 18 Dec, 2014 1 commit
  21. 16 Sep, 2014 1 commit
    • Ben Boeckel's avatar
      vtkPythonAlgorithm: print out all the error information · b0cd19ba
      Ben Boeckel authored
      Unfortunately, Python has this habit of using the name of the
      exception's class for critical information and the stringification of
      the exception itself is useless on its own (e.g., AttributeError's
      string is just the name of the attribute that is missing). To get better
      error information, use traceback.format_exception if it is available.
      
      Change-Id: I7fcbd9a12e505b2e3422c31dcf52055d98144a64
      b0cd19ba
  22. 07 Sep, 2014 1 commit
  23. 07 Aug, 2014 1 commit
    • Shawn Waldon's avatar
      Add a smartpointer for PyObjects · f9a208d6
      Shawn Waldon authored
      This refactors the SmartPyObject class from a local class in
      vtkMatplotlibMathTextUtilities.cxx to be externally visible.  This class
      is duplicated several places in Paraview and this refactor will allow
      code to be shared between all places that need it.  It is added to the
      vtkWrappingPythonCore module as the vtkSmartPyObject class.
      
      This commit also refactors the vtkPythonAlgorithm to use the new smart
      pointer.
      
      This commit is part of a change to ParaView and thus the topic name
      reflects that change and not the change to VTK.
      
      Change-Id: If3f0387bb7bb24f823dbe690e64a0a8bb1e0df16
      f9a208d6
  24. 03 Jul, 2014 1 commit
    • Ben Boeckel's avatar
      modules: add modules to "kits" · e5203447
      Ben Boeckel authored
      The main kits are:
      
          vtkCommon
          vtkFilters
          vtkIO
          vtkImaging
          vtkInteraction
          vtkOpenGL (required due to a dependency cycle from
                     vtkRenderingOpenGL on vtkImagingHybrid)
          vtkParallel
          vtkRendering
          vtkViews
          vtkWrapping
      
      Modules which deal with a specialization of another module belong to the
      kit related to the specialization (i.e., FiltersParallel and
      IOParallelXML both belong to the vtkParallel kit) to avoid circular
      dependencies that arise when put into the same kit as the "lesser"
      module.
      
      Change-Id: Icae0baa78d62cc0dcce84546541df600d4f311dd
      e5203447
  25. 13 Jun, 2014 2 commits
  26. 11 Jun, 2014 2 commits
  27. 10 Jun, 2014 1 commit
    • Ben Boeckel's avatar
      vtkPythonAlgorithm: support older pythons · 4b74588b
      Ben Boeckel authored
      Older Python's PyObject_GetAttrString did not take a const char*, but
      instead a char*. This disallows using static strings for the attribute
      name.
      
      Change-Id: I349b14f532c34fcc7c2ac6f03e24c171847bc51e
      4b74588b
  28. 06 Jun, 2014 1 commit