1. 17 Sep, 2018 1 commit
  2. 14 Sep, 2018 1 commit
  3. 31 Aug, 2018 2 commits
  4. 26 Jul, 2018 1 commit
    • Sean McBride's avatar
      Added missing overrides found by cppcheck 1.84 · c0d6d943
      Sean McBride authored
      missingOverride,Examples/GUI/Win32/SampleMFC/SampleDoc.h:47
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:49
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:50
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:52
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:54
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:61
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:62
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:69
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:70
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:60
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:61
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:62
      missingOverride,IO/ADIOS/FunctionPointers.h:114
      missingOverride,IO/Video/vtkMILVideoSource.h:104
      missingOverride,IO/Video/vtkMILVideoSource.h:243
      missingOverride,IO/Video/vtkMILVideoSource.h:249
      missingOverride,IO/Video/vtkMILVideoSource.h:259
      missingOverride,IO/Video/vtkMILVideoSource.h:79
      missingOverride,IO/Video/vtkMILVideoSource.h:84
      missingOverride,IO/Video/vtkMILVideoSource.h:89
      missingOverride,IO/Video/vtkMILVideoSource.h:94
      missingOverride,IO/Video/vtkMILVideoSource.h:99
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:206
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:219
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:220
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:68
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:238
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:239
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:66
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:37
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:43
      missingOverride,Rendering/OptiX/vtkOptiXCompositePolyDataMapper2Node.h:45,style,The function 'Render' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,Utilities/Benchmarks/GLBenchmarking.cxx:74
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:162
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:164
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:166
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:270
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:273
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:276
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:409
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:414
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:419
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:532
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:534
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:536
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:58
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:60
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:62
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:658
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:660
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:662
      missingOverride,IO/ADIOS/ADIOSWriter.cxx:159,style,The function 'GetInt' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:31,style,The function 'ExecVoid' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:50,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:69,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:90,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      c0d6d943
  5. 09 Jul, 2018 1 commit
    • luz.paz's avatar
      Misc. typos · 0d5f3207
      luz.paz authored
      Found via `codespell -q 3 -I ../vtk-whitelist-words.txt --skip="./ThirdParty,./Utilities,./Infovis"`
      0d5f3207
  6. 19 Jun, 2018 1 commit
    • Brad King's avatar
      cmake: declare support for CMake versions through 3.12 · c36289f1
      Brad King authored
      CMake 3.12 introduces a `...<max>` syntax in the version given to
      `cmake_minimum_required` to automatically set policies to NEW up
      to that version.  Use it to avoid listing policies explicitly.
      
      The syntax is compatible with older versions of CMake such that they use
      the extended version string for the `CMAKE_MINIMUM_REQUIRED_VERSION`
      variable (which we don't use) but otherwise ignore it.
      c36289f1
  7. 17 Jun, 2018 2 commits
  8. 24 May, 2018 1 commit
    • Lucas Gandel's avatar
      Improve QVTKOpenGLWidget and add QVTKOpenGLWindow class based on QOpenGLWindow · 45704131
      Lucas Gandel authored
      Fixing stereo support with Qt5.
      Commit 139f787a was introducing QVTKOpenGLWidget to couple a vtkRenderWindow with a QOpenGLWidget.
      However, both QVTKOpenGLWidget and its superclass QOpenGLWidget manage a single frame buffer.
      
      QVTKOpenGLWindow derives the QOpenGLWindow class to benefit from an OpenGL context managing multiple frame buffers.
      It can be used as a QWidget by calling QWidget::createWindowContainer() on your QVTKOpenGLWindow instance.
      QVTKOpenGLWidget has been reimplemented to use thes QVTKOpenGLWindow directly has a widget.
      It is recommended to do so.
      
      The old QVTKOpenGLWidget is been moved into QVTKOpenGLSimpleWidget and should not be removed as it support being a native widget,
      wich the new implementation does not.
      
      There is a new QVTKOpenGLWidget::isValid() method to check that the widget is ready to render.
      
      It is to be noted that there is a specific implementation of
      event handling in order to work around QTBUG-61836.
      The Qt::WindowTransparentForInputFlag has no effect on Mac. Thus events
      are not being passed to the widget. We let the window grabbing all events
      and then forward them to the widget.
      We also take care for providing a method to forward back events to the
      window if events were explicitely triggered on the widget instance. This
      is the case for some paraview testing logic that should now use the provided
      testingEvent() method instead of notifying the widget with events.
      
      It is to be noted that, on OSX, the widget is always resized to its internal vtkRenderWindow
      size to ensure that the viewport is correct.
      This is necessary only on MacOS when HiDPI is supported. Enabling HiDPI
      has the side effect that Cocoa will start overriding any glViewport calls
      in application code. For reference, see QCocoaWindow::initialize().
      
      This also improve tests and examples using the QVTKOpenGLWidget
      45704131
  9. 18 May, 2018 1 commit
    • Kitware Robot's avatar
      ExternalData: Convert content links from MD5 to SHA512 · d6d05b2a
      Kitware Robot authored
      Populate a script with `map_<md5>=<sha512>` variable settings and
      then run the following to convert the content link files:
      
          git ls-files -- '*.md5' | while read f; do
            md5="$(cat "$f")"
            sha512="$(eval echo \${map_$md5})"
            rm "$f"
            echo $sha512 > ${f%.md5}.sha512
          done
      d6d05b2a
  10. 20 Mar, 2018 2 commits
    • Sean McBride's avatar
      Removed a bunch of double semicolons at the end of lines · 2d148a8f
      Sean McBride authored
      154 occurances of ;;\n
      2d148a8f
    • Sean McBride's avatar
      Applied clang-tidy modernize-use-equals-default fixes · 84ec1d57
      Sean McBride authored
      This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.
      
      There are now some duplicate semis because it did changes like:
      
        ~AMRIndexIterator() override{};
      to
        ~AMRIndexIterator() override= default;;
      
      Note there was a pointless semi before, which clang-tidy didn’t expect / account for.
      
      My next commit will remove them.
      84ec1d57
  11. 11 Mar, 2018 1 commit
  12. 05 Mar, 2018 1 commit
    • luz.paz's avatar
      Misc. typos · d77327a4
      luz.paz authored
      Includes source typos that have been squashed. 
      d77327a4
  13. 16 Feb, 2018 10 commits
    • Benjamin Beney's avatar
      ENH: Add support of multiple files loading · 988cd448
      Benjamin Beney authored
      Replace deprecated didPickDocumentAtURL by didPickDocumentsAtURLs.
      Set allowMultipleSelection boolean on document picker to true.
      Add loadFiles() function. Handle NSArray<NSURL*>* instead of NSURL*.
      Add a way to reset the scene before adding multiple files (user is
      prompted with an alert message to pick whether the scene should be reset or
      not).
      988cd448
    • Alexis Girault's avatar
      ENH: Add example data to VTKViewer · d8e58500
      Alexis Girault authored
      - Create `ExampleDataManager` to list the URls of datasets to use as
      example data for VTKViewer, and download them
      - When the app starts, download the example datasets to the app Document
      directory
      - Keep track of what data was downloaded to avoid redownloading datasets
      (for example, if the user deleted or moved some)
      - Set `UISupportsDocumentBrowser` to TRUE in Info.plist to be able to
      access that directory from the `UIDocumentPickerViewController`
      - Use data stored on data.kitware.com at:
      https://data.kitware.com/#collection/5a1342ee8d777f31ac64f1d1/folder/5a1343028d777f31ac64f1d2
      d8e58500
    • Benjamin Beney's avatar
      ENH: Open url to load from outside of VTKViewer · 60567337
      Benjamin Beney authored
      - If app already opened, directly load file
      - If app not yet opened, store url, load VTKViewController, then load file
      Co-Authored-By: Alexis Girault's avatarAlexis Girault <alexis.girault@kitware.com>
      60567337
    • Alexis Girault's avatar
      Add loading utilities in VTKViewer · 24b3a9ca
      Alexis Girault authored
      - Add `com.kitware.vtk` exported UTIs for files with the extensions vtk,
      vti, vtp, vtr, vts, vtu
      - Add `VTK Viewer Supported Files` document type including `com.kitware.vtk`
      UTI as well as `public.standard-tesselated-geometry-format` for stl,
      `public.geometry-definition-format` for obj,
      and `public.polygon-file-format` for ply
      - Add a button in VTKViewController header to open documents through a
      `UIDocumentPickerViewController`
      - Add `VTKLoader` to setup the proper readers and create a polydata or
      datasetmapper (no specific volume mapper or slice mapper for images yet)
      then setup the mapper and return an actor
      
      Co-Authored-By: "Benjamin Beney <benjamin.beney@kitware.com>"
      24b3a9ca
    • Alexis Girault's avatar
      UI: Update VTKViewer UI · 4e3998d2
      Alexis Girault authored
      - Get rid of navigation controller and tab bar controller
      - Make `VTKViewController` the starting view controller
      - Add header bar where will lay the options
      - Hide/Show header bar on double tap
      4e3998d2
    • Alexis Girault's avatar
      UI: Hide status bar in VTKViewer · 37382e96
      Alexis Girault authored
      37382e96
    • Benjamin Beney's avatar
      Switch VTKViewer AppDelegate to swift · ce9504a2
      Benjamin Beney authored
      ce9504a2
    • Alexis Girault's avatar
      ENH: Improve VTKViewer performance by limiting render calls · 23badbe8
      Alexis Girault authored
      By default, the interactor triggers a render call everytime an event
      occurs. There is too many events occuring when using ios gestures since
      there is no mechanism to squash them. This will result in render calls
      being queued and performance decreasing.
      
      Setting `EnableRender` to Off on the interactor will allow to only render
      using `setNeedsDisplay`. That flag can be set on the vtkView when render
      is needed (see in VTKGestureHandler), and will result in a rendered frame
      only when the device is able to render.
      23badbe8
    • Alexis Girault's avatar
      ENH: Improve VTKViewer gesture handler · be94af0b
      Alexis Girault authored
      - Init with vtkview only to have gestures only setup for vtkview, which
      allows to get rid of `gestureRecognizerShouldBegin`
      - Implement `forwardTouchPositionToInteractor` to forward gesture position
      to the vtk interactor
      - Get rid of obsolete rotation speed
      - Replace translation speed by the GLKView scale factor
      - Merge onTwoFingerPan and onTrackBallMotion to handle the switch between
      1 to 2 fingers and vice-versa without releasing all fingers
      - Get rid of unused gesture handlers (single tap, double tap, long press)
      - Get rid of last touch (will be needed for CT scrolling only)
      - Get rid of boundingBox in VTKViewController (not needed in gestures)
      be94af0b
    • Alexis Girault's avatar
  14. 12 Feb, 2018 1 commit
    • luz.paz's avatar
      Misc. typos · 14b1d157
      luz.paz authored
      Found via `codespell` and regex
      14b1d157
  15. 08 Feb, 2018 1 commit
  16. 29 Jan, 2018 1 commit
  17. 25 Jan, 2018 1 commit
  18. 22 Jan, 2018 2 commits
    • csukuangfj's avatar
      Fix typos. · 8609391a
      csukuangfj authored
      8609391a
    • Ken Martin's avatar
      rework the mtl file handling for obj/mtl files · 8674ca6b
      Ken Martin authored
      also add a new exporter designed to work with
      obj file although it will work with any scene
      in vtk.
      
      The new exporter takes all the actors in a scene
      and stores them as a single vtp file. It also takes
      all the texturs and combines them into a single texture.
      The exporter is designed to take OBJ files that may
      consist of mulitple parts each with their own texture
      and convert them into a singlke vtp file so that they are
      easier to work with in ParaView/etc.
      8674ca6b
  19. 03 Jan, 2018 1 commit
  20. 31 Dec, 2017 1 commit
    • Hans Johnson's avatar
      COMP: Add more C++11 override instrumentation · bcf798e7
      Hans Johnson authored
      Providing override key work allows for extra checking
      that the function signatures are correct.
      
      https://stackoverflow.com/questions/39932391/virtual-override-or-both-c?answertab=active#tab-top
      
      In the derived class the function is virtual by way of having the ¹same
      type as the base class function.
      
      However, an override can help avoid bugs by producing a compilation
      error when the intended override isn't technically an override. E.g.
      that the function type isn't exactly like the base class function. Or
      that a maintenance of the base class changes that function's type, e.g.
      adding a defaulted argument.
      
      In the same way, a virtual keyword in the derived class can make such a
      bug more subtle, by ensuring that the function is still virtual in
      further derived classes.
      
      The general advice is,
           -Use virtual for the base class function declaration.
            This is technically necessary.
      
           -Use override (only) for a derived class' override.
            This helps maintenance.
      bcf798e7
  21. 21 Dec, 2017 1 commit
  22. 15 Dec, 2017 1 commit
    • luz.paz's avatar
      Uniformity and several typo fixes · 17a8bc23
      luz.paz authored
      Mostly removing superflous double whitespace on both user-facing and non-user-facing strings. Some misc. typo fixes sprinkled in as well.
      17a8bc23
  23. 14 Dec, 2017 1 commit
  24. 13 Dec, 2017 1 commit
  25. 06 Dec, 2017 2 commits
  26. 05 Dec, 2017 1 commit