1. 05 Oct, 2018 1 commit
  2. 02 Oct, 2018 1 commit
    • Csaba Pinter's avatar
      ENH: Add timer in vtkInteractorStyle3D to allow for smooth flying · 8272090e
      Csaba Pinter authored
      Dolly translation speed can be specified in m/s, to achieve a constant flying speed that is not dependent on frame rate or physical scale. Default is 1.6666 m/s, which corresponds to walking speed (6 km/h). Do not dolly if left or right side of the trackpad is pressed instead of up/down.
      8272090e
  3. 01 Oct, 2018 1 commit
    • Csaba Pinter's avatar
      ENH: Use pose matrices instead of camera parameters for VR controllers · 803d3a32
      Csaba Pinter authored
      It is easier to manage controller pose as a matrix instead of the (pos,wxyz,ppos,wdir) variables that the ConvertPoseToWorldCoordinates function calculates. A function called ConvertOpenVRPoseToMatrices was added that calculates the matrix. It is used in various places in addition or instead of those variables.
      A PhysicalToWorldMatrixModified event is added to vtkOpenVRRenderWindow to enable notifications to the application when the physical scaling, translation, etc. changes.
      
      Small changes:
      - Fix incorrect sign of VR physical to world matrix translation
      - Fix gesture end event invocation (Trigger button release was checked instead of Grip, as it is done for press)
      - Add comments for physical to world ivars and controller pose camera style variables for easier understanding
      - Remove unused PoseTransform member variable from vtkOpenVRRenderWindowInteractor
      803d3a32
  4. 20 Sep, 2018 1 commit
    • Csaba Pinter's avatar
      ENH: Add functions to set VR physical geometry with matrix · ed74f20d
      Csaba Pinter authored
      - Get/SetPhysicalToWorldMatrix functions added to vtkOpenVRRenderWindow to handle the PhysicalTranslation etc. camera related geometry changes as a matrix
      - Refactored UpdateHMDMatrixPose code so that it is more understandable what happens under the hood when the camera is set. It works the very same way, but it is now better formalized and readable.
      Here's how setting the camera works:
      Scaling is applied through moving the camera closer to the focal point, because scaling of all actors is not feasible, and vtkCamera::ModelTransformMatrix is not supported throughout VTK (clipping issues etc.). To achieve this, a new coordinate system called NonScaledWorld is introduced. The relationship between Physical (in which the HMD pose is given by OpenVR) and NonScaledWorld is described by the PhysicalViewUp etc. member variables. After getting the HMD pose in Physical, those coordinates and axes are converted to the NonScaledWorld coordinate system, on which the PhysicalScaling trick of modifying the camera position is applied, resulting the World coordinate system.
      - Renamed incorrect distance variable to physical scale
      ed74f20d
  5. 19 Sep, 2018 1 commit
  6. 17 Sep, 2018 2 commits
  7. 14 Sep, 2018 2 commits
    • Sean McBride's avatar
      Manually reviewed use of 'static int' occurrences · e7d7f32c
      Sean McBride authored
      - Changed some to be const also.
      - Replaced others with call to ClampValue method.
      - Changed some from int to bool.
      - In a couple of cases the variable was unused, removed it.
      e7d7f32c
    • Sean McBride's avatar
      Replaced some uses of vtkMath::Round with STL rounding · 56bf715c
      Sean McBride authored
      vtkMath::Round converts double to int, as opposed to long.  Both can be lossy, but the former much more so.
      
      Replaced some uses with std::round(), some with std::lround().
      
      Eliminated the long->int truncation as much as possible, but kept it in many instances.
      56bf715c
  8. 02 Aug, 2018 1 commit
  9. 27 Jul, 2018 1 commit
  10. 26 Jul, 2018 1 commit
    • Sean McBride's avatar
      Added missing overrides found by cppcheck 1.84 · c0d6d943
      Sean McBride authored
      missingOverride,Examples/GUI/Win32/SampleMFC/SampleDoc.h:47
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:49
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:50
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:52
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:54
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:61
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:62
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:69
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:70
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:60
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:61
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:62
      missingOverride,IO/ADIOS/FunctionPointers.h:114
      missingOverride,IO/Video/vtkMILVideoSource.h:104
      missingOverride,IO/Video/vtkMILVideoSource.h:243
      missingOverride,IO/Video/vtkMILVideoSource.h:249
      missingOverride,IO/Video/vtkMILVideoSource.h:259
      missingOverride,IO/Video/vtkMILVideoSource.h:79
      missingOverride,IO/Video/vtkMILVideoSource.h:84
      missingOverride,IO/Video/vtkMILVideoSource.h:89
      missingOverride,IO/Video/vtkMILVideoSource.h:94
      missingOverride,IO/Video/vtkMILVideoSource.h:99
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:206
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:219
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:220
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:68
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:238
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:239
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:66
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:37
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:43
      missingOverride,Rendering/OptiX/vtkOptiXCompositePolyDataMapper2Node.h:45,style,The function 'Render' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,Utilities/Benchmarks/GLBenchmarking.cxx:74
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:162
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:164
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:166
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:270
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:273
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:276
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:409
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:414
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:419
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:532
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:534
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:536
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:58
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:60
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:62
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:658
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:660
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:662
      missingOverride,IO/ADIOS/ADIOSWriter.cxx:159,style,The function 'GetInt' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:31,style,The function 'ExecVoid' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:50,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:69,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:90,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      c0d6d943
  11. 14 Jul, 2018 1 commit
    • Ken Martin's avatar
      use hardwareselector to perform picking · 1eb083a8
      Ken Martin authored
      We used to have two implementations for picking. The
      hardware selector and the PickProp code. This topic implements
      PickProp by using the selector. That way we have fewer paths
      of code to maintain.
      1eb083a8
  12. 11 Jul, 2018 1 commit
  13. 10 Jul, 2018 1 commit
  14. 27 Jun, 2018 1 commit
  15. 19 Jun, 2018 1 commit
    • Brad King's avatar
      cmake: declare support for CMake versions through 3.12 · c36289f1
      Brad King authored
      CMake 3.12 introduces a `...<max>` syntax in the version given to
      `cmake_minimum_required` to automatically set policies to NEW up
      to that version.  Use it to avoid listing policies explicitly.
      
      The syntax is compatible with older versions of CMake such that they use
      the extended version string for the `CMAKE_MINIMUM_REQUIRED_VERSION`
      variable (which we don't use) but otherwise ignore it.
      c36289f1
  16. 17 Jun, 2018 2 commits
  17. 18 Apr, 2018 1 commit
    • Ken Martin's avatar
      clean up the state API and fix Qt widget · 29670593
      Ken Martin authored
      Make it so that the state API does not require glew.h
      as this causes issues with Qt which has it's own gl
      functions and glew #defines clobber them.
      
      Clean up the API for querying opengl state to use the standard
      opengl get method signatures.
      
      Fix an issue with the new Qt widget where it was not setting
      vtk opengl state.
      29670593
  18. 11 Apr, 2018 1 commit
    • Ken Martin's avatar
      move framebuffer binding out of camera and into window · 9ac9a11a
      Ken Martin authored
      The binding of framebuffers in camera or camerapass did
      not make much sense. Right now viewport and scissor
      are still handled in the camera although they are properties
      of the renderer and maybe should be moved into renderer.
      
      This does mean that if something changes the fo bindings
      while rendering it should restore them. This is already
      the convention but it is a bit more important as the
      fo binding is now done before the camera.
      9ac9a11a
  19. 09 Apr, 2018 1 commit
  20. 05 Apr, 2018 1 commit
    • Ken Martin's avatar
      some minor features and fixes for openvr · e587f373
      Ken Martin authored
      A compile fix for newer versions of OpenVR that
      changed their API.
      
      Expose method to load camera poses from an XMLDataElement
      
      Minor fix to use PhysicalScale instead of Distance in one place
      e587f373
  21. 23 Mar, 2018 1 commit
  22. 20 Mar, 2018 1 commit
  23. 16 Mar, 2018 1 commit
  24. 28 Feb, 2018 1 commit
    • Ken Martin's avatar
      update glsl code to 140 standards · 3c999de5
      Ken Martin authored
      While maintaining backwards compatibility at least
      update our code to use the more modern in/out
      qualifiers as opposed to attribute/varying  Also
      remove old glsl 120 if statements as we no longer support
      it and also remove a performance issue in querying the
      gl major minor version on every shader test.
      3c999de5
  25. 26 Feb, 2018 2 commits
  26. 25 Feb, 2018 1 commit
    • Ken Martin's avatar
      Introduce opengl state management · 1e6e44cb
      Ken Martin authored
      This commit adds a vtkOpenGLState class that is used
      to save, restore and cache opengl state. In this commit
      the caching is disabled to ease rollout. Likewise only
      a few methods are being cached which can be expanded
      on later as desired.
      1e6e44cb
  27. 29 Jan, 2018 1 commit
  28. 04 Jan, 2018 1 commit
  29. 20 Dec, 2017 1 commit
  30. 14 Dec, 2017 1 commit
  31. 11 Dec, 2017 2 commits
  32. 05 Dec, 2017 1 commit
  33. 04 Dec, 2017 1 commit
    • luzpaz's avatar
      Misc. typo fixes · e6590119
      luzpaz authored
      This commit removes double whitespace from source comments + fixes some other typos.
      e6590119
  34. 06 Nov, 2017 1 commit
  35. 31 Oct, 2017 1 commit