1. 18 Sep, 2018 2 commits
  2. 17 Sep, 2018 4 commits
  3. 14 Sep, 2018 2 commits
    • Sean McBride's avatar
      Manually reviewed use of 'static int' occurrences · e7d7f32c
      Sean McBride authored
      - Changed some to be const also.
      - Replaced others with call to ClampValue method.
      - Changed some from int to bool.
      - In a couple of cases the variable was unused, removed it.
      e7d7f32c
    • Sean McBride's avatar
      Replaced some uses of vtkMath::Round with STL rounding · 56bf715c
      Sean McBride authored
      vtkMath::Round converts double to int, as opposed to long.  Both can be lossy, but the former much more so.
      
      Replaced some uses with std::round(), some with std::lround().
      
      Eliminated the long->int truncation as much as possible, but kept it in many instances.
      56bf715c
  4. 29 Aug, 2018 1 commit
  5. 14 Aug, 2018 1 commit
  6. 08 Aug, 2018 1 commit
    • Allison Vacanti's avatar
      Fix box widget face highlighting. · 502bc62e
      Allison Vacanti authored
      The actual data was updated correctly in the BoxWidget
      code, but the wrong object was being marked as modified.
      
      The rendering code got smarter at some point and now
      only rebuilds VBOs when the corresponding cell array
      has been modified. Marking the entire polydata as modified
      is no longer sufficient to update the on-device
      representation of the highlighted face.
      
      This patch fixes the BoxWidget so that the active face is
      used for highlighting instead of getting "stuck" on an
      arbitrary face.
      502bc62e
  7. 06 Aug, 2018 1 commit
  8. 01 Aug, 2018 1 commit
    • luz.paz's avatar
      Misc. typos · 0c5f8b4b
      luz.paz authored
      Found via `codespell -q 3 -I ../vtk-whitelist-words.txt --skip="./ThirdParty,./Utilities"`
      0c5f8b4b
  9. 26 Jul, 2018 1 commit
    • Sean McBride's avatar
      Added missing overrides found by cppcheck 1.84 · c0d6d943
      Sean McBride authored
      missingOverride,Examples/GUI/Win32/SampleMFC/SampleDoc.h:47
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:49
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:50
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:52
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:54
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:61
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:62
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:69
      missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:70
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:60
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:61
      missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:62
      missingOverride,IO/ADIOS/FunctionPointers.h:114
      missingOverride,IO/Video/vtkMILVideoSource.h:104
      missingOverride,IO/Video/vtkMILVideoSource.h:243
      missingOverride,IO/Video/vtkMILVideoSource.h:249
      missingOverride,IO/Video/vtkMILVideoSource.h:259
      missingOverride,IO/Video/vtkMILVideoSource.h:79
      missingOverride,IO/Video/vtkMILVideoSource.h:84
      missingOverride,IO/Video/vtkMILVideoSource.h:89
      missingOverride,IO/Video/vtkMILVideoSource.h:94
      missingOverride,IO/Video/vtkMILVideoSource.h:99
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:206
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:219
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:220
      missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:68
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:238
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:239
      missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:66
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:37
      missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:43
      missingOverride,Rendering/OptiX/vtkOptiXCompositePolyDataMapper2Node.h:45,style,The function 'Render' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,Utilities/Benchmarks/GLBenchmarking.cxx:74
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:162
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:164
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:166
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:270
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:273
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:276
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:409
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:414
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:419
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:532
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:534
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:536
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:58
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:60
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:62
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:658
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:660
      missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:662
      missingOverride,IO/ADIOS/ADIOSWriter.cxx:159,style,The function 'GetInt' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:31,style,The function 'ExecVoid' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:50,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:69,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      missingOverride,IO/ADIOS/FunctionPointers.h:90,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
      c0d6d943
  10. 12 Jul, 2018 2 commits
  11. 11 Jul, 2018 1 commit
  12. 06 Jul, 2018 1 commit
  13. 05 Jul, 2018 1 commit
    • Kitware Robot's avatar
      ExternalData: Convert more content links from MD5 to SHA512 · 1d3c8981
      Kitware Robot authored
      Populate a script with `map_<md5>=<sha512>` variable settings and
      then run the following to convert the content link files:
      
          git ls-files -- '*.md5' | while read f; do
            md5="$(cat "$f")"
            sha512="$(eval echo \${map_$md5})"
            rm "$f"
            echo $sha512 > ${f%.md5}.sha512
          done
      
      This follows up commit d6d05b2a (ExternalData: Convert content links
      from MD5 to SHA512, 2018-05-14) to convert content links added in topic
      branches that started before the main conversion.
      1d3c8981
  14. 17 Jun, 2018 2 commits
  15. 25 May, 2018 1 commit
  16. 18 May, 2018 1 commit
    • Kitware Robot's avatar
      ExternalData: Convert content links from MD5 to SHA512 · d6d05b2a
      Kitware Robot authored
      Populate a script with `map_<md5>=<sha512>` variable settings and
      then run the following to convert the content link files:
      
          git ls-files -- '*.md5' | while read f; do
            md5="$(cat "$f")"
            sha512="$(eval echo \${map_$md5})"
            rm "$f"
            echo $sha512 > ${f%.md5}.sha512
          done
      d6d05b2a
  17. 17 May, 2018 1 commit
  18. 15 May, 2018 1 commit
    • Michael Migliore's avatar
      Add capacity to add a point outside of the current polyline · 480a7082
      Michael Migliore authored
      It was only possible to add a point on a current line and move it.
      It is now possible to insert a point everywhere, a line will be created between this point
      and the last existing one.
      The key combinaison is alt + left click.
      The point is pushed before the first point or after the last one depending on previous selection.
      
      Please, note that some window manager (like KDE) already define alt + left click event,
      it must be disabled to use this feature.
      480a7082
  19. 03 May, 2018 1 commit
  20. 30 Apr, 2018 2 commits
    • Cory Quammen's avatar
      Stop drawing line segments outside image buffer bounds · 0f8a17d3
      Cory Quammen authored
      Pixel positions on the zoom box but outside the image buffer bounds
      were potentially being written, which lead to incorrectly drawn lines
      in the best case, segmentation faults in the worst case. Fixed by
      splitting the box drawing into four line segments and using clamped
      pixel positions to avoid this. If a line segment falls entirely
      outside the image buffer bounds, it is not drawn at all.
      0f8a17d3
    • Cory Quammen's avatar
      Use slightly clearer name for variables · 273a59b3
      Cory Quammen authored
      273a59b3
  21. 24 Apr, 2018 1 commit
  22. 10 Apr, 2018 1 commit
  23. 27 Mar, 2018 1 commit
    • luz.paz's avatar
      Misc. Typos · 7b43d4de
      luz.paz authored
      Found via `codespell` and `grep`
      7b43d4de
  24. 26 Mar, 2018 1 commit
  25. 25 Mar, 2018 1 commit
    • Cory Quammen's avatar
      Replace actual PNG baseline image with content link · e34cbecc
      Cory Quammen authored
      An actual PNG baseline image file was introduced in commit
      8e4f2f7c. It's presence caused
      problems with the external data mechanism where each time cmake was
      invoked, the .md5 content link was generated while working on entirely
      unrelated topics.
      e34cbecc
  26. 23 Mar, 2018 1 commit
  27. 21 Mar, 2018 1 commit
    • Johan Andruejol's avatar
      Fix picking through a disabled widget with picking manager on · 8e4f2f7c
      Johan Andruejol authored
      With picking manager on, it was impossible to pick a widget if a disabled
      widget was in front of it.
      To fix this, we have:
        - In the old style widgets (derived only from vtkInteractorObserver), we
      went through all the implementation and added the unregistration/registration
      of the pickers in the SetEnabled() method.
       - In new style widgets (derived from vtkAbstractWidget and
      vtkWidgetRepresentation) the method RegisterPickers and UnRegisterPickers
      have been moved into the representation public API to be able to be called
      by the widget's SetEnabled() method. This allows the widget to register and
      unregisters the pickers as necessary when enabled and disabled.
      
      In both cases we also implemented the SetPickingManaged method as previously
      the PickingManaged property was never used anywhere in the code base.
      Similarly, the PickersModified() method was removed as its purpose seemed
      redundant to SetPickingManaged().
      
      The test TestPickingManagerSeedWidget2 was added to demonstrate/test the
      picking behind a disabled widget.
      
      For more background information, see https://issues.slicer.org/view.php?id=3808Co-Authored-by: Ken Martin's avatarKen Martin <ken.martin@kitware.com>
      Co-Authored-by: Jean-Christophe Fillion-Robin's avatarJean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
      Thanks: Steve Pieper <pieper@bwh.harvard.edu>
      8e4f2f7c
  28. 20 Mar, 2018 2 commits
    • Sean McBride's avatar
      Removed a bunch of double semicolons at the end of lines · 2d148a8f
      Sean McBride authored
      154 occurances of ;;\n
      2d148a8f
    • Sean McBride's avatar
      Applied clang-tidy modernize-use-equals-default fixes · 84ec1d57
      Sean McBride authored
      This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.
      
      There are now some duplicate semis because it did changes like:
      
        ~AMRIndexIterator() override{};
      to
        ~AMRIndexIterator() override= default;;
      
      Note there was a pointless semi before, which clang-tidy didn’t expect / account for.
      
      My next commit will remove them.
      84ec1d57
  29. 15 Mar, 2018 1 commit
  30. 13 Mar, 2018 1 commit
  31. 08 Mar, 2018 1 commit