Merge topic 'fix_dynamic_analysis_issues'

3154b525 fix some dynamic analysis issues
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4535

Common/Transforms/vtkLandmarkTransform.cxx

@@ -179,6 +179,17 @@ void vtkLandmarkTransform::InternalUpdate()
     sb += b[0]*b[0]+b[1]*b[1]+b[2]*b[2];
   }
 
+  // if source or destination is degenerate then only report
+  // translation
+  if (sa == 0.0 || sb == 0.0)
+  {
+    this->Matrix->Identity();
+    this->Matrix->Element[0][3] = target_centroid[0] - source_centroid[0];
+    this->Matrix->Element[1][3] = target_centroid[1] - source_centroid[1];
+    this->Matrix->Element[2][3] = target_centroid[2] - source_centroid[2];
+    return;
+  }
+
   if(this->Mode == VTK_LANDMARK_AFFINE)
   {
     // AAT = (a.a^t)^-1

IO/Exodus/vtkExodusIIWriter.cxx

@@ -1624,19 +1624,31 @@ int vtkExodusIIWriter::CreateSetsMetadata (vtkModelMetadata* em)
     em->SetNodeSetNames (nodeSetNames);
 
     int *nodeSetIds_a = new int[nodeSetIds->GetNumberOfTuples ()];
+    if (nodeSetIds->GetPointer (0))
+    {
       memcpy (nodeSetIds_a, nodeSetIds->GetPointer (0), nodeSetIds->GetNumberOfTuples () * sizeof(int));
+    }
     em->SetNodeSetIds (nodeSetIds_a);
 
     int *nodeSetSizes_a = new int[nodeSetSizes->GetNumberOfTuples ()];
+    if (nodeSetSizes->GetPointer (0))
+    {
       memcpy (nodeSetSizes_a, nodeSetSizes->GetPointer (0), nodeSetSizes->GetNumberOfTuples () * sizeof(int));
+    }
     em->SetNodeSetSize (nodeSetSizes_a);
 
     int *nodeSetNumDF_a = new int[nodeSetNumDF->GetNumberOfTuples ()];
+    if (nodeSetNumDF->GetPointer (0))
+    {
       memcpy (nodeSetNumDF_a, nodeSetNumDF->GetPointer (0), nodeSetNumDF->GetNumberOfTuples () * sizeof(int));
+    }
     em->SetNodeSetNumberOfDistributionFactors (nodeSetNumDF_a);
 
     int *nodeIds_a = new int[nodeIds->GetNumberOfTuples ()];
+    if (nodeIds->GetPointer (0))
+    {
       memcpy (nodeIds_a, nodeIds->GetPointer (0), nodeIds->GetNumberOfTuples() * sizeof(int));
+    }
     em->SetNodeSetNodeIdList (nodeIds_a);
 
     em->SetNumberOfSideSets (numSideSets);
@@ -1644,23 +1656,38 @@ int vtkExodusIIWriter::CreateSetsMetadata (vtkModelMetadata* em)
     em->SetSideSetNames (sideSetNames);
 
     int *sideSetIds_a = new int[sideSetIds->GetNumberOfTuples ()];
+    if (sideSetIds->GetPointer (0))
+    {
       memcpy (sideSetIds_a, sideSetIds->GetPointer (0), sideSetIds->GetNumberOfTuples() * sizeof(int));
+    }
     em->SetSideSetIds (sideSetIds_a);
 
     int *sideSetSizes_a = new int[sideSetSizes->GetNumberOfTuples ()];
+    if (sideSetSizes->GetPointer (0))
+    {
       memcpy (sideSetSizes_a, sideSetSizes->GetPointer (0), sideSetSizes->GetNumberOfTuples() * sizeof(int));
+    }
     em->SetSideSetSize (sideSetSizes_a);
 
     int *sideSetNumDF_a = new int[sideSetNumDF->GetNumberOfTuples ()];
+    if (sideSetNumDF->GetPointer (0))
+    {
       memcpy (sideSetNumDF_a, sideSetNumDF->GetPointer (0), sideSetNumDF->GetNumberOfTuples() * sizeof(int));
+    }
     em->SetSideSetNumDFPerSide (sideSetNumDF_a);
 
     int *sideSetElementList_a = new int[sideSetElementList->GetNumberOfTuples ()];
+    if (sideSetElementList->GetPointer (0))
+    {
       memcpy (sideSetElementList_a, sideSetElementList->GetPointer (0), sideSetElementList->GetNumberOfTuples() * sizeof(int));
+    }
     em->SetSideSetElementList (sideSetElementList_a);
 
     int *sideSetSideList_a = new int[sideSetSideList->GetNumberOfTuples ()];
+    if (sideSetSideList->GetPointer (0))
+    {
       memcpy (sideSetSideList_a, sideSetSideList->GetPointer (0), sideSetSideList->GetNumberOfTuples() * sizeof(int));
+    }
     em->SetSideSetSideList (sideSetSideList_a);
   }
   return 1;