GitLab

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

Add an option to Ready a shader program based on a vector of shaders

Rename some functions to match what they do

Cleanup some memory leaks in the LIC code

vtkgl::CellBO renamed vtkOpenGLHelper
vtkgl::substitute moved to vtkShaderProgram::Substitute
Creation of vtkOpenGLIndexBufferObject
Creation of vtkOpenGLVertexBufferObject
Move methods that were in vtkglVBOHelper into new classes
Move IndexCount from CellBO to vtkOpenGLIndexBufferObject
etc

As we get closer to a next VTK release, make sure this is
fairly clean or at least cleaner than it was.

GPUVolume rendering was activating texture units and never
deactivating them.  The TextureUnitManager was allowing this
when it should not have been.

GenericCompoistePolyDataMapper was not releasing graphics
resources on its helper.

Added in some opengl error reporting logic that someone had added
to only the old backend.

DepthPeeling was not releasing all of its graphics resources.

Removed a couple extra includes.

Added a MakeCurrent in TextureObject when it releases its
graphics resources. Sometimes this happens when another window
is current as a side effect.

Change-Id: I19b5acbec07a1ee4493876e9fedbda2befe749ad

Convert depth peeling render pass to the OpenGL2 backend.
Also add a new class that encapsulates the basic rendering
steps that VTK uses.

Modify the renderer to use the depth peeling pass instead of
having two copies of the code lying around. Removed the depth
peeling code from Mapper2D as it is no longer needed now that we
have CopyToFrameBuffer working. That is a lighter weight way to
get a quad up on the screen. Plus that keeps the depth peeling
code more localized as it should be. Clean up a lot of depth
peeling code that was in the renderer and now there are cleaner
ways of doing it (passing information keys).

Change-Id: I8d0a53bb25920bd30eade49ed12126b9b44be358

Add in a bunch of render pass classes that were previously removed.
At the same time get the GaussianBlurPass and SobelGradientMagnitude
classes to work with the new backend.
This code now exercises a few methods that previously were not
previously exercised. As such I made some significant changes to those
methods to make them fit in better with the new architecture.

In the process of testing I did find a calculation error in the old
code related to cmoputing camera angles. I fixed this issue in both the
old and new rendering backend.

The tests for these passes were modified to not use the DepthPeelingPass
as that pass has not been converted yet.

Change-Id: Ie40231385291aa06848034460817b171e60f7a53

In other words, changed from the C to the C++ header name.
Did this only in .cxx files, and not in ThirdParty.

Change-Id: I81e2b2c7f2db00e98b37d507232fbc84022e8d8f

This patch implements OpenGL error checking in VTK.

OpenGL's error handling implementation error is designed such
that internal error flags remain set with the first error that
occurred until they are explicitly checked. With this design
it's important to check and clear the error flags regularly
else they become unusable as code checking for errors ends
up reporting earlier undetected unrelated errors.

This patch takes the following approach:

1) at public entry points into code that uses OpenGL clear the
error flags without reporting errors. This guards against
reportinig unrealted errors, such as those caused by code
outside of VTK. See vtkOpenGLClearErrorMacro

2) before returning from functions that made OpenGL calls check
for and report OpenGL errors. This detects Open GL errors in the
function/method where they occurred facilitating debugging and it
clears error flags so that user code doesn't detect errors caused
by VTK. See vtkOpenGLCheckErrorMacro

This patch cleans up a number of bugs that were detected by
the new error checking and reporting.

This patch also contains improvements for OpenGL pixel buffers, a
renderbuffer object, and fast paths through framebuffer objects,
and texture objects, and fast path for setting uniform variables,
all of which are needed in vtkSurfaceLICPainter and
vtkLineIntegralConvolution2D GPGPU code.

Change-Id: I4ecefe9a444a74128bf73ef2ddfd5d4acea387ec

Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
are maintained outside VTK.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>

Move source files from their former monolithic VTK location to their new
location in modular VTK without modification.  This preserves enough
information for "git blame -M" and "git log --follow" to connect
modularized VTK files to their original location and history.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>
Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

BUG:Another attempt to fix a clean rejection of an OpenGL implementation supporting FBO but not supporting the requested format.

BUG:Attempt to fix the case where FBO extension is supported by the requested FBO format is not as for SINTEF.LabMAC.OSX/VTKCvs_CMake262Carbon_gcc401_Qt443.

ENH:Re-factor common code of vtkGaussianBlurPass and vtkSobelGradientMagnitudePass into a new abstract class vtkImageProcessingPass.

ENH:Simplify copying of a subrectangle of a texture into a subrectangle of a framebuffer with new method vtkTextureObject::CopyToFrameBuffer().

BUG:Fixed artefact at the border by rendering first in an image with a number of extra pixels related to the kernel size.