GitLab

Neither was needed as they were both empty and did nothing - the
compiler generated destructor can do this and it fixes the Clang++
warnings on the dashboards.

Change-Id: If5bbaa77669058c82f8ad6a66256a9b712aa753e

The prefix spaces generate bad looking (code citing mode)
doxygen description.
http://www.vtk.org/doc/nightly/html/classvtkOctreePointLocator.html#details

Change-Id: I2e11aad40ec178b54100a96ffeeb0fd9b1df9ce6

Change-Id: I216f6646c173063ccc1e4b36f4af6899b240f335

Thanks Henning Meyer for the report and patch.

Change-Id: I4771589acd8e927bc96ada7f9ab32664042ae296

@thanks Mathieu Westphal for the report and patch

Change-Id: Ibd210e5456955d10f21443e853c299f07731b7c9

Change-Id: I2edeb9e78066aa766e47ba37af92ddcbfe75a436

Add to the Testing/Data directory ExternalData content links mirroring
the content and layout we use from the VTKData/Data directory.

Add a CMake/vtkLegacyData.cmake module, included from CMakeLists.txt and
Testing/External/CMakeLists.txt, to call ExternalData_Expand_Arguments
for all data directories added from VTKData/Data.  This will bulk-fetch
all test input data currently used by tests of any module, enabled or
not.  We can make the DATA{} references more granular later.

Add a VTK_TEST_DATA_DIR variable to refer to the directory we tell the
ExternalData module to populate the real data files.  Replace references
to VTK_DATA_ROOT in test command lines (after -D) with references to
VTK_TEST_DATA_DIR.  Drop the VTK_DATA_ROOT CMake option and stop using
the VTKData repository.

Remove the TESTING_DATA option from the vtk_add_test_cxx API and remove
the VTK_DATA_ROOT option from the vtk_add_test_mpi API since all test
input data are now handled through ExternalData and Testing/Data content
links.

Change-Id: Id02490b76ea2e161b9038188264a4830485039d8

Change-Id: I08fa5337157eda3867866956833ff80445ab70b5

The VTKData repository no longer holds Baseline directories so drop
references to such directories from the VTK source tree:

* Replace the default -V in CMake/vtkTestingRenderingDriver.cmake with a
  value that will fail but indicate what to do.  All current uses of
  this module have an explicit -V so the default should never be used.

* Drop a few leftover Baseline directory references from comments in
  "*/*/Testing/*/CMakeLists.txt".

* Remove boilerplate duplicate test command-line examples (that
  reference Baseline directories) from *.py tests and leave an updated
  example in "Wrapping/Python/README.txt".  The command-line example
  convention was added long before the modern CTest infrastructure
  and is no longer needed anyway.

Change-Id: I3001e99b3cc8c2717107e61b3b7f988caeb49cab

Baseline images are now referenced by ExternalData content links stored
directly in each module source tree.  Drop the old VTKData baseline
subdirectory name from the vtk_add_test_* signatures.

Change-Id: I5bdc7a5bf87fc7c8fa77dcd50b79f2f54d6eba31

Change-Id: I7c6ab523d022f28256bb9d29e23ebacbcf6eafdd

Convert some direct add_test calls to use the helper functions instead.

Change-Id: I4f6b92e24804885c6b1449b21ae8efffd22ffdbf

Refactor */*/Testing/Cxx/CMakeLists.txt to use the vtk_add_test_cxx
function instead of direct add_test calls.

Change-Id: I73dee627fa87a399c48b409af046b116fc75a0fd

Use shell code:

 git grep -Elz '\<add_test_(mpi|python|tcl)' |
 xargs -0 sed -ri 's/\<add_test_(mpi|python|tcl)/vtk_add_test_\1/g'

Change-Id: I6d076e2483209a83231fb1c96053f0389a3fcdf2

Teach add_test_(python|tcl) to parse explicit NO_DATA, NO_RT, NO_VALID,
and NO_OUTPUT keyword options for tests that do not need VTK_DATA_ROOT
or do not use a valid baseline image.  Factor add_test_python1 into
add_test_python and distinguish them with the NO_RT keyword argument.
Update call sites to produce identical test command lines before and
after this change.

Change-Id: I09f874b26aab409e55e7aa6f92412314540dbb85

This has been done by removing the "tcl-isms" and making
 the code more readable. In some cases redundant code
 has been removed (often a result of copy/paste operations).
 The code has also been checked to ensure each line is 80
 characters or less.

The code can now be run using vtkpython or by using the
 appropriate Python environment.

Originally these were TCL scripts that were converted using
  vtkTclTestToPy.py and they they needed to be run through the
  rtImageTest.py driver which defines a few needed
  functions/variables for their operation. To this end
  backdrop.py has been added where it is needed.

Change-Id: I50d6505628c140ea4551f74f7f3e85df907567e1
Signed-off-by: Andrew Maclean <andrew.amaclean@gmail.com>

Change-Id: I009d1ad6cce60a1a3b319797c4d6a76206deb2b8

The value "6" was probably meant to be "0.6",
as it seems HSV ranges should be 0 to 1.

Fixes undefined cast of large double to uint8
found by clang's ubsan.

Change-Id: I18120efe1638e2c175e8ba439941b7023f906a65

Change-Id: I30c2ba92d542f3ab62c5de9d47e5a4cce3d7e785

Change-Id: I25be3f3329ab9a228865c64caaf7dfea287fd049

Removed garbage collection related Register/UnRegister/
ReportReferences calls from classes that did not need them.
Using garbage collection unnecessarily can lead to
performance issues.

Change-Id: I2eefb6a86d9e64f898247df522a6082c07cec8aa

HT are now indexed in such a way that there is no more
dead index.
HTGSource in quadric mode use the GlobalIndexStart mode to
avoid the storage of the local to global node id per tree
(contrary to descriptor/mask sources which use a BSF global
indexing mode, quadric nodes are numberered on a per-tree
basis).

Also remove some no more used functions and vars.

Change-Id: Ie5fe5f267a22706334d883d330b8aa9bbb3926e2

When tests are run with -I they must be linked with InteractionStyle.

On the Mac, tests must be linked with MACOSX_BUNDLE to get keyboard
focus.

Change-Id: I938c4b6a5a44ca5792f5eeaaa946cc9fb27e1110

This global breadth-first search let the user access to point
data in the same order as in the descriptor which describes
the tree representation in BFS.
Moreover, each tree node (even non-leaf ones) can now have
data attached. As previously, the dual only address the tree
leaves.
Updating source, filters and tests to take advantage of this
new behaviour.

Change-Id: I4998336e38cc2d5cf79ec50e51ecc877cb74077e

Change-Id: I39e122bceb53baaff0bc1dd5faed056a0d03ce7a

Change-Id: I6e74e5120c900b5d6c8b69a33c4c149e45d5e6d8

Change-Id: Ib73de685956f4ef4d2b9dfb9ce8e4561ae9df945

- Replace the vtkCollection which has a find access in O(N) by a std::map.

- Add vtkHyperTreeIterator to avoid browsing every potential tree of
level 0 grid. Only available trees are now browsed.

- Add a TimeStamp to avoid unnecessary calls to the costly
UpdateHyperTreesLeafIdOffsets.

Those 3 changes really improve the computation time for building the HTG
but also for computing the dual and all the filters
(AxisCut, Geometry & ToUnstructuredGrid).

Also add points for each cell in the tree, not only for leaf, even if
only leaf points are used to construct the dual and thus referenced by
some cells.

Change-Id: Ie954fdc8860a55d0de9c23097b0662a2d2123550

Change the HyperTreeGrid mechanisms to provide efficient storage of very
large level 0 grids with only few cells defined. Instead of creating a
full grid array, only defined cells (through MaterialMaskIndex array)
are stored and processed.
The source has been updated to take advantage of this new feature.

Some optimizations and code simplification are also provided.

Provide a new test TestHyperTreeGridTernary3DGeometryLargeMaterialBits
to test the large grids management.

Set 3: Fix tests, mainly fix CopyStructure.

Change-Id: Iaab0afd7d13e66d9ab105c554a4d873ab59f1d35

This commit renders user-provided notes associated with specific
scalar values on the interval-mode scalar bar. Previously, only
the categorical mode rendered these annotations.

Also, provide the scalar bar with an optional swatch
to illustrate the color assigned to NaN values.

Add an option to color leader lines from the scalar bar to
the annotation labels by the corresponding scalar value.

This commit also breaks the process of rebuilding the scalar bar
into several virtual methods so that subclasses (particularly
ParaView's `vtkPVScalarBarActor`) can reuse more of the base class
functionality. The process is now separated into 2 phases: layout,
where bounding boxes for scalar bar components are placed; and
configuration, where actors are positioned and geometry is created.
This includes some changes to text actor to support constrained
placement and text size queries.

Add a test for the new scalar bar options.
There are now many more options controlling how the scalar bar behaves.
In particular many settings interact with the way geometry is rendered:
the lookup table may be indexed or not (thus tick marks may not be
rendered); the orientation may be horizontal or vertical; annotations
may be rendered or not; the NaN annotation may be omitted; leader lines
to annotations may be colored by the scalar they annotate or by the label
color; and the tick marks may precede or succeed the scalar bar.
Also, we must test how empty labels are handled and how even vs odd
numbers of labels affect placement (since the algorithm for placement
behaves differently in these cases).

We cannot perform a full factorial test, but do test independent
configurations.

Finally, this commit improves the performance of prominent value
detection for primitive-type arrays (e.g., int, double) by avoiding
the use of vtkVariant instances to hold the working set of distinct
values during sampling.

Change-Id: I852f9b497d5e6ab619d9d7b763f641c44e4869cf

Fixed by adding 'static' and/or 'const' to several
variables that had neither.

Removed one obsolete comment too.

Change-Id: I8775c9a1fa8d9cc75b28619216bbe7f901117a0f

Assume that if _MSC_VER is defined that it is >= 1310
(ie VS7.1).

This improves the readability of the code, and slightly
improved code coverage.

Change-Id: Iffc601f4cff53c4e267835e39b2b17a3adf74494

Shifting a 1 bit into or past the sign bit is undefined behaviour.
Instead, just use the new VTK_ID_MIN constant.

Change-Id: If58da9863e2264c886957d214aa4086e4fb25c81

I was using a tolerance of 0.001 near the apex of the pyramid
relative to a distance squared for the interior check but elsewhere
I was doing a tolerance of 0.001 for the absolute value of
the distance so I squared the 0.001 tolerance to be consistent
with the interior check for the other parts of the cell.
Note that due to the degenerate nature of the pyramid cell we
do a specialized interior check near the apex.
Thanks to Kathleen S. Biagas for the bug report and fix.

Change-Id: I7580fa04539b159ceac12385e2ac3d795906dc01

Change-Id: I6869fef6042d5249be98c3c0c3337491936276c1

It appears nowhere else in the file,
but an identical macro appears in many other places,
making me think this is leftover copy-paste.
Found this dead code using -Wunused-macros.

Change-Id: Ib8ac3d8c4eb756b04147f7dcd029a0e8c75c0869

It appears nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: Ifbf09b46a7de7952e9961521726dda6c2c92100a

They appear nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: I0100e6d427cc762abc3ba734e7609998ea9759c2

It appears nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: I1cbd97cd6905b5fd8dae878ef1a099522b9153e8

It appears nowhere else in the codebase. Found this dead code using -Wunused-macros.

Change-Id: I66bc2a2ebab4c3e69aa47b9808b57926e50163bc