1. 28 Jul, 2013 2 commits
  2. 26 Jul, 2013 1 commit
  3. 25 Jul, 2013 2 commits
    • David Thompson's avatar
      Change `vtkScalarsToColors::SetAnnotations` behavior. · 06ef3b9e
      David Thompson authored
      Now SetAnnotations performs a deep copy of annotations
      rather than referencing the provided array pointers.
      This addresses ParaView bug 14189, where changes to the
      array after SetAnnotations were not being reflected in
      the map.
      
      Change-Id: I8e78b30a5757eb9429dd5e02c9126cb5c01892c5
      06ef3b9e
    • Shawn Waldon's avatar
      Fixed reference counting bug in vtkTransform · b47332bb
      Shawn Waldon authored
      There was a reference counting error in vtkTransformConcatenation when
      a transform was DeepCopy'ed and shortened and then DeepCopy'ed and lengthened
      using some of the same concatenated transforms.
      
      When the list of concatenated transforms was shortened, the values
      were not cleared out, letting pointers in the list that did not have a reference
      according to the reference counting.  Later, when the list was set to a larger
      list again and happenned to have the same transform at postion x, since there
      was already a reference to the transform in the list, it did not increment
      the reference count even though it should have.  This commit fixes this
      by setting pointers beyond the end of the list to NULL when DeepCopy shrinks the list.
      
      This commit also adds a regression test for that will segfault unless the
      bug is fixed due to a reference count that is accidentally decremented in
      a loop due to the bug. Running this test without this patch will segfault.
      
      Change-Id: I27d7c2097f85a2f8c1d6e8a0e8213d041cc83125
      b47332bb
  4. 24 Jul, 2013 1 commit
    • Zack Galbreath's avatar
      resolve new warning · 080a7f72
      Zack Galbreath authored
      This commit eliminates the following warning:
        warning C4018: '<' : signed/unsigned mismatch
      
      Change-Id: I3dc5f506e5b08ea6365d71487c5b39364faabec3
      080a7f72
  5. 23 Jul, 2013 1 commit
    • Zack Galbreath's avatar
      change MAX_DISCRETE_VALUES into an ivar · 02ffb7ac
      Zack Galbreath authored
      Change MAX_DISCRETE_VALUES from a hardcoded value of 32 to a user-
      settable ivar.  This allows users of vtkAbstractArray to generate
      a categorical color map for data sets containing more than 32
      discrete values.
      
      For backwards compatibility, we keep the MAX_DISCRETE_VALUES enum
      and use it to initialize MaxDiscreteValues.  This enum is marked
      as deprecated.
      
      Change-Id: I83bf7c598288dc28a4ad231778c66e1571e3a461
      02ffb7ac
  6. 22 Jul, 2013 3 commits
    • Dave DeMarle's avatar
      BUG:0012144 correct the documentation for GetArrayIndex · 736a4ade
      Dave DeMarle authored
      Per bug # 0012114, the documentation was wrong.
      
      Change-Id: I4386cc01edc6f84f9ca1aa2a02d19ff61d1d4bdf
      736a4ade
    • David Gobbi's avatar
      COMP: Clear VTK_HAS_STD_ISFINITE and related variables. · f1760ede
      David Gobbi authored
      The cmake variables VTK_HAS_STD_ISFINITE, VTK_HAS_STD_ISNAN, and
      VTK_HAS_STD_ISINF were set incorrectly prior to commit c4b4eb3b,
      and the incorrect settings are stuck in the CMakeCache.txt of many
      machines (and will be until they clear their cache).  So this commit
      specifically removes those variables from the cache, in order to
      allow the correct checks to be done.  This commit will be reverted
      after one week.
      
      Change-Id: I27073fbe199957a551c65c090313d74a850b28db
      f1760ede
    • David Gobbi's avatar
      14164: Fix incorrectly set VTK_HAS_STD_ISFINITE variable. · f808e0c6
      David Gobbi authored
      This change is necessary for compilation with gcc in C++11 mode.
      
      The check_symbol_exists() macro that we had been using to find
      std::isfinite, std::isnan, and std::isinf always failed, so it
      wasn't doing anything useful.  Both this macro and the newer
      check_cxx_symbol_exists() are unsuitable for std::isfinite etc.
      because these function might exist either as function templates,
      or as simple function overloads, depending on the compiler.
      
      As a side note, the existing checks for the c99 functions, e.g.
        cmake_symbol_exists(isnan "math.h" VTK_HAS_ISNAN)
      should instead use this:
        cmake_cxx_symbol_exists(isnan "cmath" VTK_HAS_ISNAN)
      because vtkMath.h includes cmath, not math.h, and on some systems
      math.h provides these function while cmath does not (or, cmath
      might only provide them within the std namespace).  In fact, most
      instances of cmake_symbol_exists() in VTK should be replaced by
      cmake_cxx_symbol_exists() when VTK adopts a more recent CMake.
      
      Change-Id: I1ef7cd4daa52067badb0928d01c3f8b22953c601
      f808e0c6
  7. 11 Jul, 2013 1 commit
    • Kyle Lutz's avatar
      Add asserts to vtkDataArrayTemplate Set/GetValue() · bc424e27
      Kyle Lutz authored
      This adds asserts which will trigger when invalid indices are
      pass to the GetValue() and SetValue() methods in the
      vtkDataArrayTemplate class. This causes tests which access invalid
      elements of a vtkDataArray to fail with an assert. Previously these
      types of errors would only be found by valgrind.
      
      Change-Id: I0bfc7de1453c871b55cfe87fba43f9095684fbee
      bc424e27
  8. 05 Jul, 2013 1 commit
  9. 02 Jul, 2013 1 commit
  10. 28 Jun, 2013 2 commits
  11. 25 Jun, 2013 1 commit
  12. 24 Jun, 2013 1 commit
    • Dave DeMarle's avatar
      fix a memory leak · 9364db58
      Dave DeMarle authored
      @thanks Mathieu Westphal for the report and patch
      
      Change-Id: Ibd210e5456955d10f21443e853c299f07731b7c9
      9364db58
  13. 05 Jun, 2013 1 commit
    • Sven Buijssen's avatar
      Fix typos · 5ef33d3b
      Sven Buijssen authored
      Change-Id: I2edeb9e78066aa766e47ba37af92ddcbfe75a436
      5ef33d3b
  14. 04 Jun, 2013 1 commit
    • Brad King's avatar
      Convert VTKData test inputs to ExternalData content links · 3797f83d
      Brad King authored
      Add to the Testing/Data directory ExternalData content links mirroring
      the content and layout we use from the VTKData/Data directory.
      
      Add a CMake/vtkLegacyData.cmake module, included from CMakeLists.txt and
      Testing/External/CMakeLists.txt, to call ExternalData_Expand_Arguments
      for all data directories added from VTKData/Data.  This will bulk-fetch
      all test input data currently used by tests of any module, enabled or
      not.  We can make the DATA{} references more granular later.
      
      Add a VTK_TEST_DATA_DIR variable to refer to the directory we tell the
      ExternalData module to populate the real data files.  Replace references
      to VTK_DATA_ROOT in test command lines (after -D) with references to
      VTK_TEST_DATA_DIR.  Drop the VTK_DATA_ROOT CMake option and stop using
      the VTKData repository.
      
      Remove the TESTING_DATA option from the vtk_add_test_cxx API and remove
      the VTK_DATA_ROOT option from the vtk_add_test_mpi API since all test
      input data are now handled through ExternalData and Testing/Data content
      links.
      
      Change-Id: Id02490b76ea2e161b9038188264a4830485039d8
      3797f83d
  15. 03 Jun, 2013 1 commit
    • David Gobbi's avatar
      ENH: Faster low-level implementation for TransformPoints. · 3c1ef1a4
      David Gobbi authored
      The vtkTransform's TransformPoints() method iterated through the
      points using GetPoint() and InsertNextPoint(), both of which require
      virtual method calls to vtkPoints' internal vtkDataArray. This patch
      eliminates all per-point virtual method calls by typcasting to float
      or double before looping through the points.
      
      Change-Id: Ieabef02cddb6a3290a31315c8d5baf268dacc079
      3c1ef1a4
  16. 31 May, 2013 1 commit
  17. 23 May, 2013 1 commit
    • Brad King's avatar
      Remove references to old VTKData/Baseline directories · fc5d874c
      Brad King authored
      The VTKData repository no longer holds Baseline directories so drop
      references to such directories from the VTK source tree:
      
      * Replace the default -V in CMake/vtkTestingRenderingDriver.cmake with a
        value that will fail but indicate what to do.  All current uses of
        this module have an explicit -V so the default should never be used.
      
      * Drop a few leftover Baseline directory references from comments in
        "*/*/Testing/*/CMakeLists.txt".
      
      * Remove boilerplate duplicate test command-line examples (that
        reference Baseline directories) from *.py tests and leave an updated
        example in "Wrapping/Python/README.txt".  The command-line example
        convention was added long before the modern CTest infrastructure
        and is no longer needed anyway.
      
      Change-Id: I3001e99b3cc8c2717107e61b3b7f988caeb49cab
      fc5d874c
  18. 20 May, 2013 1 commit
    • Andrew Maclean's avatar
      Make some color methods consistent. · 293e5386
      Andrew Maclean authored
      In order to use functions like SetTableValue(2, "Blue") in a lookup table
        or other SetColors in derived classes in the same manner,
        these methods should be virtual.
      This commit just makes the relevant Set methods virtual.
      In the case of vtkProperty, the definition of SetColor(double a[3]) has
        been moved into vtkProperty.cxx, the rationale is that, in VTK classes,
        definitions occur in the implementation file not the header file.
      
      Change-Id: I89fee8eb4902e0847114b068374c3bff0bf10b9d
      293e5386
  19. 19 May, 2013 1 commit
    • Bill Lorensen's avatar
      DOC: Fix clang warning unknown command tag name · 07e37872
      Bill Lorensen authored
      Replace back-slash prefix for doxygen command with at-sign prefix.
      This may eliminate the clang warning. at-sign seems to be the
      preferred doxygen command prefix in VTK.
      
      Change-Id: I2dbbff11a5c531f2dad0a231b7cb0bc1ed7ad66c
      07e37872
  20. 17 May, 2013 2 commits
  21. 16 May, 2013 1 commit
    • Andrew Maclean's avatar
      Make some color methods consistent. · 55475274
      Andrew Maclean authored
      
      
      In order to use functions like SetTableValue(2, "Blue") in a lookup table
        or other SetColors in derived classes in the same manner,
        these methods should be virtual.
      This commit just makes the relevant Set methods virtual.
      In the case of vtkProperty, the definition of SetColor(double a[3]) has
        been moved into vtkProperty.cxx, the rationale is that, in VTK classes,
        definitions occur in the implementation file not the header file.
      
      Change-Id: I6ad8d0019785faed1f7cb157192fdcc2f2d70c34
      Signed-off-by: Andrew Maclean's avatarAndrew Maclean <andrew.amaclean@gmail.com>
      55475274
  22. 14 May, 2013 4 commits
  23. 13 May, 2013 1 commit
    • Brad King's avatar
      vtkTestingMacros: Generalize add_test_(python|tcl) · 52b51415
      Brad King authored
      Teach add_test_(python|tcl) to parse explicit NO_DATA, NO_RT, NO_VALID,
      and NO_OUTPUT keyword options for tests that do not need VTK_DATA_ROOT
      or do not use a valid baseline image.  Factor add_test_python1 into
      add_test_python and distinguish them with the NO_RT keyword argument.
      Update call sites to produce identical test command lines before and
      after this change.
      
      Change-Id: I09f874b26aab409e55e7aa6f92412314540dbb85
      52b51415
  24. 08 May, 2013 1 commit
    • Yumin Yuan's avatar
      Fix the failing tests on AIX Dashboard. · 246d6ead
      Yumin Yuan authored
      On AIX, the behavior of istringstream operator(>>) is undefined if the
      stream already reached eof. All other dashboards can handle this
      case properly with no action. The fix is to add eof check before this
      operator in vtkVariant.cxx.
      
      Change-Id: Icbd8cae9988d0109908a9614c6bf07a2c223ae93
      246d6ead
  25. 07 May, 2013 1 commit
  26. 06 May, 2013 1 commit
    • David Thompson's avatar
      Fix a ParaView crash related to prominent values. · 78ae5168
      David Thompson authored
      When running with multiple processes, ParaView distributes unique
      values to all processes, even when the dataset does not reside on
      some processes. Ensure that the information object is properly
      populated in this case.
      
      Change-Id: Id576c81f95b8b27037287d1d5967955235c7130a
      78ae5168
  27. 28 Apr, 2013 1 commit
    • Andrew Maclean's avatar
      These Python tests have been refactored. · 3810c5a6
      Andrew Maclean authored
      
      
      This has been done by removing the "tcl-isms" and making
       the code more readable. In some cases redundant code
       has been removed (often a result of copy/paste operations).
       The code has also been checked to ensure each line is 80
       characters or less.
      
      The code can now be run using vtkpython or by using the
       appropriate Python environment.
      
      Originally these were TCL scripts that were converted using
        vtkTclTestToPy.py and they they needed to be run through the
        rtImageTest.py driver which defines a few needed
        functions/variables for their operation. To this end
        backdrop.py has been added where it is needed.
      
      Change-Id: I50d6505628c140ea4551f74f7f3e85df907567e1
      Signed-off-by: Andrew Maclean's avatarAndrew Maclean <andrew.amaclean@gmail.com>
      3810c5a6
  28. 26 Apr, 2013 1 commit
  29. 25 Apr, 2013 2 commits
  30. 24 Apr, 2013 1 commit