1. 20 Mar, 2018 1 commit
    • Sean McBride's avatar
      Applied clang-tidy modernize-use-equals-default fixes · 84ec1d57
      Sean McBride authored
      This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.
      
      There are now some duplicate semis because it did changes like:
      
        ~AMRIndexIterator() override{};
      to
        ~AMRIndexIterator() override= default;;
      
      Note there was a pointless semi before, which clang-tidy didn’t expect / account for.
      
      My next commit will remove them.
      84ec1d57
  2. 15 Dec, 2017 1 commit
    • luz.paz's avatar
      Uniformity and several typo fixes · 17a8bc23
      luz.paz authored
      Mostly removing superflous double whitespace on both user-facing and non-user-facing strings. Some misc. typo fixes sprinkled in as well.
      17a8bc23
  3. 26 Jul, 2017 1 commit
    • Kitware Robot's avatar
      Replace many NULL and 0 occurances with nullptr · a855cab0
      Kitware Robot authored
      This topic is the result of running clang-tidy to
      modernize our usage of NULL and 0 to nullptr. It also
      includes some manual and semi manual changes where
      clang-tidy would not be expected to work (such as in
      comments, or classes not compiled on this build)
      
      There are definitely many comments and occurances that
      this topic misses that we will need to fix over time.
      a855cab0
  4. 19 Dec, 2016 1 commit
  5. 25 Oct, 2016 1 commit
  6. 23 Sep, 2016 1 commit
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      Utilities/Maintenance/vtk-reindent-code.py
      
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      
      The bash command line used was the following:
      
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
        done
      done
      f830ff47
  7. 08 Mar, 2016 1 commit
  8. 13 Jan, 2016 1 commit
    • Sean McBride's avatar
      Introduced additional clamping method to vtkMath · 63d03478
      Sean McBride authored
      This allows removing other clamp macros in various files,
      which caused clang-tidy misc-macro-parentheses warnings,
      due to their lacks of parens in the macro implementations.
      It was also an unneeded duplication of code.
      
      Added asserts to some of the various clamping methods
      to confirm that min <= max.  Some of them had these asserts
      already, now all do.
      
      Also searched and replaced some identical clamp functions
      in various places.
      
      Added unit test.
      63d03478
  9. 16 Feb, 2015 1 commit
  10. 06 Aug, 2014 1 commit
    • Ben Boeckel's avatar
      warnings: use floating point intermediate values · 37aad40d
      Ben Boeckel authored
      When calculating values which are, at the end, integers, the
      intermediate values may have some nuance to them where floating point
      can help precision.
      
      Change-Id: I4b9cd14f80b74200ae4fde1369a51c5d4275cd18
      37aad40d
  11. 03 Apr, 2014 1 commit
    • Dave DeMarle's avatar
      fix variety of dashboard problems · 0adb5f1a
      Dave DeMarle authored
      Try to silence what looks like a spurious warning.
      "nonstandard extension used : 'm' : loop control variable declared in the for-loop is used outside the for-loop scope;"
      
      increase tolerance on crossproduct test for AIX machine where:
      "
      Cross expected -1.47137 but got -1.47137eps ratio is: -1
      Cross expected -1.17442 but got -1.17442eps ratio is: 1
      ...
      "
      which looks like numeric_limits<double> is funky
      
      Fix more cases where int and long appear to be the same thing
      and we get:
      "
      Bad fitting range for VTK_LONG
       Expected 8 but got 6
      Bad fitting range for VTK_UNSIGNED_LONG
       Expected 9 but got 7..FAILED
      "
      
      Change-Id: I735a760941ccb4db3d647462104d086dee8a5a3d
      0adb5f1a
  12. 14 Mar, 2014 1 commit
    • Bill Lorensen's avatar
      COMP: Adjust tolerances · 77483595
      Bill Lorensen authored
      Some tests need tolerance adjustments oon various platforms.
      
      Also, removed deprecated method tests to avoid warnings.
      
      Change-Id: I92e43e8e52ecd8e608d533aaa00890bac4b53cbf
      77483595
  13. 13 Mar, 2014 1 commit
    • Bill Lorensen's avatar
      ENH: Unit test for vtkMath · 5988b551
      Bill Lorensen authored
      A comprehensive test for vtkMath.
      
      This UnitTest provides 86% coverage for vtkMath. When combined with
      TestMath, the total coverage comes to over 96%. The remaining untested
      lines are special cases that I have not been able to exercise.
      
      During the test creation process, these bugs were found:
      
      NextCombination() always returned after one interation.
      
      Memory leak in SolveLeastSquares
      
      Change-Id: I22dfd2198e52f8980445e0ba5e951f811700af16
      5988b551