GitLab

This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.

There are now some duplicate semis because it did changes like:

  ~AMRIndexIterator() override{};
to
  ~AMRIndexIterator() override= default;;

Note there was a pointless semi before, which clang-tidy didn’t expect / account for.

My next commit will remove them.

This topic is the result of running clang-tidy to
modernize our usage of NULL and 0 to nullptr. It also
includes some manual and semi manual changes where
clang-tidy would not be expected to work (such as in
comments, or classes not compiled on this build)

There are definitely many comments and occurances that
this topic misses that we will need to fix over time.

`vtkXMLPUnstructuredDataReader::CopyOutputInformation()` was not copying
`CAN_HANDLE_PIECE_REQUEST()` key correctly (missed in ac6f1854).
As a result, we were seeing paraview/paraview#17028. This addresses that issue.

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

The way algorithms were updated (made to execute) with
request meta-data (such as update extent) was very error
prone and counter-intuitive. Added new methods to make
updating with meta-data easier. I also deprecated a number
of methods to set request meta-data. This will encourage
developers to migrate to the new API which is less error-
prone.

Change-Id: Id5b760ed9b3842284daf45ea1551f2759301efb3

It made more sense to have both CAN_PRODUCE_SUB_EXTENT and
CAN_HANDLE_PIECE_REQUEST in vtkAlgorithm.

Change-Id: Ie64bb3e7c8417113bfb7f677c10d8feb5fdddc39

Change-Id: Id76d3bc545a64675a0820cb1d9b45c61a51efc6a

The XML readers and writers, both parallel and serial, now work
with the pipeline changes. Now, all writers work with pieces
even though the structured ones can handle asking for a sub-
extent.

Change-Id: I9f757ba12a3b9fb84e141506dacadad608eb8b99

Refactoring the way VTK goes between piece and structured
extents. Before, extent translators were used when the pipeline
moved from structured to unstructured data converting piece
request to extent request. This caused many problems with filters
that altered extents, mainly a lot of redundant IO due to
repartitioning of different extents. This became extremely
cumbersome to manage when running distributed. The new behavior
pushes the extent translation all to way to the readers and
only when readers are able to read a subset. This works much
better. The only downside is that filters need to be able to
handle data extents different than update extents. Most filters
can do this but many imaging filters cannot. Those that are
needed in parallel will have to be updated.

As part of this work, I also removed MAXIMUM_NUMBER_OF_PIECES
and added CAN_HANDLE_PIECE_REQUEST. MAXIMUM_NUMBER_OF_PIECES had
reduced to being a boolean. 1 for serial sources, -1 for parallel
...

Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
are maintained outside VTK.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>

Move source files from their former monolithic VTK location to their new
location in modular VTK without modification.  This preserves enough
information for "git blame -M" and "git log --follow" to connect
modularized VTK files to their original location and history.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>
Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

copy the information from the readers output port to the information object
passed. It does indeed expect to use the readers actual output port as the
source for the information. This method never gets called during ProcessRequest
of the reader so it doesn't make sense to use GetCurrentOutputInformation()
anyways.

The readers were accessing their output information and through the executive.
This creates problems when what is passed to ProcessRequest() is different.

* vtkDataArray now has a new superclass-vtkAbstractArray.vtkAbstractArray
provides type-agnostic API to access array elements. vtkDataArray provides
a double API to access values -- such an API is deliberately missing from
vtkAbstractArray, since arrays like string arrays are not castable to doubles.

* vtkAbstractArray has the notion of components/tuples, but does not make
any assumptions about the arragment of these. It's up to the concrete
subclasses how the data is represented in memory.

* vtkFieldData used to provide tuple API to get/set values from data arrays
contained in it. However, now that FieldData can have arrays that are not
vtkDataArrays, this API is not longer valid.
The following are the methods that are no longer available:
double* GetTuple(const vtkIdType);
void SetTuple(const vtkIdType i, const double* tuple);
void GetTuple(const vtkIdType i, double* tuple);
void InsertTuple(const vtkIdType i, const double* tuple);
void InsertNextTuple(cons double*);
double GetComponent(const vtkIdType i, const int j);
void SetComponent(const vtkIdType i, const int j, const double c);
void InsertComponent(const vtkIdType i, const int j, const double c);
However, new API is provided to copy tuples arround from one field data to
another using:
void SetTuple(const vtkIdType i, const vtkIdType j, vtkFieldData* source);
void InsertTuple(const vtkIdType i, const vtkIdType j, vtkFieldData* source);
vtkIdType InsertNextTuple(const vtkIdType j, vtkFieldData* source);

* vtkFieldData provide a vtkDataArray* GetArray(int index) to retrieve arrays
in the field data. This function can will now return a NULL if the array
at the given index is not a data array. It provides
vtkAbstractArray* GetAbstractArray(int index);
to retrieve an array even if it isn't a vtkDataArray.

* Since vtkFieldData can contain arrays that aren't subclasses of
vtkDataArray, so can vtkDataSetAttributes. However, an attribute can only be
a vtkDataArray subclass i.e. one cannot set a vtkStringArray as the SCALARS
array for a Point Data, for example.

* String Array IO is only supported in XML file formats. If deemed important,
support may be added for lecacy file formats.

*** Array Iterators ***
Another addition to the VTK Arrays, is the notion of Array Iterator. A
vtkArrayIterator subclass is be provided for every vtkAbstractArray
subclass. The iterator is a random access iterator. The iterators are not
available in any of the wrapped languages, however, in C++ they can be used to
write templatized code to processes the array values without any implicit type
conversion and consequent loss of precision. vtkArrayIteratorTemplateMacro is
provided to simply switching between different types of the arrays. Examples of
use of this macro and the iterators can be found in
vtkXMLWriter.cxx / vtkXMLDataReader.cxx / vtkXMLStructuredDataReader.cxx.

ENH: Added CopyOutputInformation method to XML readers so that they can copy the infromation they set in the RequestInformation pass to another information object (to support vtkXMLCollectionReader)

ENH: Added support for multiple outputs from vtkXMLReader.  The standard data set readers all still have only one output.

ENH: Updated XML writer/reader classes to use a platform-independent set of data type names and binary representations in the file format.  This should make the files completely portable.  Also fixed a crash when a data array is not created correctly.