1. 31 May, 2018 40 commits
  2. 30 May, 2018 40 commits
  3. 29 May, 2018 40 commits
    • David Gobbi's avatar
      Merge topic 'maptowindowlevelcolors-doc' · 0f31800e
      David Gobbi authored
      086c487f Expand the description of vtkImageMapToWindowLevelColors
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: default avatarDavid E. DeMarle <dave.demarle@kitware.com>
      Merge-request: !4340
      0f31800e
    • David Gobbi's avatar
      Expand the description of vtkImageMapToWindowLevelColors · 086c487f
      David Gobbi authored
      This filter is most often to apply a Window/Level operation to
      grayscale input data, without a lookup table, so I have put that
      first in the description.  The less-common use of modulating the
      color produced by a lookup table has been moved to the end.
      086c487f
    • Allison Vacanti's avatar
      Merge topic 'volume-clip-artifact' · 9095631e
      Allison Vacanti authored
      5c6bde06 Fix volume clip bug and add regression test.
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Merge-request: !4338
      9095631e
    • Cory Quammen's avatar
      Merge topic 'selection-refactor' · e1b0b757
      Cory Quammen authored
      5d6c1178 Change type of InsidednessArrayName member variable
      bc2a6f8e Rename vtkSelectionOperator to vtkSelector
      848fccf0 Change algorithm for computing selections
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Merge-request: !4315
      e1b0b757
    • Allison Vacanti's avatar
      Fix volume clip bug and add regression test. · 5c6bde06
      Allison Vacanti authored
      When clipping a volume using in-shader clipping planes, it was possible
      for the starting point of the ray cast to lie beyond the data volume.
      The raycast code is written such that the first sample is always taken
      before testing termination criteria, and in these cases we would always
      take a single sample outside of the volume, leading to artifacts.
      
      Fixed this behavior by checking that the starting position calculated
      by AdjustSampleRangeForClipping is indeed inside of the volume bounds and
      aborting the raycast if it is not.
      
      The existing TestGPURayCastClipping test would have caught this, except
      that the vase.vti volume used for testing has all 0's at the boundaries,
      so the rendering was correct even with the edge-clamp repetition outside
      of the volume (the faulty samples always computed RGBA=vec4(0)). I
      replaced the vase.vti of this test with a wavelet with finite boundary
      values that will catch this problem if there's a regression.
      5c6bde06
    • Cory Quammen's avatar
      Change type of InsidednessArrayName member variable · 5d6c1178
      Cory Quammen authored
      Changed from const char * to std::string. Also, removed unused setter
      and getter in vtkSelector API.
      5d6c1178
    • Cory Quammen's avatar
      Rename vtkSelectionOperator to vtkSelector · bc2a6f8e
      Cory Quammen authored
      Subclasses are named vtk*Selector, so make the superclass vtkSelector
      to match.
      bc2a6f8e
    • Cory Quammen's avatar
      Change algorithm for computing selections · 848fccf0
      Cory Quammen authored
      Previously, the vtkExtractSelection filter iterated over blocks in a
      composite dataset and evaluated a vtkSelection block by
      block. Unfortunately, this did not make it easy to write selection
      operator subclasses that need to operate on an entire composite
      dataset, and required some code contortions to enable block selection.
      
      With this change, the selection algorithm is modified to iterate over
      each vtkSelectionNode in the vtkSelection and create an insidedness
      array associated with the attribute specified by the selection. Only
      after each of these arrays is created do we iterate over blocks and
      evaluate the selection expression, ultimately extracting the selected
      elements.
      
      This is accomplished by changing the query selector API's member
      function ComputeSelectedElements() that takes two arguments, an input
      vtkDataObject and an output vtkDataObject that will contain an
      insidedness array after the function is executed. Two additional
      protected pure virtual member functions have been added to the
      protected API that separately handle composite data objects
      (ComputeSelectedElementsForDataObject()) and non-composite data
      objects (ComputeSelectedElementsForBlock()). The
      ComputeSelectedElements() function invokes these functions to compute
      the insidedness array for composite and non-composite data
      sets, respectively. Subclasses are required to implement
      ComputeSelectedElementsForBlock(). The default implementation for
      ComputeSelectedElementsForDataObject() is to call
      ComputeSelectedElementsForBlock().
      
      vtkExtractSelection has been reorganized to implement the new
      algorithm. The functionality in the internal evaluator classes has
      been moved to the selectors themselves, and the evaluators have been
      removed. These changes make it easier to extend the selection types
      available. For example, block selection is now supported with a new
      vtkBlockSelector object.
      848fccf0
    • Utkarsh Ayachit's avatar
      Merge topic 'partial-arrays-xml-io' · 96f882fd
      Utkarsh Ayachit authored
      02f949cb Handle mismatch is chosen and available arrays.
      1fffa689 add tests to read/write multiblock with partial arrays
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Merge-request: !4337
      96f882fd
    • Aron Helser's avatar
      Merge topic 'moments_remote_module' · ccd60e52
      Aron Helser authored
      8776e904 MomentInvariants final remote repo location and hash
      0aeb5bab Remote: parallel code included in single module
      aa8b5698 Remote: change ParallelMoments to use branch
      3249d4e8 Remote Modules, add MomentInvariants, and ParallelMI
      700215a8 Remove MomentInvariants filter, prep to make remote
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Merge-request: !4301
      ccd60e52
    • David E. DeMarle's avatar
      Merge topic 'plug-more-v2osp-memory-leaks' · cca3d092
      David E. DeMarle authored
      6af94ebb suppress and fix comp warnings
      6a91019c use osp release not delete with osp volumes to prevent crashes
      7e72778b don't leak ospray buffer either
      fc779976 dont leak the light either
      d67f69e2 Fix a huge memory leak.
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: Ken Martin's avatarKen Martin <ken.martin@kitware.com>
      Merge-request: !4331
      cca3d092
    • Utkarsh Ayachit's avatar
      Handle mismatch is chosen and available arrays. · 02f949cb
      Utkarsh Ayachit authored
      vtkXMLDataReader had asserts that checked for extact match between
      arrays enabled using the array selection API and then the arrays
      actually read (present) in the file. This caused issues when reading
      composite datasets with partial arrays following the change in
      56f1f110 (see paraview/paraview#18189).
      
      Updating the code in vtkXMLDataReader so that it can handle a mismatch
      in fields. The limitation was unreasonable anyways.
      02f949cb
    • Utkarsh Ayachit's avatar
  4. 26 May, 2018 40 commits
  5. 25 May, 2018 40 commits