GitLab

Found via `codespell`

While maintaining backwards compatibility at least
update our code to use the more modern in/out
qualifiers as opposed to attribute/varying  Also
remove old glsl 120 if statements as we no longer support
it and also remove a performance issue in querying the
gl major minor version on every shader test.

includes grammar and uniformity fixes as well.

This topic catches another batch of NULL conversions that
clang did not handle for various reasons. It also includes
a number of changes to comments and strings where NULL was
used. It also catches some recent code changes where NULL
was used instead of nullptr.

This topic is the result of running clang-tidy to
modernize our usage of NULL and 0 to nullptr. It also
includes some manual and semi manual changes where
clang-tidy would not be expected to work (such as in
comments, or classes not compiled on this build)

There are definitely many comments and occurances that
this topic misses that we will need to fix over time.

Found & auto-fixed by clang-tidy’s readability-container-size-empty check.

empty() is guaranteed O(1) while size() is not, thus could be faster in some cases.

This topic adds cubemap and mipmap options to vtkTexture
It updates the polydatamapper to always declare and bind
any textures assigned to the actor/property even if
there are no texture coordinates (the shader may compute them)

mipmaps are supported for cubemaps on OpenGL 4 or later.
For earlier versions the request is ignored.

They require the layout qualifier

Cases were:
- failure to declare & define together
- plain old failure to use set value
- (seemingly) copy-pastos
- “TODO”-type deliberate non-use (for which I switched to #if 0)

ES2 is causing headaches and code mess and is
getting old. Remove for 8.0 so we can focus on
more modern APIs. Most Apple and Adroid devices
from the past 4 years support ES3.

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

on some systems 3.1 or 3.0 might work while 2.1 does not

Find/replace of:

with C++ counterparts.  Changed only vtk*.cxx files.
Didn’t touch .h or .c or any 3rd party.

Some more fixes to coverity warnings

Update ios to include 9.1

Update OpenGL ES 2 to always require OES derivs extension and
put it first to avoid errors on some devices

This topic adds a volume rendering example to android builds.  It also
fixes a number of issues to make it work with android including on
Samsung devices which have a different OpenGL driver.

VR use of 1D textures have been replaced with 2D textures as
1D textures are not supported on OpenGL ES.

Some minor build inprovements are included as well.

Support wide lines in 3.2 using a geometry shader. This patch
includes a number of cleanups to make using geometry shaders
easier etc.

Add an option to Ready a shader program based on a vector of shaders

Rename some functions to match what they do

Cleanup some memory leaks in the LIC code

vtkgl::CellBO renamed vtkOpenGLHelper
vtkgl::substitute moved to vtkShaderProgram::Substitute
Creation of vtkOpenGLIndexBufferObject
Creation of vtkOpenGLVertexBufferObject
Move methods that were in vtkglVBOHelper into new classes
Move IndexCount from CellBO to vtkOpenGLIndexBufferObject
etc

The LIC shaders were not converted properly for gl 3.2

Cleanup some code standard issues

A bunch more fixes mostly related to line widths which are
not supported above 1.0 in OpenGL 3.1 and later. For the
context2D class I implemented wide lines. For the rest I
produce an error message and continue.

OSX is a bit more strict on its opengl so a bunch more changes were
required such as using in/out instead of attribute/varying. Also
handle gl_FragData properly for 3.2 as an output variable.

glew had a bug preventing glGenVertextAttribute... from being
defined. Made a change to correct that.

Also a few tweaks to get closer to OpenGL 32 support
for mesa.

ParaView IceT does a WindowRemap when using tile display. That
means everythgin has to work with a new window/context so it
identifies a bunch of release graphics resource issues. This
patch fixes a bunch of them. Mostly minor changes the one
large change is to make ReleaseGraphicsResources in Renderer
public like it is for every other class. This is the way it
should be and the original protected method was a mistake from
way way back.  Making it public save us from doing the

SetRenderWindow(NULL)
SetRenderWindow(this)

hack that we have been using to free up resources in the
renderer since we could nto call the protected method.

Change-Id: If31406fa9425417d240311aac110c82409637163

This patch makes the old freetype glDrawPixles calls work
with OpenGL2. At some point the code really needs to be upgraded
to a more modern approach that would work on ES etc but this
restores functionality that OpenGL2 broke.

Also includes a minor MTime fix for LegendBoxActor

Change-Id: I7d60023df5950932828a98cd5fff29b826a84479

Change-Id: I9b09ceba1ef624163d0199d59d05678e8b8f0e83

For the shader programs that it manages.

Change-Id: Ibddc8442cad1f1a652edc2277a37b5284f1283d2

Change-Id: I787916de193ff0d1bc805d14ac0e2ba018ebcbbc

Change-Id: I01d589927552bfa534d806ea0d1f003357899a35

Change-Id: I0d103f0a238a1fc789c20e8dabd1d4e5662cc5f0

Change-Id: Ia5a81190e717c5689f59d6b99cf81941ca48bc65

Change-Id: I1bf7d985cdbde94db3990e40cb314ff6d2a41e38