1. 25 Jul, 2013 2 commits
    • Utkarsh Ayachit's avatar
      Release graphics resources properly. · 37a10c60
      Utkarsh Ayachit authored
      vtkScalarBarActor wasn't releasing graphics resources for internal texture. This
      fixes the problem.
      
      Change-Id: I5f01c7d8ad0f78c25b4ab8f21bc8b4e66ae91c5f
      37a10c60
    • Utkarsh Ayachit's avatar
      Cleaning up transfer function widgets. · 1509669d
      Utkarsh Ayachit authored
      Cleaning up issues with the context-items related to tranfer function editor.
      
      + Added support for log-mapped color-transfer function. We ensure that when
        using log-scale, the color transfer function widget also enter log-space.
      
      + vtkPiecewiseControlPointsItem had a bug resulting it deleting of end points
        even when told otherwise. Fixed that.
      
      + Added new event vtkControlPointsItem::PointsModifiedEvent which if fired when
        control points are changed making it easier for application to do something
        when the points are changed.
      
      + Improved the usability by adding ability to label control points.
      
      Change-Id: If02bc1139f6ccb3d7c2198b07d10491f902bafda
      1509669d
  2. 05 Jul, 2013 1 commit
  3. 01 Jul, 2013 1 commit
  4. 28 Jun, 2013 4 commits
  5. 27 Jun, 2013 1 commit
  6. 18 Jun, 2013 1 commit
    • David C. Lonie's avatar
      Move scalar bar GL2PS special case handler from PV to VTK. · 9f33a74f
      David C. Lonie authored
      This patch moves the special handler code for scalar bars from paraview
      into VTK. The code was originally in PV as the PVScalarBar differed
      significantly from vtkScalarBar, but now that they share more of their
      implementations VTK can handle the export.
      
      Change-Id: Icf37d51f46ba2569db86da1125c5c0c4f247747f
      9f33a74f
  7. 11 Jun, 2013 1 commit
  8. 07 Jun, 2013 1 commit
  9. 04 Jun, 2013 2 commits
    • Brad King's avatar
      Convert VTKData test inputs to ExternalData content links · 3797f83d
      Brad King authored
      Add to the Testing/Data directory ExternalData content links mirroring
      the content and layout we use from the VTKData/Data directory.
      
      Add a CMake/vtkLegacyData.cmake module, included from CMakeLists.txt and
      Testing/External/CMakeLists.txt, to call ExternalData_Expand_Arguments
      for all data directories added from VTKData/Data.  This will bulk-fetch
      all test input data currently used by tests of any module, enabled or
      not.  We can make the DATA{} references more granular later.
      
      Add a VTK_TEST_DATA_DIR variable to refer to the directory we tell the
      ExternalData module to populate the real data files.  Replace references
      to VTK_DATA_ROOT in test command lines (after -D) with references to
      VTK_TEST_DATA_DIR.  Drop the VTK_DATA_ROOT CMake option and stop using
      the VTKData repository.
      
      Remove the TESTING_DATA option from the vtk_add_test_cxx API and remove
      the VTK_DATA_ROOT option from the vtk_add_test_mpi API since all test
      input data are now handled through ExternalData and Testing/Data content
      links.
      
      Change-Id: Id02490b76ea2e161b9038188264a4830485039d8
      3797f83d
    • David Thompson's avatar
      Use the font scaling provided by vtkTextActor. · 47b6fa6e
      David Thompson authored
      This will increase the size of fonts used on displays
      with high pixel densities.
      
      Also, this changes the signature of vtkTextActor::GetBoundingBox()
      to take a vtkViewport. Since this is a new method for VTK6, it is
      better to fix it now; having it pass a NULL viewport pointer
      internally was causing crashes.
      
      Finally, vtkTextActor::SetConstrainedFontSize() should take font
      scaling into account.
      
      Change-Id: I3cc99f99798da96f5c8e9249538ba269216e302a
      47b6fa6e
  10. 31 May, 2013 1 commit
  11. 28 May, 2013 2 commits
    • David Thompson's avatar
      Update the scalar bar build time. · 155b7f30
      David Thompson authored
      The BuildTime member is not being updated when the
      scalar bar layout is recalculated, causing layouts
      to be recomputed every time the bar is rendered.
      
      Change-Id: Ib5f8e69573383d2c7cf04ca9cfb18b70fbc40dcb
      155b7f30
    • David Thompson's avatar
      Update the scalar bar build time. · 118aa20a
      David Thompson authored
      The BuildTime member is not being updated when the
      scalar bar layout is recalculated, causing layouts
      to be recomputed every time the bar is rendered.
      
      Change-Id: I79615dfee885cf13b64370bd53dd6bc9485980cd
      118aa20a
  12. 27 May, 2013 1 commit
    • Jean-Christophe Fillion-Robin's avatar
      COMP 12945: Allow VTK to build against Qt5 · 384636ec
      Jean-Christophe Fillion-Robin authored
      Since VTK build system has been updated to make use of CMake macros
      specific to Qt5, the support has to explicitly enabled configuring VTK
      with -DVTK_QT_VERSION:STRING="5"
      
      Additionally, in case Qt5 is not installed in a standard location,
      a custom prefix for "find_package" should be passed.
      For example:
        -DCMAKE_PREFIX_PATH:STRING=/home/jchris/Qt5.0.2/5.0.2/gcc_64/
      
      
      Finally, this commit also resolves the build errors reported below.
      
      Fix missing header build error by including Qt headers directly without
      specifying the intermediate directory.
      
      * Fix build error changing QString::toAscii into  QString::toLatin
      The method "toAscii" has been deprecated and is not available in
      default Qt5 distribution.
      See http://qt-project.org/doc/qt-5.0/qtcore/qstring.html#toAscii
      
      * Fix build error changing Qt::WFlags into Qt::WindowFlags
      See http://qt-project.org/doc/qt-5.0/qtcore/qt-obsolete.html
      
      * Fix build error changing QAbstractItemModel::reset() into
      combo QAbstractItemModel::beginResetModel()/QAbstractItemModel::endResetModel()
      The method "reset" has been deprecated and is not available in
      default Qt5 distribution.
      See http://qt-project.org/doc/qt-5.0/qtcore/qabstractitemmodel-compat.html#reset
      
      * Fix build error by including "vtkObjectBase.h":
      /home/jchris/Projects/Qt5.0.2/5.0.2/gcc_64/include/QtCore/qmetatype.h:464: error: invalid application of ‘sizeof’ to incomplete type ‘QStaticAssertFailure<false>’
      
      * Fix "no matching function for call to ‘QPixmap::grabWidget(QWidget*)’" by using
      "QWidget::grab"
      See http://qt-project.org/doc/qt-5.0/qtwidgets/qwidget.html#grab
      
      * Fix missing QHttpHeader/QHttpRequestHeader headers by removing them.
      They have been removed from Qt5 and were not used in the code.
      
      * Fix error: ‘qInstallMsgHandler’ was not declared in this scope
      by using "qInstallMessageHandler"
      See http://qt-project.org/doc/qt-5.0/qtdoc/sourcebreaks.html
      
      * Fix Q4VTKWidgetPlugin.cxx:147: error: invalid application of
      ‘sizeof’ to incomplete type ‘QStaticAssertFailure<false>’ by
      using "Q_PLUGIN_METADATA" macro instead of Q_EXPORT_PLUGIN
      or Q_EXPORT_PLUGIN2.
      See http://qt-project.org/wiki/Transition_from_Qt_4.x_to_Qt5#7ec1b8f08d7f31ebcb53188f0bd15ed5
      
      Change-Id: Ie7123e5990e3a8afb4d7d2efa0fda5bd7b98c1e3
      384636ec
  13. 23 May, 2013 3 commits
    • Brad King's avatar
      Search for Ghostscript only when needed · fb82c67a
      Brad King authored
      Move the search for the Ghostscript executable added by commit 870dd114
      (Add new GL2PS testing system using ghostscript, 2012-10-01) into a
      dedicated vtkGhostscript module.  Include it from CMakeLists.txt that
      need VTK_GHOSTSCRIPT_EXECUTABLE.  This avoids keeping module-specific
      code in the top-level CMakeLists.txt file and enables the corresponding
      tests in the Testing/External build.
      
      Change-Id: I410737f16c653aaaa60799ce1471cb1798707079
      fb82c67a
    • Brad King's avatar
      Remove references to old VTKData/Baseline directories · fc5d874c
      Brad King authored
      The VTKData repository no longer holds Baseline directories so drop
      references to such directories from the VTK source tree:
      
      * Replace the default -V in CMake/vtkTestingRenderingDriver.cmake with a
        value that will fail but indicate what to do.  All current uses of
        this module have an explicit -V so the default should never be used.
      
      * Drop a few leftover Baseline directory references from comments in
        "*/*/Testing/*/CMakeLists.txt".
      
      * Remove boilerplate duplicate test command-line examples (that
        reference Baseline directories) from *.py tests and leave an updated
        example in "Wrapping/Python/README.txt".  The command-line example
        convention was added long before the modern CTest infrastructure
        and is no longer needed anyway.
      
      Change-Id: I3001e99b3cc8c2717107e61b3b7f988caeb49cab
      fc5d874c
    • Brad King's avatar
      Use vtk_test_cxx_executable in Rendering/GL2PS/Testing/Cxx · 57569cc9
      Brad King authored
      Replace the last use of vtkTestingObjectFactory.cmake and remove it.
      CMake modules that have immediate inline effects are hard to follow, so
      drop this one.
      
      Change-Id: I813644b0c31c1eecd3415f11e57e703d035940fd
      57569cc9
  14. 21 May, 2013 1 commit
  15. 20 May, 2013 1 commit
    • Andrew Maclean's avatar
      Make some color methods consistent. · 293e5386
      Andrew Maclean authored
      In order to use functions like SetTableValue(2, "Blue") in a lookup table
        or other SetColors in derived classes in the same manner,
        these methods should be virtual.
      This commit just makes the relevant Set methods virtual.
      In the case of vtkProperty, the definition of SetColor(double a[3]) has
        been moved into vtkProperty.cxx, the rationale is that, in VTK classes,
        definitions occur in the implementation file not the header file.
      
      Change-Id: I89fee8eb4902e0847114b068374c3bff0bf10b9d
      293e5386
  16. 17 May, 2013 2 commits
  17. 16 May, 2013 1 commit
    • Andrew Maclean's avatar
      Make some color methods consistent. · 55475274
      Andrew Maclean authored
      
      
      In order to use functions like SetTableValue(2, "Blue") in a lookup table
        or other SetColors in derived classes in the same manner,
        these methods should be virtual.
      This commit just makes the relevant Set methods virtual.
      In the case of vtkProperty, the definition of SetColor(double a[3]) has
        been moved into vtkProperty.cxx, the rationale is that, in VTK classes,
        definitions occur in the implementation file not the header file.
      
      Change-Id: I6ad8d0019785faed1f7cb157192fdcc2f2d70c34
      Signed-off-by: Andrew Maclean's avatarAndrew Maclean <andrew.amaclean@gmail.com>
      55475274
  18. 14 May, 2013 7 commits
    • Brad King's avatar
      Use ExternalData to reference test baselines · 42baebf3
      Brad King authored
      Teach vtk_add_test_* to use ExternalData_add_test to add tests and use
      DATA{} syntax to reference test baseline images.  Also update direct
      add_test calls in several modules.
      
      Change-Id: I1ddcec1c109ea9ca7840be9b6ccf015393039cba
      42baebf3
    • Brad King's avatar
      Mark non-baseline tests with NO_VALID option · 050fd10e
      Brad King authored
      Tell calls to vtk_add_test_(cxx|python|tcl) explicitly when there is no
      valid baseline image to avoid passing -V unnecessarily.
      
      Change-Id: Ibe5aecdfa076446ddda0b95e814483eb6622af73
      050fd10e
    • Brad King's avatar
      Use vtk_add_test_(python|tcl) where possible · 02f0a6d2
      Brad King authored
      Convert some direct add_test calls to use the helper functions instead.
      
      Change-Id: I4f6b92e24804885c6b1449b21ae8efffd22ffdbf
      02f0a6d2
    • Brad King's avatar
      Use vtk_add_test_cxx function · 5b018861
      Brad King authored
      Refactor */*/Testing/Cxx/CMakeLists.txt to use the vtk_add_test_cxx
      function instead of direct add_test calls.
      
      Change-Id: I73dee627fa87a399c48b409af046b116fc75a0fd
      5b018861
    • Brad King's avatar
      vtkTestingMacros: Remove vtk_tests macro · ef7f0191
      Brad King authored
      Use vtk_add_test_cxx and vtk_test_cxx_executable to replace calls to
      vtk_tests.  Then remove vtk_tests and parse_optional_arguments.
      
      Change-Id: I73dee627fa87a399c48b409af046b116fc75a0fd
      ef7f0191
    • Brad King's avatar
      vtkTestingMacros: Simplify vtk_add_test_mpi signature · 954ca17c
      Brad King authored
      Use keyword options VTK_DATA_ROOT and VTK_LARGE_DATA_ROOT to indicate
      the source of data for the MPI test, if any.
      
      Change-Id: I170b4dcb88984df5ec0bba46fa6587e0aeea63f3
      954ca17c
    • Brad King's avatar
      vtkTestingMacros: Rename add_test_(mpi|python|tcl) with vtk_ prefix · e58d8029
      Brad King authored
      Use shell code:
      
       git grep -Elz '\<add_test_(mpi|python|tcl)' |
       xargs -0 sed -ri 's/\<add_test_(mpi|python|tcl)/vtk_add_test_\1/g'
      
      Change-Id: I6d076e2483209a83231fb1c96053f0389a3fcdf2
      e58d8029
  19. 13 May, 2013 2 commits
    • Brad King's avatar
      vtkTestingMacros: Generalize add_test_(python|tcl) · 52b51415
      Brad King authored
      Teach add_test_(python|tcl) to parse explicit NO_DATA, NO_RT, NO_VALID,
      and NO_OUTPUT keyword options for tests that do not need VTK_DATA_ROOT
      or do not use a valid baseline image.  Factor add_test_python1 into
      add_test_python and distinguish them with the NO_RT keyword argument.
      Update call sites to produce identical test command lines before and
      after this change.
      
      Change-Id: I09f874b26aab409e55e7aa6f92412314540dbb85
      52b51415
    • Utkarsh Ayachit's avatar
      Added a new module, vtkPythonInterpreter. · be75a19a
      Utkarsh Ayachit authored
      VTK now includes a Utilities module, vtkPythonInterpreter that provides a Python
      interpreter. While its use it totally optional, it helps in applications with
      embedded Python interpreter, such as ParaView.
      
      vtkMatplotlibMathTextUtilities now uses vtkPythonInterpreter to initialize
      Python. This enables applications to setup Python environment as needed witout
      directly having to hack environment variables to setup matplotlib environment.
      
      Since vtkPythonInterpreter allows applications to initialize/finalize Python
      interpreter mutliple times, fixed vtkPythonCommand to cleanup
      PyObject/PyThreadState pointers when Python interpreter is exitted.
      
      Change-Id: I80ed56fc3f64dda2766a6aa2e6e92c3aa7290993
      be75a19a
  20. 08 May, 2013 1 commit
  21. 02 May, 2013 1 commit
    • Kyle Lutz's avatar
      Refactoring code to set color/opacity/visibility for blocks. · 52fd8ad8
      Kyle Lutz authored and Utkarsh Ayachit's avatar Utkarsh Ayachit committed
      This commit refactors some of the code added in recent weeks to add ability for
      users to set display paramaters for blocks within a composite dataset. This
      commit additionally adds support for changing block opacity.
      
      Blocks colors/opacities can also be overridden when using scalar coloring.
      The only issue is when depth-peeling gets used. In that case, point-data coloring
      with texture (i.e. using interpolate scalars before mapping) results in color
      bleeds. We need to dig into the depth peeling code to address that issue.
      
      Change-Id: I2c86912b45bc0516dc4dc726df9448e0569c8312
      52fd8ad8
  22. 30 Apr, 2013 1 commit
    • Yumin Yuan's avatar
      Attempts to fix random failure of TestPolygonSelection on amber8. · 947a3261
      Yumin Yuan authored
      The original test has many MouseMove events, and each event will trigger redrawing of polygon on screen,
      which takes a fairly long time to run on amber8 due to software-rendering with Mesa. This commit modified
      the playback events so that only a few events are included and the test result image stays the same. The pixel drawing part of the test is also turned off for the test.
      
      Change-Id: I848a550ad4a3e0fd662fb97df96e381587585318
      947a3261
  23. 28 Apr, 2013 2 commits
    • David Thompson's avatar
      Fix for subclasses overriding EditAnnotations. · cc42420f
      David Thompson authored
      The accounting done assumed that all annotations were
      contained in the lookup table, but this is not true when
      subclasses provide more. This was revealed by the
      ParaView version of the scalar bar actor, which adds
      min and max values as annotations on the continuous
      scalar bar.
      
      Change-Id: I6186f22ee9f29be889fc83522e67968688759922
      cc42420f
    • Andrew Maclean's avatar
      These Python tests have been refactored. · 3810c5a6
      Andrew Maclean authored
      
      
      This has been done by removing the "tcl-isms" and making
       the code more readable. In some cases redundant code
       has been removed (often a result of copy/paste operations).
       The code has also been checked to ensure each line is 80
       characters or less.
      
      The code can now be run using vtkpython or by using the
       appropriate Python environment.
      
      Originally these were TCL scripts that were converted using
        vtkTclTestToPy.py and they they needed to be run through the
        rtImageTest.py driver which defines a few needed
        functions/variables for their operation. To this end
        backdrop.py has been added where it is needed.
      
      Change-Id: I50d6505628c140ea4551f74f7f3e85df907567e1
      Signed-off-by: Andrew Maclean's avatarAndrew Maclean <andrew.amaclean@gmail.com>
      3810c5a6