1. 04 Oct, 2017 1 commit
  2. 02 Oct, 2017 1 commit
  3. 17 Oct, 2016 2 commits
    • Bill Lorensen's avatar
      BUG: KuenSurface singularity at the pole · bb6811a9
      Bill Lorensen authored
      There is a singularity when v = 0. This patch checks for v = 0 and
      replaces it with a small number, .05.
      
      A new ivar DeltaV0 can change this value.
      
      This bug was noticed when running the VTK wiki example:
      Cxx/GeometricObjects/ParametricObjectsDemo2. While rotating the camera
      for the Kuen surface, the center of rotation appeared off. The
      z-coordinate was NAN for points when v == 0.
      
      Also, the ordering of triangles was incorrect.
      bb6811a9
    • Andrew Maclean's avatar
      Fixing the triangulation of the Parametric Surfaces. · d3d9bf72
      Andrew Maclean authored
      Bill Lorenson noticed that the front face of orientable surfaces was being
       displayed as a back face. This arose as a "hack" when these functions
       were
        first implemented because the cross-product used to create the normals
        was
         right-handed, thus the triangulation orientation was clockwise.
          Additionally there were weird triangulations in the
          ParametricSuperEllipsoid
           and ParametricSuperToroid.
      
           The following three fixes have been applied:
      
           1) The orientation of the normals is fixed in the case of
           anti-clockwise
              ordering by calculating cross(Dv,Du) instead of cross(Du,Dv).
      	   When this is done the normals point in the expected direction
      	   and the
      	      front face is rendered correctly. See:
      	      vtkParametricFunctionSource.cxx.
      	      2) All the surfaces now implement anti-clockwise ordering
      	      with respect to the
      	         triangulation.
      		 3) The ParametricSuperEllipsoid and ParametricSuperToroid
      		 have been reworked,
      		    now the surface is constructed as four pieces that are
      		    abutted together,
      		       this removes the triangulations resulting in weird
      		       appearances.
      		       4) In order to implement the anti-clockwise
      		       ordering in the triangulation
      		          the x, y points have had to be swapped in a few
      			  cases.
      			  5) TestParametricFunctions.png has had to be
      			  replaced. The images for
      			     ParametricTorus, ParametricSuperEllipsoid and
      			     ParametricSuperToroid
      			        changed as a result of the above changes
      d3d9bf72
  4. 16 Oct, 2016 1 commit
    • Bill Lorensen's avatar
      BUG: KuenSurface singularity at the pole · 37a2b43d
      Bill Lorensen authored
      There is a singularity when v = 0. This patch checks for v = 0 and
      replaces it with a small number, .05.
      
      A new ivar DeltaV0 can change this value.
      
      This bug was noticed when running the VTK wiki example:
      Cxx/GeometricObjects/ParametricObjectsDemo2. While rotating the camera
      for the Kuen surface, the center of rotation appeared off. The
      z-coordinate was NAN for points when v == 0.
      
      Also, the ordering of triangles was incorrect.
      37a2b43d
  5. 11 Oct, 2016 1 commit
    • Andrew Maclean's avatar
      Fixing the triangulation of the Parametric Surfaces. · c7b75843
      Andrew Maclean authored
      Bill Lorenson noticed that the front face of orientable surfaces was being
       displayed as a back face. This arose as a "hack" when these functions
       were
        first implemented because the cross-product used to create the normals
        was
         right-handed, thus the triangulation orientation was clockwise.
          Additionally there were weird triangulations in the
          ParametricSuperEllipsoid
           and ParametricSuperToroid.
      
           The following three fixes have been applied:
      
           1) The orientation of the normals is fixed in the case of
           anti-clockwise
              ordering by calculating cross(Dv,Du) instead of cross(Du,Dv).
      	   When this is done the normals point in the expected direction
      	   and the
      	      front face is rendered correctly. See:
      	      vtkParametricFunctionSource.cxx.
      	      2) All the surfaces now implement anti-clockwise ordering
      	      with respect to the
      	         triangulation.
      		 3) The ParametricSuperEllipsoid and ParametricSuperToroid
      		 have been reworked,
      		    now the surface is constructed as four pieces that are
      		    abutted together,
      		       this removes the triangulations resulting in weird
      		       appearances.
      		       4) In order to implement the anti-clockwise
      		       ordering in the triangulation
      		          the x, y points have had to be swapped in a few
      			  cases.
      			  5) TestParametricFunctions.png has had to be
      			  replaced. The images for
      			     ParametricTorus, ParametricSuperEllipsoid and
      			     ParametricSuperToroid
      			        changed as a result of the above changes
      c7b75843
  6. 23 Sep, 2016 2 commits
  7. 19 Aug, 2016 1 commit
  8. 07 Jul, 2016 2 commits
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION to many constructors · 1853e030
      Sean McBride authored
      vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;
      
      vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;
      1853e030
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION for operator= · 2d0e11ef
      Sean McBride authored
      (operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
      to
      \1 VTK_DELETE_FUNCTION;
      
      After that, this finds basically nothing:
      
      operator.*implemented
      
      then manually reverted changed files in VPIC and KWSys folders.
      2d0e11ef
  9. 08 Mar, 2016 1 commit
  10. 03 Nov, 2015 1 commit
  11. 30 Oct, 2015 1 commit
    • Tim Meehan's avatar
      Added some new parametric functions · b2233c75
      Tim Meehan authored
      I looked around for some interesting parametric functions to add. These are
      all surfaces, and the parametrizations do not use special functions.
      b2233c75