1. 21 Mar, 2018 1 commit
    • Sean McBride's avatar
      Applied clang-tidy modernize-use-equals-default fixes · 84ec1d57
      Sean McBride authored
      This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.
      
      There are now some duplicate semis because it did changes like:
      
        ~AMRIndexIterator() override{};
      to
        ~AMRIndexIterator() override= default;;
      
      Note there was a pointless semi before, which clang-tidy didn’t expect / account for.
      
      My next commit will remove them.
      84ec1d57
  2. 17 Oct, 2016 1 commit
    • Andrew Maclean's avatar
      Fixing the triangulation of the Parametric Surfaces. · d3d9bf72
      Andrew Maclean authored
      Bill Lorenson noticed that the front face of orientable surfaces was being
       displayed as a back face. This arose as a "hack" when these functions
       were
        first implemented because the cross-product used to create the normals
        was
         right-handed, thus the triangulation orientation was clockwise.
          Additionally there were weird triangulations in the
          ParametricSuperEllipsoid
           and ParametricSuperToroid.
      
           The following three fixes have been applied:
      
           1) The orientation of the normals is fixed in the case of
           anti-clockwise
              ordering by calculating cross(Dv,Du) instead of cross(Du,Dv).
      	   When this is done the normals point in the expected direction
      	   and the
      	      front face is rendered correctly. See:
      	      vtkParametricFunctionSource.cxx.
      	      2) All the surfaces now implement anti-clockwise ordering
      	      with respect to the
      	         triangulation.
      		 3) The ParametricSuperEllipsoid and ParametricSuperToroid
      		 have been reworked,
      		    now the surface is constructed as four pieces that are
      		    abutted together,
      		       this removes the triangulations resulting in weird
      		       appearances.
      		       4) In order to implement the anti-clockwise
      		       ordering in the triangulation
      		          the x, y points have had to be swapped in a few
      			  cases.
      			  5) TestParametricFunctions.png has had to be
      			  replaced. The images for
      			     ParametricTorus, ParametricSuperEllipsoid and
      			     ParametricSuperToroid
      			        changed as a result of the above changes
      d3d9bf72
  3. 11 Oct, 2016 1 commit
    • Andrew Maclean's avatar
      Fixing the triangulation of the Parametric Surfaces. · c7b75843
      Andrew Maclean authored
      Bill Lorenson noticed that the front face of orientable surfaces was being
       displayed as a back face. This arose as a "hack" when these functions
       were
        first implemented because the cross-product used to create the normals
        was
         right-handed, thus the triangulation orientation was clockwise.
          Additionally there were weird triangulations in the
          ParametricSuperEllipsoid
           and ParametricSuperToroid.
      
           The following three fixes have been applied:
      
           1) The orientation of the normals is fixed in the case of
           anti-clockwise
              ordering by calculating cross(Dv,Du) instead of cross(Du,Dv).
      	   When this is done the normals point in the expected direction
      	   and the
      	      front face is rendered correctly. See:
      	      vtkParametricFunctionSource.cxx.
      	      2) All the surfaces now implement anti-clockwise ordering
      	      with respect to the
      	         triangulation.
      		 3) The ParametricSuperEllipsoid and ParametricSuperToroid
      		 have been reworked,
      		    now the surface is constructed as four pieces that are
      		    abutted together,
      		       this removes the triangulations resulting in weird
      		       appearances.
      		       4) In order to implement the anti-clockwise
      		       ordering in the triangulation
      		          the x, y points have had to be swapped in a few
      			  cases.
      			  5) TestParametricFunctions.png has had to be
      			  replaced. The images for
      			     ParametricTorus, ParametricSuperEllipsoid and
      			     ParametricSuperToroid
      			        changed as a result of the above changes
      c7b75843
  4. 08 Mar, 2016 1 commit
  5. 09 Apr, 2012 2 commits
    • VTK Developers's avatar
      Remove trailing whitespace from all source files · 2d323fc4
      VTK Developers authored
      Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
      are maintained outside VTK.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      2d323fc4
    • VTK Developers's avatar
      Modularize VTK tree layout · cdd4d6fd
      VTK Developers authored
      Move source files from their former monolithic VTK location to their new
      location in modular VTK without modification.  This preserves enough
      information for "git blame -M" and "git log --follow" to connect
      modularized VTK files to their original location and history.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
      cdd4d6fd
  6. 20 May, 2010 1 commit
    • Mark Olesen's avatar
      Remove vtk(Cxx|Type)RevisionMacro · ecbbf7f7
      Mark Olesen authored
      The CVS $Revision$ keyword replacement will no longer maintain these
      macros automatically.  They were used only to implement CollectRevisions
      and vtkObjectBase::PrintRevisions, an API that was never used.
      
      Automated as follows:
      
        pass 0:
        catch templates
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'
      
        pass 1:
        main changes
        ---------------
        $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
          echo "$file" 1>&2
          perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
        done
        $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
          echo "$file" 1>&2
          perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
        done
      
        pass 2:
        verify
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'
      
      Fixed multi-line vtkCxxRevisionMacro and templates by hand.
      ecbbf7f7
  7. 23 Apr, 2010 1 commit
    • Mark Olesen's avatar
      Remove vtk(Cxx|Type)RevisionMacro · 19c55e0e
      Mark Olesen authored
      The CVS $Revision$ keyword replacement will no longer maintain these
      macros automatically.  They were used only to implement CollectRevisions
      and vtkObjectBase::PrintRevisions, an API that was never used.
      
      Automated as follows:
      
        pass 0:
        catch templates
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'
      
        pass 1:
        main changes
        ---------------
        $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
          echo "$file" 1>&2
          perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
        done
        $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
          echo "$file" 1>&2
          perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
        done
      
        pass 2:
        verify
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'
      
      Fixed multi-line vtkCxxRevisionMacro and templates by hand.
      19c55e0e
  8. 05 Mar, 2005 1 commit
    • Andrew Maclean's avatar
      ENH: - In the header files, I cleaned up the documentation, converting some... · 926ff90c
      Andrew Maclean authored
      ENH:   - In the header files, I cleaned up the documentation, converting some equations to LaTex and removing all the equations defining the surfaces. These equations defining the surfaces are now in a white paper along with some supplementary information. I'll put a reference to the white paper in the header files when a decision is made regarding where the white paper will go.  In the cxx files I have made the layout more VTK compliant.
      926ff90c
  9. 08 Feb, 2005 1 commit