1. 21 Mar, 2018 1 commit
    • Sean McBride's avatar
      Applied clang-tidy modernize-use-equals-default fixes · 84ec1d57
      Sean McBride authored
      This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.
      
      There are now some duplicate semis because it did changes like:
      
        ~AMRIndexIterator() override{};
      to
        ~AMRIndexIterator() override= default;;
      
      Note there was a pointless semi before, which clang-tidy didn’t expect / account for.
      
      My next commit will remove them.
      84ec1d57
  2. 17 Oct, 2016 1 commit
    • Andrew Maclean's avatar
      Fixing the triangulation of the Parametric Surfaces. · d3d9bf72
      Andrew Maclean authored
      Bill Lorenson noticed that the front face of orientable surfaces was being
       displayed as a back face. This arose as a "hack" when these functions
       were
        first implemented because the cross-product used to create the normals
        was
         right-handed, thus the triangulation orientation was clockwise.
          Additionally there were weird triangulations in the
          ParametricSuperEllipsoid
           and ParametricSuperToroid.
      
           The following three fixes have been applied:
      
           1) The orientation of the normals is fixed in the case of
           anti-clockwise
              ordering by calculating cross(Dv,Du) instead of cross(Du,Dv).
      	   When this is done the normals point in the expected direction
      	   and the
      	      front face is rendered correctly. See:
      	      vtkParametricFunctionSource.cxx.
      	      2) All the surfaces now implement anti-clockwise ordering
      	      with respect to the
      	         triangulation.
      		 3) The ParametricSuperEllipsoid and ParametricSuperToroid
      		 have been reworked,
      		    now the surface is constructed as four pieces that are
      		    abutted together,
      		       this removes the triangulations resulting in weird
      		       appearances.
      		       4) In order to implement the anti-clockwise
      		       ordering in the triangulation
      		          the x, y points have had to be swapped in a few
      			  cases.
      			  5) TestParametricFunctions.png has had to be
      			  replaced. The images for
      			     ParametricTorus, ParametricSuperEllipsoid and
      			     ParametricSuperToroid
      			        changed as a result of the above changes
      d3d9bf72
  3. 11 Oct, 2016 1 commit
    • Andrew Maclean's avatar
      Fixing the triangulation of the Parametric Surfaces. · c7b75843
      Andrew Maclean authored
      Bill Lorenson noticed that the front face of orientable surfaces was being
       displayed as a back face. This arose as a "hack" when these functions
       were
        first implemented because the cross-product used to create the normals
        was
         right-handed, thus the triangulation orientation was clockwise.
          Additionally there were weird triangulations in the
          ParametricSuperEllipsoid
           and ParametricSuperToroid.
      
           The following three fixes have been applied:
      
           1) The orientation of the normals is fixed in the case of
           anti-clockwise
              ordering by calculating cross(Dv,Du) instead of cross(Du,Dv).
      	   When this is done the normals point in the expected direction
      	   and the
      	      front face is rendered correctly. See:
      	      vtkParametricFunctionSource.cxx.
      	      2) All the surfaces now implement anti-clockwise ordering
      	      with respect to the
      	         triangulation.
      		 3) The ParametricSuperEllipsoid and ParametricSuperToroid
      		 have been reworked,
      		    now the surface is constructed as four pieces that are
      		    abutted together,
      		       this removes the triangulations resulting in weird
      		       appearances.
      		       4) In order to implement the anti-clockwise
      		       ordering in the triangulation
      		          the x, y points have had to be swapped in a few
      			  cases.
      			  5) TestParametricFunctions.png has had to be
      			  replaced. The images for
      			     ParametricTorus, ParametricSuperEllipsoid and
      			     ParametricSuperToroid
      			        changed as a result of the above changes
      c7b75843
  4. 23 Sep, 2016 1 commit
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      Utilities/Maintenance/vtk-reindent-code.py
      
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      
      The bash command line used was the following:
      
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
        done
      done
      f830ff47
  5. 08 Mar, 2016 1 commit
  6. 03 Nov, 2015 1 commit
  7. 30 Oct, 2015 1 commit
    • Tim Meehan's avatar
      Added some new parametric functions · b2233c75
      Tim Meehan authored
      I looked around for some interesting parametric functions to add. These are
      all surfaces, and the parametrizations do not use special functions.
      b2233c75