Merge topic 'fix-warnings'

f852a997 vtkPointSetToMoleculeFilter: fix cppcheck warnings
171beeb8 TestXMLWriteRead: fix cppcheck warnings.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !4342

Domains/Chemistry/vtkPointSetToMoleculeFilter.cxx

@@ -27,9 +27,9 @@ vtkStandardNewMacro(vtkPointSetToMoleculeFilter);
 
 //----------------------------------------------------------------------------
 vtkPointSetToMoleculeFilter::vtkPointSetToMoleculeFilter()
+  : ConvertLinesIntoBonds(true)
 {
   this->SetNumberOfInputPorts(1);
-  this->ConvertLinesIntoBondsOn();
 
   // by default process active point scalars
   this->SetInputArrayToProcess(

IO/XML/Testing/Cxx/TestXMLWriteRead.cxx

@@ -25,7 +25,7 @@
 namespace
 {
 template <typename T>
-int TestConvertType(std::string type, std::string fileName);
+int TestConvertType(const std::string& type, const std::string& fileName);
 }
 int TestXMLWriteRead(int argc, char* argv[])
 {
@@ -50,7 +50,7 @@ int TestXMLWriteRead(int argc, char* argv[])
 namespace
 {
 template <typename T>
-int TestConvertType(std::string type, std::string fileName)
+int TestConvertType(const std::string& type, const std::string& fileName)
 {
   std::cout << "Testing type " << type << std::endl;