Skip to content
  • Utkarsh Ayachit's avatar
    Clean Python related CMake variables. · b94049f6
    Utkarsh Ayachit authored
    This change removes `VTK_INSTALL_PYTHON_MODULE_DIR` and
    `VTK_BUILD_PYTHON_MODULE_DIR` cmake variables. These were cache
    variabels and they were force set using Python version number the first
    time CMake was run. This has the issue of leaving an obsolete value if
    Python version was changed in CMake config after the first cmake pass.
    
    Secondly, the two variables complicated module path setup logic since
    build and install directory structure for Python modules could
    potentially be different.
    
    Simplified this as follows:
    
    `VTK_PYTHON_SITE_PACKAGES_SUFFIX` is a new CMake variable available
    for users to set to the "site-packges" suffix to use for build and
    install trees. This is non-cache variable and hence we we update it
    when Python version is changed in subsequent cmake configurations
    without issues (unless explicitly overridden).
    
    The build and install directories for Python modules are set as
    `${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${VTK_PYTHON_SITE_PACKAGES_SUFFIX}`,
    `${VTK_INSTALL_LIBRARY_DIR}/${VTK_PYTHON_SITE_PACKAGES_SUFFIX}`
    respectively. Thus, we are assured that build and install tree
    structures won't differ. `VTK_BUILD_PYTHON_MODULES_DIR` and
    `VTK_INSTALL_PYTHON_MODULES_DIR` internal cache variable are available
    as shortcuts for these two paths, but we may purge them in future.
    b94049f6